Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211029001225.27218-1-julianbraha@gmail.com>
In-Reply-To: <20211029001225.27218-1-julianbraha@gmail.com>
From:   Tzung-Bi Shih <tzungbi@google.com>
Date:   Fri, 29 Oct 2021 10:20:33 +0800
Message-ID: <CA+Px+wUi6t3n64EPWqX0Q3vMUkBw7UrRBK_5RwnVtNsa-ZuLGw@mail.gmail.com>
Subject: Re: [PATCH] ASoC: fix unmet dependencies on GPIOLIB for SND_SOC_RT1015P
To:     Julian Braha <julianbraha@gmail.com>
Cc:     broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
        tiwai@suse.com, matthias.bgg@gmail.com, trevor.wu@mediatek.com,
        Jiaxin.Yu@mediatek.com, arnd@arndb.de, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, fazilyildiran@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 29, 2021 at 8:12 AM Julian Braha <julianbraha@gmail.com> wrote:
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
>   Selected by [y]:
>   - SND_SOC_MT8192_MT6359_RT1015_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8192 [=y] && MTK_PMIC_WRAP [=y]
The block is not for RT1015P but it can also be fixed by the patch.

[...]

> This is because these config options select SND_SOC_RT1015P
> without selecting or depending on GPIOLIB, despite
> SND_SOC_RT1015P depending on GPIOLIB.
>
> These unmet dependency bugs were detected by Kismet,
> a static analysis tool for Kconfig. Please advise if this
> is not the appropriate solution.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Acked-by: Tzung-Bi Shih <tzungbi@google.com>