Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     jiabing.wan@qq.com, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] hwmon: (nct7802) Add of_node_put() before return
Date:   Thu, 28 Oct 2021 22:49:18 -0400
Message-Id: <20211029024918.5161-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5HMDGIGHkPFm5g2coFjOGsLNwqfcR/bRrEio90qo2nZ98x1qrPEh3OUdvSh6?=
 =?us-ascii?Q?ruS7QxuMbyQm7FrIVqgMxCGC8Vb6cMIvX45cFtEG7diI8QYMYWcwh5ojsKEh?=
 =?us-ascii?Q?c3p5Yt4GdCOPrPvHmAPSLYzfnb6RIfjN80cG0AOmE08dDhdink6JRSMXROTQ?=
 =?us-ascii?Q?ZOmsvBLTeP5CcDFF4JgGxtXjgmk1dherPQuDbTUySrXFlluwh7mNvMUz1rVI?=
 =?us-ascii?Q?txUpeIyAbp5/f3sMY3Qvijnj5Ufsh+klQl8RzTaxHzKuTaHr7gsuT6cpFvwB?=
 =?us-ascii?Q?HyIxhWaNobBn/pvP3JvW+mMkFKCpDg2aSAq8CqveY7Mxd7mlqkTyxTzyXu3S?=
 =?us-ascii?Q?pZoDDHCUgdbGSguZX0EdsAvH8o4WOJKFl6yYcDIz1IFKRVeJEyKJ8vntEkzZ?=
 =?us-ascii?Q?COEt14qGQ02C7j3ShQo7HSFXWFWnrM5qs1thKP6/mE/WPMdiRaW92vOQefMY?=
 =?us-ascii?Q?PrYEvhSq3VPQ83J+1hjZ/QpHcL+lZ3WienSE4MwLsKo0Prk+TpfnZ05CxFl0?=
 =?us-ascii?Q?any3wOoZehDKVebuP+3VS4ianRfHv+z92azwzn2v0lFhw+hB0zELTsTWtiNJ?=
 =?us-ascii?Q?No/gzZNdKZdnidgNCKpqYWh3WgGkqVzrsC9/cpwNM2Q47pio+U9Nz5yrMiiE?=
 =?us-ascii?Q?oR59o9n9IsJe3NkoONteRGmU/2WWkF+9H9nvCtYLHt3+5xOi54Nvb/HoCwz4?=
 =?us-ascii?Q?El+S1aLm/bfpQpCFBAKCNo5PC1WLoG/eW0sCggx93QNC3xkoW+L4C8c38cUY?=
 =?us-ascii?Q?04J+tY4/TyvHJSjMuhovYbLUn19fneyjkQ2Rleox0kKGfEdLGmmuFVDqEj/P?=
 =?us-ascii?Q?HVayZMe4CSDPdCDg0D85cIi8sto5vImyMy98kBJY3jIqBiaiqpLot3P2QwJW?=
 =?us-ascii?Q?a5/QWuQ+NmwJxI4EYs3LAade/jddSkwFIwDFAzxHrFZ2UVZ3ktJoumUg9DDA?=
 =?us-ascii?Q?7wWDXu9um45YRMiLIC3qb1NImuJqdLeGjz+dFoMJjR6S7ZLuNR4PgGeKokhF?=
 =?us-ascii?Q?vLpiKsfR9BhxhoxVTOQtksItrxTg5pQwcjGpwCYJdlHG/Cfhdzx2ig9JIb0j?=
 =?us-ascii?Q?jGuJmHMI4DDxrVIjpttUfB/nNzIVTyFvoyz/hP7pCkH45bnh3BODs1Twjenl?=
 =?us-ascii?Q?oDyZz5xA/x91XPZzpxAMax+bItMnImsafrJNCDoi4WKcDbl74v7QV1eRAl51?=
 =?us-ascii?Q?KdhaoxO/Ev0arivR6cvsZggp7rlPlmtXsX7mcKF2DegyeTStHV3k83+5ivS/?=
 =?us-ascii?Q?BDR4kg5Uucwxa0VDAa2SIs3XheONUEIQ2rvjdCiH83MP6/FUI4IkqZDdlE6i?=
 =?us-ascii?Q?YCZeQyoNFirPkxiTNUtIaWNhVSNSANLhKE9jK8Ycz+LxQsnx107DZRhFwRqs?=
 =?us-ascii?Q?csNaPuOukmu9ubd/pz64cQnzQULuENvbxgdG5yAGiiPvsmNPTKEf6GL257PU?=
 =?us-ascii?Q?M2p8O76N3DSs4byX6haLuD9u7RZmcLzBpoqVgqrQCn/JFaPx6r5Sw4O7DHrw?=
 =?us-ascii?Q?mVLiNjhq1Nhwu10iG9IPaQ4KLrDc4zlDjaERmhIb/UhyBVExigtWp4aKDrW7?=
 =?us-ascii?Q?C0yHv80UDtM2GtyxpIEc8sGSzUPl1l3TUcDIWeVik7HH7Kz34sdWfVJ6jxgB?=
 =?us-ascii?Q?lpIdHldR7Ktak977T56oIGk=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 109e3644-d00c-442f-5173-08d99a86c4e8
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 02:49:47.3608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jYJcHBEq5iw9RrFX19WHfpZaxjd/geshyoYQHQexQjp4pB40OYmIJqSQeNFXsR0z9iwHR0o4YAfPPOBN4WY7xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3580
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/hwmon/nct7802.c:1152:2-24: WARNING: Function
for_each_child_of_node should have of_node_put() before return.

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/hwmon/nct7802.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
index d56f78327619..d1eeef02b6dc 100644
--- a/drivers/hwmon/nct7802.c
+++ b/drivers/hwmon/nct7802.c
@@ -1152,8 +1152,10 @@ static int nct7802_configure_channels(struct device *dev,
 		for_each_child_of_node(dev->of_node, node) {
 			err = nct7802_get_channel_config(dev, node, &mode_mask,
 							 &mode_val);
-			if (err)
+			if (err) {
+				of_node_put(node);
 				return err;
+			}
 		}
 	}
 
-- 
2.20.1