Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2282578pxb; Thu, 28 Oct 2021 20:56:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8C8yVeyrT5EtD4QP7YXDxI0kknzd39QDj/K6AenzRZzr5Nevj+1ZLFmGki5CRArl2MXUf X-Received: by 2002:a17:902:a710:b029:12b:9b9f:c461 with SMTP id w16-20020a170902a710b029012b9b9fc461mr7507352plq.59.1635479816547; Thu, 28 Oct 2021 20:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635479816; cv=none; d=google.com; s=arc-20160816; b=oRgyuGD/dLiZynZRr3zpNpTn/QRHJZIIRecnsh41ZI2Lecr821TwMJcEAU9vu+ydrW mPjFE95uNbZJMvzGwzLbef+V5i22YuE6vwZAoAKWHp+W8roLVs4El/2KtUdsXDp5QVxJ 3SkeeyAAzriyzTRQNpd4YIy/n/GW8xKXLYdZfC3LZzKfVIrNP4lM9DD/Hw65W/HO/sXu wilBK9jCtL3boxO1gywpKh1xNU0a36Y9rCz/E8XmCVqjbOQtMMSByds4yEzGqIE0asnP 32/RZrrnJ4sw8ldhQvZUOyvl0UjGls4XaDIalNfBlJY35i+AcR2Ij5QvK145u9k3ilJy DJ0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=m3GBKWxJE9a7PO+zNCYwm8edr0oXFN5YomdA1BbHK9w=; b=QXvUJ2rzJcVD8aoKqF9lwkh4Z64tMiSbwLPX+H5E2Dz32lllUE7ML5UpbKHTrjYW7n T/ihwmgbuOL8GeDRi0sZQF2mFyextjA3su2DXOI6lthpl4Prtqd7hIcjzuTLex+UY3Fa 4dAxoXtYjwEDDOxkYY34MvcLrpJTn7LEzl8WwjwuTJAXayeQ/gN7zc4wZEp4N8kFGx7b lpVkc7RscG4VQ8RJb8r3cxbjlNZhux5yfh2xBq/neh59S5VB8Ac+2y8vbXpy0CQczOhV XHLz7ZTjMo6RluoNG064gEPpsopPgwyaHEJpR5kgeaYW8ZXU2WoPEYzPNGVSYf540k4o rPaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s14si7782765pfg.71.2021.10.28.20.56.43; Thu, 28 Oct 2021 20:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231755AbhJ2D6H (ORCPT + 99 others); Thu, 28 Oct 2021 23:58:07 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:44086 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231741AbhJ2D6G (ORCPT ); Thu, 28 Oct 2021 23:58:06 -0400 X-UUID: 976d263f3dd94d6898f72fac9b1fe618-20211029 X-UUID: 976d263f3dd94d6898f72fac9b1fe618-20211029 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1525981931; Fri, 29 Oct 2021 11:55:33 +0800 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 29 Oct 2021 11:55:31 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs10n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Fri, 29 Oct 2021 11:55:30 +0800 From: Yunfei Dong To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa CC: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , , , , , , , , Tzung-Bi Shih Subject: [PATCH v8, 01/17] media: mtk-vcodec: Get numbers of register bases from DT Date: Fri, 29 Oct 2021 11:55:11 +0800 Message-ID: <20211029035527.454-2-yunfei.dong@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211029035527.454-1-yunfei.dong@mediatek.com> References: <20211029035527.454-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Different platform may has different numbers of register bases. Gets the numbers of register bases from DT (sizeof(u32) * 4 bytes for each). Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 37 ++++++++++++++----- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c index e6e6a8203eeb..59caf2163349 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c @@ -78,6 +78,30 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) return IRQ_HANDLED; } +static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev) +{ + struct platform_device *pdev = dev->plat_dev; + int reg_num, i; + + /* Sizeof(u32) * 4 bytes for each register base. */ + reg_num = of_property_count_elems_of_size(pdev->dev.of_node, "reg", + sizeof(u32) * 4); + if (reg_num <= 0 || reg_num > NUM_MAX_VDEC_REG_BASE) { + dev_err(&pdev->dev, "Invalid register property size: %d\n", reg_num); + return -EINVAL; + } + + for (i = 0; i < reg_num; i++) { + dev->reg_base[i] = devm_platform_ioremap_resource(pdev, i); + if (IS_ERR(dev->reg_base[i])) + return PTR_ERR(dev->reg_base[i]); + + mtk_v4l2_debug(2, "reg[%d] base=%p", i, dev->reg_base[i]); + } + + return 0; +} + static int fops_vcodec_open(struct file *file) { struct mtk_vcodec_dev *dev = video_drvdata(file); @@ -206,7 +230,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev) struct resource *res; phandle rproc_phandle; enum mtk_vcodec_fw_type fw_type; - int i, ret; + int ret; dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); if (!dev) @@ -238,14 +262,9 @@ static int mtk_vcodec_probe(struct platform_device *pdev) goto err_dec_pm; } - for (i = 0; i < NUM_MAX_VDEC_REG_BASE; i++) { - dev->reg_base[i] = devm_platform_ioremap_resource(pdev, i); - if (IS_ERR((__force void *)dev->reg_base[i])) { - ret = PTR_ERR((__force void *)dev->reg_base[i]); - goto err_res; - } - mtk_v4l2_debug(2, "reg[%d] base=%p", i, dev->reg_base[i]); - } + ret = mtk_vcodec_get_reg_bases(dev); + if (ret) + goto err_res; res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); if (res == NULL) { -- 2.25.1