Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 Oct 2021 08:20:11 +0200
From:   Steffen Klassert <steffen.klassert@secunet.com>
To:     luo penghao <cgel.zte@gmail.com>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        luo penghao <luo.penghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH ipsec-next v2] xfrm: Remove redundant fields and related
 parentheses
Message-ID: <20211029062011.GH3027429@gauss3.secunet.de>
References: <20211028023639.9914-1-luo.penghao@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211028023639.9914-1-luo.penghao@zte.com.cn>
Precedence: bulk

On Thu, Oct 28, 2021 at 02:36:39AM +0000, luo penghao wrote:
> The variable err is not necessary in such places. It should be revmoved
> for the simplicity of the code. This will cause the double parentheses
> to be redundant, and the inner parentheses should be deleted.
> 
> The clang_analyzer complains as follows:
> 
> net/xfrm/xfrm_input.c:533: warning:
> net/xfrm/xfrm_input.c:563: warning:
> 
> Although the value stored to 'err' is used in the enclosing expression,
> the value is never actually read from 'err'.
> 
> Changes in v2:
> 
> Modify the title, because v2 removes the brackets.
> Remove extra parentheses.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>

Applied, thanks a lot!