Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2502710pxb; Fri, 29 Oct 2021 02:44:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlhMbUFn8Yw/dgUC1Qn0FWHPRHkcNDE5AkNhBX+TzwsBn6rY7xoZRcWdqDIcGf8j7tNgJ4 X-Received: by 2002:a05:6402:35d6:: with SMTP id z22mr13955023edc.93.1635500689419; Fri, 29 Oct 2021 02:44:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635500689; cv=none; d=google.com; s=arc-20160816; b=ngFPmKVzxd3qYhpILOIjFGdriQ5xUmpssuvh6L22nN3UPcBqLNduslMOIdauquKeHI jOeOSMZDf1W+Q18gdJXtkj5a4O80az/lrUa2c4t89amwHAOvDvMmS3zq63wXUE5xtp7a DJa2pIOz+UIGDYh2Dbg4hLz22f/3poTKP1aPIzZhuKmM+8qI7VAeiWz1DykISQCMyMOa 2wxDmFuW7nJMbQ5u6Z8+bSlXOb1v/zyfXOyRXbas3jODaEIxf0XMFMLC3zsrIfq9G58T r9UTZSFEEdplQRCGGz8g2wlP3Ed8LJ39yrZAMFvSHHbRvQCesiFdxyts88ZhiwVmP8Zq GxMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=xajV0wH110xtFZJRDmVjekuquRc/wm4T+rNb9+XSUmE=; b=tRWZjgsenplW0dmYk2VAnBt3504wcB3vHxdiTunDp2f/6HjVgCxDNzZZfSfyHYDed2 gFmyhpxKW/caz6XceeyDEVrSEfJCNn487IvA7LGmu243TNV0fASZswBkd5iUzFyHw5O1 c5shl62zwcRBHZqZZFv7LNn8x5DOHewtOkoodOWFnHuX/4l7AYaXSl+0PWi2TkvzPFQv hl3ZywcTU10DSWSIMmOPiHeXYe6BkND9DFNHftJoEPrK2BpwKvOTF/O2anEo8DMnSXY4 1OK4CpsOXi+fL2NQxBn7R8hIfC1rgbUbI4+llBltJAvgL2R5nNaQOGCfPbqeq7BeFBSk mguQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qw1si8873704ejc.370.2021.10.29.02.44.26; Fri, 29 Oct 2021 02:44:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231710AbhJ2Job (ORCPT + 99 others); Fri, 29 Oct 2021 05:44:31 -0400 Received: from mga04.intel.com ([192.55.52.120]:50910 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbhJ2Jo2 (ORCPT ); Fri, 29 Oct 2021 05:44:28 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="229360121" X-IronPort-AV: E=Sophos;i="5.87,192,1631602800"; d="scan'208";a="229360121" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 02:41:57 -0700 X-IronPort-AV: E=Sophos;i="5.87,192,1631602800"; d="scan'208";a="498845521" Received: from rdutta-mobl3.gar.corp.intel.com (HELO lkp-bingo.ccr.corp.intel.com) ([10.255.31.247]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 02:41:53 -0700 From: Li Zhijian To: dave@stgolabs.net, joel@joelfernandes.org, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, rostedt@goodmis.org, rcu@vger.kernel.org Cc: philip.li@intel.com, lizhijian@cn.fujitsu.com, jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, Li Zhijian Subject: [PATCH 5/6] rcuscale: alwaly log error message Date: Fri, 29 Oct 2021 17:40:28 +0800 Message-Id: <20211029094029.22501-6-zhijianx.li@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211029094029.22501-1-zhijianx.li@intel.com> References: <20211029094029.22501-1-zhijianx.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Generally, error message should be logged anyhow. Signed-off-by: Li Zhijian --- kernel/rcu/rcuscale.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c index 2cc34a22a506..5c8449a8827a 100644 --- a/kernel/rcu/rcuscale.c +++ b/kernel/rcu/rcuscale.c @@ -50,8 +50,8 @@ MODULE_AUTHOR("Paul E. McKenney "); pr_alert("%s" SCALE_FLAG " %s\n", scale_type, s) #define VERBOSE_SCALEOUT_STRING(s) \ do { if (verbose) pr_alert("%s" SCALE_FLAG " %s\n", scale_type, s); } while (0) -#define VERBOSE_SCALEOUT_ERRSTRING(s) \ - do { if (verbose) pr_alert("%s" SCALE_FLAG "!!! %s\n", scale_type, s); } while (0) +#define SCALEOUT_ERRSTRING(s) \ + pr_alert("%s" SCALE_FLAG "!!! %s\n", scale_type, s) /* * The intended use cases for the nreaders and nwriters module parameters @@ -514,11 +514,11 @@ rcu_scale_cleanup(void) * during the mid-boot phase, so have to wait till the end. */ if (rcu_gp_is_expedited() && !rcu_gp_is_normal() && !gp_exp) - VERBOSE_SCALEOUT_ERRSTRING("All grace periods expedited, no normal ones to measure!"); + SCALEOUT_ERRSTRING("All grace periods expedited, no normal ones to measure!"); if (rcu_gp_is_normal() && gp_exp) - VERBOSE_SCALEOUT_ERRSTRING("All grace periods normal, no expedited ones to measure!"); + SCALEOUT_ERRSTRING("All grace periods normal, no expedited ones to measure!"); if (gp_exp && gp_async) - VERBOSE_SCALEOUT_ERRSTRING("No expedited async GPs, so went with async!"); + SCALEOUT_ERRSTRING("No expedited async GPs, so went with async!"); if (torture_cleanup_begin()) return; @@ -845,7 +845,7 @@ rcu_scale_init(void) reader_tasks = kcalloc(nrealreaders, sizeof(reader_tasks[0]), GFP_KERNEL); if (reader_tasks == NULL) { - VERBOSE_SCALEOUT_ERRSTRING("out of memory"); + SCALEOUT_ERRSTRING("out of memory"); firsterr = -ENOMEM; goto unwind; } @@ -865,7 +865,7 @@ rcu_scale_init(void) kcalloc(nrealwriters, sizeof(*writer_n_durations), GFP_KERNEL); if (!writer_tasks || !writer_durations || !writer_n_durations) { - VERBOSE_SCALEOUT_ERRSTRING("out of memory"); + SCALEOUT_ERRSTRING("out of memory"); firsterr = -ENOMEM; goto unwind; } -- 2.32.0