Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2509701pxb; Fri, 29 Oct 2021 02:55:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNahbqPyV6M3bDJKgUnnsDa/y6sr2pOpjWMVCTrP79eyiy7NIkbfdiVOIlQloFW8sKWJrG X-Received: by 2002:a17:907:6d29:: with SMTP id sa41mr2943144ejc.522.1635501338819; Fri, 29 Oct 2021 02:55:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635501338; cv=none; d=google.com; s=arc-20160816; b=xV/UB0YmLzRxO0NVI3H6XHxh/MKsgH8vFY6byAg3iXN9tuNCPWvXf4yI+LFMpMhrVF CZlBooa3/l5IfXxMkcufQZBf9i+fsu5jkBCN2Wexe2oyZK/qknzaJI6lGjFQUF/yrw7N qWyguA8U7KkW7mjF8Mxi242bNDqg12MG+uCIdjITdKsGzRPJ1US3rqWd0no4vQ9FY0LP yyPWu+EAAMdcH/3G1K3ODU8zkjZLosHnx1CR3pF6E1ADEP3sr3BlljqKjDQuacbLYIuN b2Bch9gdM26+S2SKU9X8laFN+TFRjtWzuFq2Ao709ahh5MvDciuzItiZT3RJPNigs0UF PFCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Dh4bLf/aUHMAWBmMu6W8jSvg98euAvg7YGHZ1NBGI0g=; b=UfiOQOCmts2lz2Pj9AwmgNJMys5bODWDv4lgoxy9stuowgvEIz7XjfWkqX52I+oYhX Z61k8qlhlrwtB9q4elr/dc/Q3jFkDl79u5pATQbbwo8srKA4iBlm0oxfXCY9Pbsc7/bK t8EY/cWo1SnEEXCYaovQvjki/uyt1P2phkb+FQ3nvk9JzJ3dXpJ0KYeu60ICsrenseX2 p9LXFpMSut8UrvlYi4c90MCvmwI3y+Ki+Q8pqydkgGeYIOnNohNcsmv++ySfLbS0St8E zB7QjJzq/hhejRaIHqG8li/CGdxN+c7cglqDmEF12QcwQGOxA67to83Fl9VHA/j6Wij6 hc5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v8si8185037eda.402.2021.10.29.02.55.13; Fri, 29 Oct 2021 02:55:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231585AbhJ2JxZ (ORCPT + 99 others); Fri, 29 Oct 2021 05:53:25 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:52006 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbhJ2JxY (ORCPT ); Fri, 29 Oct 2021 05:53:24 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Uu7viOe_1635501035; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Uu7viOe_1635501035) by smtp.aliyun-inc.com(127.0.0.1); Fri, 29 Oct 2021 17:50:54 +0800 From: Jiapeng Chong To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] block: ataflop: Fix warning comparing pointer to 0 Date: Fri, 29 Oct 2021 17:50:29 +0800 Message-Id: <1635501029-81391-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/block/ataflop.c:1464:20-21: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/block/ataflop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c index 2622803..d14bdc3 100644 --- a/drivers/block/ataflop.c +++ b/drivers/block/ataflop.c @@ -1460,8 +1460,7 @@ static int floppy_revalidate(struct gendisk *disk) unsigned int drive = p - unit; if (test_bit(drive, &changed_floppies) || - test_bit(drive, &fake_change) || - p->disktype == 0) { + test_bit(drive, &fake_change) || !p->disktype) { if (UD.flags & FTD_MSG) printk(KERN_ERR "floppy: clear format %p!\n", UDT); BufferDrive = -1; -- 1.8.3.1