Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 Oct 2021 12:21:27 +0200
From:   Vasily Gorbik <gor@linux.ibm.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org,
        Linux Kernel Functional Testing <lkft@linaro.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Heiko Carstens <hca@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: add <linux/minmax.h> to <asm/facility.h>
Message-ID: <your-ad-here.call-01635502887-ext-5860@work.hours>
References: <20211029002633.31323-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211029002633.31323-1-rdunlap@infradead.org>
MIME-Version: 1.0
Precedence: bulk

On Thu, Oct 28, 2021 at 05:26:33PM -0700, Randy Dunlap wrote:
> S390's <asm/facility.h> uses the min_t() macro, so it should
> include <linux/minmax.h> to avoid build errors.
> 
> In file included from arch/s390/pci/pci_insn.c:12:
> arch/s390/include/asm/facility.h: In function '__stfle':
> arch/s390/include/asm/facility.h:98:22: error: implicit declaration of
> function 'min_t' [-Werror=implicit-function-declaration]
>    98 |                 nr = min_t(unsigned long, (nr + 1) * 8, size * 8);
> arch/s390/include/asm/facility.h:98:28: error: expected expression
> before 'unsigned'
>    98 |                 nr = min_t(unsigned long, (nr + 1) * 8, size * 8);

Thank you, but it has been addressed in latest linux-next by:
https://lore.kernel.org/all/20211028170143.56523-1-andriy.shevchenko@linux.intel.com/