Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211014223125.2605031-1-suzuki.poulose@arm.com> <20211014223125.2605031-10-suzuki.poulose@arm.com>
In-Reply-To: <20211014223125.2605031-10-suzuki.poulose@arm.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Fri, 29 Oct 2021 12:31:52 +0200
Message-ID: <CAK8P3a0=GC26FBuyoj2Q02VXdfkOd4k0DiDfp+0KF3C6tNO3XQ@mail.gmail.com>
Subject: Re: [PATCH v5 09/15] coresight: trbe: Add infrastructure for Errata handling
To:     Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     Will Deacon <will@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>, Marc Zyngier <maz@kernel.org>,
        coresight@lists.linaro.org,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 15, 2021 at 12:31 AM Suzuki K Poulose
<suzuki.poulose@arm.com> wrote:
>
> +static void trbe_check_errata(struct trbe_cpudata *cpudata)
> +{
> +       int i;
> +
> +       for (i = 0; i < TRBE_ERRATA_MAX; i++) {
> +               int cap = trbe_errata_cpucaps[i];
> +
> +               if (WARN_ON_ONCE(cap < 0))
> +                       return;
> +               if (this_cpu_has_cap(cap))
> +                       set_bit(i, cpudata->errata);
> +       }
> +}

this_cpu_has_cap() is private to arch/arm64 and not exported, so this causes
a build failure when used from a loadable module:

ERROR: modpost: "this_cpu_has_cap"
[drivers/hwtracing/coresight/coresight-trbe.ko] undefined!

Should this symbol be exported or do we need a different workaround?

       Arnd