Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 Oct 2021 13:18:29 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     linux-can@vger.kernel.org, Lukas Magel <lukas.magel@escrypt.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] can: etas_es58x: es58x_init_netdev: populate
 net_device::dev_port
Message-ID: <20211029111829.crrwdjizlflzzhq2@pengutronix.de>
References: <20211026180553.1953189-1-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uy25gtrfe76thjxs"
Content-Disposition: inline
In-Reply-To: <20211026180553.1953189-1-mailhol.vincent@wanadoo.fr>
Precedence: bulk


--uy25gtrfe76thjxs
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 27.10.2021 03:05:53, Vincent Mailhol wrote:
> The field dev_port of struct net_device indicates the port number of a
> network device [1]. This patch populates this field.
>=20
> This field can be helpful to distinguish between the two network
> interfaces of a dual channel device (i.e. ES581.4 or ES582.1). Indeed,
> at the moment, all the network interfaces of a same device share the
> same static udev attributes c.f. output of:
>=20
> | udevadm info --attribute-walk /sys/class/net/canX
>=20
> The dev_port attribute can then be used to write some udev rules to,
> for example, assign a permanent name to each network interface based
> on the serial/dev_port pair (which is convenient when you have a test
> bench with several CAN devices connected simultaneously and wish to
> keep consistent interface names upon reboot).
>=20
> [1] https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-net
>=20
> Suggested-by: Lukas Magel <lukas.magel@escrypt.com>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

Applied to linux-can-next/testing.

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--uy25gtrfe76thjxs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmF72IIACgkQqclaivrt
76n3lwgAr84LUlouhT0DZCuwsQHZBXAVmr3wUfbQ6Uk4RKffeVuoIhKUpbeNIDPc
CWYJZP9nAcKLgHaLABPyEnP9urU2kytPXw4b/Z7yuKTSaJmfcM3Jedl3aQXdqiTT
LoyD5V/BO76NvTWicez6hbPzIgQbcuQW4VnMWM+sE9I5W43M0al+UC9eSj44xhyQ
Oy20F0y478r+xp8JtsYNNQXZ2WLqnOJN4MaC0j217WAQ6JX5GQ7GHaIiUEiFPHng
gP4unE2lyBwC/TGtkHzxVZ7bMPqCJ+Hcsuapwrll/KmImN2vRQDQJ8aGHo7lA/ua
yn5EmHQpE6xoHuZPGHoNBVmBfRedAw==
=y899
-----END PGP SIGNATURE-----

--uy25gtrfe76thjxs--