Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 Oct 2021 13:20:49 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     linux-can <linux-can@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] can: etas_es58x: es58x_rx_err_msg: fix memory leak in
 error path
Message-ID: <20211029112049.j3wbh2aka4qfeq5l@pengutronix.de>
References: <20211026180740.1953265-1-mailhol.vincent@wanadoo.fr>
 <20211027073905.aff3mmonp7a3itrn@pengutronix.de>
 <CAMZ6RqKC2SXsDE2pvNw0LT9TsOHR9W-evTqzv35W+-Dtd-Peow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3ontns5duwddut54"
Content-Disposition: inline
In-Reply-To: <CAMZ6RqKC2SXsDE2pvNw0LT9TsOHR9W-evTqzv35W+-Dtd-Peow@mail.gmail.com>
Precedence: bulk


--3ontns5duwddut54
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 27.10.2021 17:48:21, Vincent MAILHOL wrote:
> On Wed. 27 Oct 2021 at 16:39, Marc Kleine-Budde <mkl@pengutronix.de> wrot=
e:
> > On 27.10.2021 03:07:40, Vincent Mailhol wrote:
> > > In es58x_rx_err_msg(), if can->do_set_mode() fails, the function
> > > directly returns without calling netif_rx(skb). This means that the
> > > skb previously allocated by alloc_can_err_skb() is not freed. In other
> > > terms, this is a memory leak.
> > >
> > > This patch simply removes the return statement in the error branch and
> > > let the function continue.
> > >
> > > * Appendix: how the issue was found *
> >
> > Thanks for the explanation, but I think I'll remove the appendix while
> > applying.
>=20
> The commit will have a link to this thread so if you don't mind,
> I suggest to replace the full appendix with:
>=20
> Issue was found with GCC -fanalyzer, please follow the link below
> for details.

Makes sense, good idea.

> You can of course do the same for the m_can patch.

ACK

Added to linux-can/testing, will send it out once v5.15 is out.

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--3ontns5duwddut54
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmF72Q8ACgkQqclaivrt
76lmjggAgVEFYhCSrfVs/XJ4BtVqBfoSfVDyDSH72wrrpPjSJmnhF3lpmEYSbtGV
UurPx4ZtIQcwAxEYMshYoN4HLLuM7j3SDJjWrNjKJuaLORG4SiMakohlX4Begpw2
V4p9xBKXxfYxBL0v/9r0+3bz+74bUuBEP42BldIf9h4iGrIGoQO4gPgKOhs5kBqL
6JIInyktdt1cCW2P/Tui2w5axJ557RO6ObEMquXZA41XzrvS8FZxJqE60ic7WRo/
2K+VDhJEO3kvOjuRlBEXM+128pEnRBOmWrf7vH9rFx5tgHxOteXU8pix0nkQM+v9
9IDmxxH1fTEt6+h4pPaBandCRH/wVQ==
=njFK
-----END PGP SIGNATURE-----

--3ontns5duwddut54--