Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp5869pxb; Fri, 29 Oct 2021 04:51:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzF8iB7tuAPKtLzB0+Qo3nIaJh9OozaMlrGjM1NlJYGMXF1Y+0mB5TUFz5UgmEct3wR2zBy X-Received: by 2002:a17:90a:1101:: with SMTP id d1mr19589601pja.205.1635508263866; Fri, 29 Oct 2021 04:51:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635508263; cv=none; d=google.com; s=arc-20160816; b=MUytrUJ9BzfJC7m41f3QpIp0NfwBWzPV6D5j5Os4sFJOtxCbX3QxmGKLfiaZb/C+fs GRxWVVSrWO7OidXDgrfHLfsGk5soKDGrohTapzHy9nv+633Aqvq52uW0ehZ3i3raH3/+ jm5duFIi1XkKcgyg8P8UXXRByfuv32oGtT2UjdfFkAImPmWesh7vIqU0vuovwAXHrkHb XyYTbBxDaRzMTRyBexqv5pYA4odXRGkAIs3xp6bAevEZa+1Vzg8J+ZIVqpWRteJWBqHI 6oq1g3fzTBb2fEdv9RGVgz35F2rjTgWd6qY5ycbXm6XlBEyELH7e+IXlodtmK17OF3/9 J8Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=StjxPmHbHV6DoGxBQRE845mNMc3Ctk24wBQy3SQxS5Y=; b=HyeNuFcKlHxO0+5S9XSmQid3DAfAMQdC6tujlWFloesNDoL1UFaXToA+imewuBILjo 1vqW8/B0z7eIlvTyMoBk8OiTTqjwGsD9Vp8DQyRh/CJGSq5uow5xcfmnFpmikqy2wGW/ 4HAZZpGeqms2H1u3yiDlYI1qdlnddyYHKN+LwlF6eUIaKvIg56Ewh9ICGt2zqVKYAlSH 4BgfixF01P7sCnjj5G7MrzHv4lEP8XOMFtpvh7qU3cPFfUulcRHeoMT65buwKSdmzGTh Sx7wV57JxuWSdkaJ1AfDJ0Hkx8Wmy/09bDOWVTQBqHAmGhWo550U9P2GXaWoxaPzevUP JcfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f17si5090758plg.181.2021.10.29.04.50.51; Fri, 29 Oct 2021 04:51:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhJ2LwU (ORCPT + 99 others); Fri, 29 Oct 2021 07:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbhJ2LwU (ORCPT ); Fri, 29 Oct 2021 07:52:20 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79261C061570; Fri, 29 Oct 2021 04:49:51 -0700 (PDT) Received: from [IPv6:2a02:810a:880:f54:6141:93b5:19a6:af87] (unknown [IPv6:2a02:810a:880:f54:6141:93b5:19a6:af87]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 0712C1F4578C; Fri, 29 Oct 2021 12:49:48 +0100 (BST) Subject: Re: [PATCH v8, 07/17] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Rob Herring , Ezequiel Garcia , Collabora Kernel ML References: <20211029035527.454-1-yunfei.dong@mediatek.com> <20211029035527.454-8-yunfei.dong@mediatek.com> From: Dafna Hirschfeld Message-ID: Date: Fri, 29 Oct 2021 13:49:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211029035527.454-8-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.10.21 05:55, Yunfei Dong wrote: > Decoder will use component framework to manage hardware, it is big > difference with encoder. > > Reviewed-by: Rob Herring > Signed-off-by: Yunfei Dong > --- > .../media/mediatek,vcodec-decoder.yaml | 176 +++++++++++++++++ > .../media/mediatek,vcodec-encoder.yaml | 187 ++++++++++++++++++ > .../bindings/media/mediatek-vcodec.txt | 131 ------------ > 3 files changed, 363 insertions(+), 131 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml > delete mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec.txt > > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > new file mode 100644 > index 000000000000..5de37065fbce > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > @@ -0,0 +1,176 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,vcodec-decoder.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek Video Decode Accelerator With Component > + > +maintainers: > + - Yunfei Dong > + > +description: |+ > + Mediatek Video Decode is the video decode hardware present in Mediatek > + SoCs which supports high resolution decoding functionalities. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8173-vcodec-dec > + - mediatek,mt8183-vcodec-dec > + > + reg: > + maxItems: 12 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 8 > + > + clock-names: > + items: > + - const: vcodecpll > + - const: univpll_d2 > + - const: clk_cci400_sel > + - const: vdec_sel > + - const: vdecpll > + - const: vencpll > + - const: venc_lt_sel > + - const: vdec_bus_clk_src > + > + assigned-clocks: true > + > + assigned-clock-parents: true > + > + assigned-clock-rates: true > + > + power-domains: > + maxItems: 1 > + > + iommus: > + minItems: 1 > + maxItems: 32 > + description: | > + List of the hardware port in respective IOMMU block for current Socs. > + Refer to bindings/iommu/mediatek,iommu.yaml. > + > + dma-ranges: > + maxItems: 1 > + description: | > + Describes the physical address space of IOMMU maps to memory. > + > + mediatek,larb: > + $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > + description: | > + Must contain the local arbiters in the current Socs. > + > + mediatek,vpu: > + $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > + description: > + Describes point to vpu. > + > + mediatek,scp: > + $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > + description: > + Describes point to scp. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - iommus > + - assigned-clocks > + - assigned-clock-parents > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8183-vcodec-dec > + > + then: > + required: > + - mediatek,scp > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8173-vcodec-dec > + > + then: > + required: > + - mediatek,vpu > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + > + vcodec_dec: vcodec@16000000 { > + compatible = "mediatek,mt8173-vcodec-dec"; > + reg = <0x16000000 0x100>, /*VDEC_SYS*/ > + <0x16020000 0x1000>, /*VDEC_MISC*/ > + <0x16021000 0x800>, /*VDEC_LD*/ > + <0x16021800 0x800>, /*VDEC_TOP*/ > + <0x16022000 0x1000>, /*VDEC_CM*/ > + <0x16023000 0x1000>, /*VDEC_AD*/ > + <0x16024000 0x1000>, /*VDEC_AV*/ > + <0x16025000 0x1000>, /*VDEC_PP*/ > + <0x16026800 0x800>, /*VP8_VD*/ > + <0x16027000 0x800>, /*VP6_VD*/ > + <0x16027800 0x800>, /*VP8_VL*/ > + <0x16028400 0x400>; /*VP9_VD*/ > + interrupts = ; > + mediatek,larb = <&larb1>; > + iommus = <&iommu M4U_PORT_HW_VDEC_MC_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PP_EXT>, > + <&iommu M4U_PORT_HW_VDEC_AVC_MV_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PRED_RD_EXT>, > + <&iommu M4U_PORT_HW_VDEC_PRED_WR_EXT>, > + <&iommu M4U_PORT_HW_VDEC_UFO_EXT>, > + <&iommu M4U_PORT_HW_VDEC_VLD_EXT>, > + <&iommu M4U_PORT_HW_VDEC_VLD2_EXT>; > + mediatek,vpu = <&vpu>; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>; > + clocks = <&apmixedsys CLK_APMIXED_VCODECPLL>, > + <&topckgen CLK_TOP_UNIVPLL_D2>, > + <&topckgen CLK_TOP_CCI400_SEL>, > + <&topckgen CLK_TOP_VDEC_SEL>, > + <&topckgen CLK_TOP_VCODECPLL>, > + <&apmixedsys CLK_APMIXED_VENCPLL>, > + <&topckgen CLK_TOP_VENC_LT_SEL>, > + <&topckgen CLK_TOP_VCODECPLL_370P5>; > + clock-names = "vcodecpll", > + "univpll_d2", > + "clk_cci400_sel", > + "vdec_sel", > + "vdecpll", > + "vencpll", > + "venc_lt_sel", > + "vdec_bus_clk_src"; > + assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>, > + <&topckgen CLK_TOP_CCI400_SEL>, > + <&topckgen CLK_TOP_VDEC_SEL>, > + <&apmixedsys CLK_APMIXED_VCODECPLL>, > + <&apmixedsys CLK_APMIXED_VENCPLL>; > + assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>, > + <&topckgen CLK_TOP_UNIVPLL_D2>, > + <&topckgen CLK_TOP_VCODECPLL>; > + assigned-clock-rates = <0>, <0>, <0>, <1482000000>, <800000000>; > + }; > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml > new file mode 100644 > index 000000000000..94d67d40548c > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml > @@ -0,0 +1,187 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,vcodec-encoder.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek Video Encode Accelerator With Component why is it "With Component" ? I guess it should be removed Thanks, Dafna > + > +maintainers: > + - Yunfei Dong > + > +description: |+ > + Mediatek Video Encode is the video encode hardware present in Mediatek > + SoCs which supports high resolution encoding functionalities. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8173-vcodec-enc-vp8 > + - mediatek,mt8173-vcodec-enc > + - mediatek,mt8183-vcodec-enc > + - mediatek,mt8192-vcodec-enc > + - mediatek,mt8195-vcodec-enc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 5 > + > + clock-names: > + minItems: 1 > + maxItems: 5 > + > + assigned-clocks: true > + > + assigned-clock-parents: true > + > + iommus: > + minItems: 1 > + maxItems: 32 > + description: | > + List of the hardware port in respective IOMMU block for current Socs. > + Refer to bindings/iommu/mediatek,iommu.yaml. > + > + dma-ranges: > + maxItems: 1 > + description: | > + Describes the physical address space of IOMMU maps to memory. > + > + mediatek,larb: > + $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > + description: | > + Must contain the local arbiters in the current Socs. > + > + mediatek,vpu: > + $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > + description: > + Describes point to vpu. > + > + mediatek,scp: > + $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > + description: > + Describes point to scp. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - iommus > + - assigned-clocks > + - assigned-clock-parents > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8183-vcodec-enc > + - mediatek,mt8192-vcodec-enc > + > + then: > + required: > + - mediatek,scp > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8173-vcodec-enc-vp8 > + - mediatek,mt8173-vcodec-enc > + > + then: > + required: > + - mediatek,vpu > + > + - if: > + properties: > + compatible: > + enum: > + - mediatek,mt8173-vcodec-enc > + - mediatek,mt8192-vcodec-enc > + - mediatek,mt8173-vcodec-enc > + > + then: > + properties: > + clock: > + items: > + minItems: 1 > + maxItems: 1 > + clock-names: > + items: > + - const: venc_sel > + else: # for vp8 hw decoder > + properties: > + clock: > + items: > + minItems: 1 > + maxItems: 1 > + clock-names: > + items: > + - const: venc_lt_sel > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + > + vcodec_enc_avc: vcodec@18002000 { > + compatible = "mediatek,mt8173-vcodec-enc"; > + reg = <0x18002000 0x1000>; > + interrupts = ; > + iommus = <&iommu M4U_PORT_VENC_RCPU>, > + <&iommu M4U_PORT_VENC_REC>, > + <&iommu M4U_PORT_VENC_BSDMA>, > + <&iommu M4U_PORT_VENC_SV_COMV>, > + <&iommu M4U_PORT_VENC_RD_COMV>, > + <&iommu M4U_PORT_VENC_CUR_LUMA>, > + <&iommu M4U_PORT_VENC_CUR_CHROMA>, > + <&iommu M4U_PORT_VENC_REF_LUMA>, > + <&iommu M4U_PORT_VENC_REF_CHROMA>, > + <&iommu M4U_PORT_VENC_NBM_RDMA>, > + <&iommu M4U_PORT_VENC_NBM_WDMA>; > + mediatek,larb = <&larb3>; > + mediatek,vpu = <&vpu>; > + clocks = <&topckgen CLK_TOP_VENC_SEL>; > + clock-names = "venc_sel"; > + assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>; > + }; > + > + vcodec_enc_vp8: vcodec@19002000 { > + compatible = "mediatek,mt8173-vcodec-enc-vp8"; > + reg = <0x19002000 0x1000>; /* VENC_LT_SYS */ > + interrupts = ; > + iommus = <&iommu M4U_PORT_VENC_RCPU_SET2>, > + <&iommu M4U_PORT_VENC_REC_FRM_SET2>, > + <&iommu M4U_PORT_VENC_BSDMA_SET2>, > + <&iommu M4U_PORT_VENC_SV_COMA_SET2>, > + <&iommu M4U_PORT_VENC_RD_COMA_SET2>, > + <&iommu M4U_PORT_VENC_CUR_LUMA_SET2>, > + <&iommu M4U_PORT_VENC_CUR_CHROMA_SET2>, > + <&iommu M4U_PORT_VENC_REF_LUMA_SET2>, > + <&iommu M4U_PORT_VENC_REC_CHROMA_SET2>; > + mediatek,larb = <&larb5>; > + mediatek,vpu = <&vpu>; > + clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > + clock-names = "venc_lt_sel"; > + assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>; > + }; > diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > deleted file mode 100644 > index 665a9508708e..000000000000 > --- a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > +++ /dev/null > @@ -1,131 +0,0 @@ > -Mediatek Video Codec > - > -Mediatek Video Codec is the video codec hw present in Mediatek SoCs which > -supports high resolution encoding and decoding functionalities. > - > -Required properties: > -- compatible : must be one of the following string: > - "mediatek,mt8173-vcodec-enc-vp8" for mt8173 vp8 encoder. > - "mediatek,mt8173-vcodec-enc" for mt8173 avc encoder. > - "mediatek,mt8183-vcodec-enc" for MT8183 encoder. > - "mediatek,mt8173-vcodec-dec" for MT8173 decoder. > - "mediatek,mt8192-vcodec-enc" for MT8192 encoder. > - "mediatek,mt8183-vcodec-dec" for MT8183 decoder. > - "mediatek,mt8195-vcodec-enc" for MT8195 encoder. > -- reg : Physical base address of the video codec registers and length of > - memory mapped region. > -- interrupts : interrupt number to the cpu. > -- mediatek,larb : must contain the local arbiters in the current Socs. > -- clocks : list of clock specifiers, corresponding to entries in > - the clock-names property. > -- clock-names: avc encoder must contain "venc_sel", vp8 encoder must > - contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2", > - "clk_cci400_sel", "vdec_sel", "vdecpll", "vencpll", "venc_lt_sel", > - "vdec_bus_clk_src". > -- iommus : should point to the respective IOMMU block with master port as > - argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > - for details. > -- dma-ranges : describes the dma address range space that the codec hw access. > -One of the two following nodes: > -- mediatek,vpu : the node of the video processor unit, if using VPU. > -- mediatek,scp : the node of the SCP unit, if using SCP. > - > - > -Example: > - > -vcodec_dec: vcodec@16000000 { > - compatible = "mediatek,mt8173-vcodec-dec"; > - reg = <0 0x16000000 0 0x100>, /*VDEC_SYS*/ > - <0 0x16020000 0 0x1000>, /*VDEC_MISC*/ > - <0 0x16021000 0 0x800>, /*VDEC_LD*/ > - <0 0x16021800 0 0x800>, /*VDEC_TOP*/ > - <0 0x16022000 0 0x1000>, /*VDEC_CM*/ > - <0 0x16023000 0 0x1000>, /*VDEC_AD*/ > - <0 0x16024000 0 0x1000>, /*VDEC_AV*/ > - <0 0x16025000 0 0x1000>, /*VDEC_PP*/ > - <0 0x16026800 0 0x800>, /*VP8_VD*/ > - <0 0x16027000 0 0x800>, /*VP6_VD*/ > - <0 0x16027800 0 0x800>, /*VP8_VL*/ > - <0 0x16028400 0 0x400>; /*VP9_VD*/ > - interrupts = ; > - mediatek,larb = <&larb1>; > - iommus = <&iommu M4U_PORT_HW_VDEC_MC_EXT>, > - <&iommu M4U_PORT_HW_VDEC_PP_EXT>, > - <&iommu M4U_PORT_HW_VDEC_AVC_MV_EXT>, > - <&iommu M4U_PORT_HW_VDEC_PRED_RD_EXT>, > - <&iommu M4U_PORT_HW_VDEC_PRED_WR_EXT>, > - <&iommu M4U_PORT_HW_VDEC_UFO_EXT>, > - <&iommu M4U_PORT_HW_VDEC_VLD_EXT>, > - <&iommu M4U_PORT_HW_VDEC_VLD2_EXT>; > - mediatek,vpu = <&vpu>; > - power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>; > - clocks = <&apmixedsys CLK_APMIXED_VCODECPLL>, > - <&topckgen CLK_TOP_UNIVPLL_D2>, > - <&topckgen CLK_TOP_CCI400_SEL>, > - <&topckgen CLK_TOP_VDEC_SEL>, > - <&topckgen CLK_TOP_VCODECPLL>, > - <&apmixedsys CLK_APMIXED_VENCPLL>, > - <&topckgen CLK_TOP_VENC_LT_SEL>, > - <&topckgen CLK_TOP_VCODECPLL_370P5>; > - clock-names = "vcodecpll", > - "univpll_d2", > - "clk_cci400_sel", > - "vdec_sel", > - "vdecpll", > - "vencpll", > - "venc_lt_sel", > - "vdec_bus_clk_src"; > - assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>, > - <&topckgen CLK_TOP_CCI400_SEL>, > - <&topckgen CLK_TOP_VDEC_SEL>, > - <&apmixedsys CLK_APMIXED_VCODECPLL>, > - <&apmixedsys CLK_APMIXED_VENCPLL>; > - assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>, > - <&topckgen CLK_TOP_UNIVPLL_D2>, > - <&topckgen CLK_TOP_VCODECPLL>; > - assigned-clock-rates = <0>, <0>, <0>, <1482000000>, <800000000>; > - }; > - > -vcodec_enc_avc: vcodec@18002000 { > - compatible = "mediatek,mt8173-vcodec-enc"; > - reg = <0 0x18002000 0 0x1000>; > - interrupts = ; > - iommus = <&iommu M4U_PORT_VENC_RCPU>, > - <&iommu M4U_PORT_VENC_REC>, > - <&iommu M4U_PORT_VENC_BSDMA>, > - <&iommu M4U_PORT_VENC_SV_COMV>, > - <&iommu M4U_PORT_VENC_RD_COMV>, > - <&iommu M4U_PORT_VENC_CUR_LUMA>, > - <&iommu M4U_PORT_VENC_CUR_CHROMA>, > - <&iommu M4U_PORT_VENC_REF_LUMA>, > - <&iommu M4U_PORT_VENC_REF_CHROMA>, > - <&iommu M4U_PORT_VENC_NBM_RDMA>, > - <&iommu M4U_PORT_VENC_NBM_WDMA>; > - mediatek,larb = <&larb3>; > - mediatek,vpu = <&vpu>; > - clocks = <&topckgen CLK_TOP_VENC_SEL>; > - clock-names = "venc_sel"; > - assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>; > - assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>; > - }; > - > -vcodec_enc_vp8: vcodec@19002000 { > - compatible = "mediatek,mt8173-vcodec-enc-vp8"; > - reg = <0 0x19002000 0 0x1000>; /* VENC_LT_SYS */ > - interrupts = ; > - iommus = <&iommu M4U_PORT_VENC_RCPU_SET2>, > - <&iommu M4U_PORT_VENC_REC_FRM_SET2>, > - <&iommu M4U_PORT_VENC_BSDMA_SET2>, > - <&iommu M4U_PORT_VENC_SV_COMA_SET2>, > - <&iommu M4U_PORT_VENC_RD_COMA_SET2>, > - <&iommu M4U_PORT_VENC_CUR_LUMA_SET2>, > - <&iommu M4U_PORT_VENC_CUR_CHROMA_SET2>, > - <&iommu M4U_PORT_VENC_REF_LUMA_SET2>, > - <&iommu M4U_PORT_VENC_REC_CHROMA_SET2>; > - mediatek,larb = <&larb5>; > - mediatek,vpu = <&vpu>; > - clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > - clock-names = "venc_lt_sel"; > - assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > - assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>; > - }; >