Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp63362pxb; Fri, 29 Oct 2021 05:56:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkouIIe39GfXWuJFHa7CAI2HCRD+EYXiuUWNyIpmpObHzJBJKfsjocAw+moVlN4ok5lE6h X-Received: by 2002:a17:906:478e:: with SMTP id cw14mr13435792ejc.19.1635512213392; Fri, 29 Oct 2021 05:56:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635512213; cv=none; d=google.com; s=arc-20160816; b=Qc/8cYwNDfly2izwgZ8SBJdCYk/kXWiD8Bm0XwtyUVngOHqJ3p6J87a3jYFjolB9GV V8iE0/oJWPkx2trB+bJ9BgZNgdSgTbVDG7IbB5+HXZDZ5mhqgPn1Slj59eX9jHW0gEMj vYj6WVKK4StZUdptXXaCMZIjKrq9My9cH/EmnD5wpuZAD4aFg0AR11kpLVH35n1dP0e7 rC7o0zvFGHtMxguxqD/EfmmECDC+XGbeeCE5QoXUT/+dJ/KnKG/WBX+xWKJjfahPDAV0 hx47Cqrk+9pUYm28JJMRCg+5/97LQDctGqGxgLcKXSp5mD2sIOEAAN6Dy67SZUb8HUHm M+Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=LUYF+vFrMrvXEYexLl3qxY2ER/gYtePdoU9fEtmoAVw=; b=Nr6xLI8EsE5LAXO+jGMv0CGMeWOlRKwSOn+i5FUCU6ZBUhhPalfiR9tWv13E9MMcxq LPLit9Lgu9xPWxUp0JN9oKu6AObauKrYcnlZX+z862ppQRmN4xcs+Tf/hdT4Wks3v235 VdqWn66NPTUwmuCcPP3k5+IgvzLmz5H83BgcqWaRxPt1GqjuyamGVsvRjcaTb8W5HZOa dTHFzj8wLp5LfyslpYl3pHNwBgKFEFbYtbnVqaN1kLL1UbP/pRkQ8izo3Jiw3EPn9RNq 1G8Jv+CCbZiAEwLVjaBOEUYQ7HnkmOeK5zySD+FRmCwvcKPwmIwckoxkiRY8WLrogDik nHrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=CVQFg0LJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si7172499edr.418.2021.10.29.05.56.29; Fri, 29 Oct 2021 05:56:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=CVQFg0LJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231411AbhJ2M41 (ORCPT + 99 others); Fri, 29 Oct 2021 08:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230492AbhJ2M4Z (ORCPT ); Fri, 29 Oct 2021 08:56:25 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F291C061714 for ; Fri, 29 Oct 2021 05:53:57 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id s3so10593141ild.0 for ; Fri, 29 Oct 2021 05:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=LUYF+vFrMrvXEYexLl3qxY2ER/gYtePdoU9fEtmoAVw=; b=CVQFg0LJl9KFh+D3bOEMs0y5jpTdyDAnDYUN22GdKR28hhfGHMA8puyLuEdfJq6YiS /aZUHBCEUdGJRQ7p9+XFiS9aktBmxvfY//EJH+QMO1uHtzPVvGHinpNzJBkCiy4yf7Hw MHE3dz3gQNuMMUQBeKviLRNur3gHv/GGZKE5w/fODm0tdoYNZJ9H0Q3A2InbXh4umv4h IHKAaNAvKiBWXC8ByR7a8x6epU8ItR0h/wdKPCGpBmq1iEU/1hQ7vp7iFDVqelmXBc6Z 9u+ix7ew5qCmAEiGugK1zoCPRnnmwkqWR4B0q2gpvCvZS8qjSBl0iDzyfKiSUJWktP82 Dv8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=LUYF+vFrMrvXEYexLl3qxY2ER/gYtePdoU9fEtmoAVw=; b=fDygn5P8on2EtRKdh+S9PJq7gjzHYB5XxB05PAVzcJGkDtsuGt27xoHsGJWfJeak9k IN6lFR2xiOefXtN4yMlWXGLn/hiQ7pfLRZXGu/ag7Yxh3+5vZajThF451LnzdRXEyeFO nK8olJ9Dy4vWdMOYXaakqnh6Rbt4mFS9ESUNbGlNu+AlDV5bw5Knu/iVvf8xOrr/tmVh HbhKm4G6wsmVnLIRzlpPZqppSRGmTrbJLj4cj50UFISC3kKJf544QizZKXwH3jhboEc3 tWdMhra/ytaLoNSNA8wAuKz6shSpxee4Xu2A1nZfwyMyLMk8fKKjCjj0le1Q1F9rPz8l nDqQ== X-Gm-Message-State: AOAM532Nz6LwLSKB3pNWOIpOSulzRyhPkQNgriOPutxR5NWj034oSP3L y2wqvWZYR0AMlPcU/jdyEudm0Z2TsVUezw== X-Received: by 2002:a05:6e02:1543:: with SMTP id j3mr7490944ilu.151.1635512036584; Fri, 29 Oct 2021 05:53:56 -0700 (PDT) Received: from [127.0.1.1] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id g11sm3419433ioo.3.2021.10.29.05.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 05:53:55 -0700 (PDT) From: Jens Axboe To: John Garry Cc: linux-kernel@vger.kernel.org, ming.lei@redhat.com, linux-block@vger.kernel.org In-Reply-To: <1635496823-33515-1-git-send-email-john.garry@huawei.com> References: <1635496823-33515-1-git-send-email-john.garry@huawei.com> Subject: Re: [PATCH] blk-mq-debugfs: Show active requests per queue for shared tags Message-Id: <163551203480.85142.14090478685501297058.b4-ty@kernel.dk> Date: Fri, 29 Oct 2021 06:53:54 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Oct 2021 16:40:23 +0800, John Garry wrote: > Currently we show the hctx.active value for the per-hctx "active" file. > > However this is not maintained for shared tags, and we instead keep a > record of the number active requests per request queue - see commit > f1b49fdc1c64 ("blk-mq: Record active_queues_shared_sbitmap per tag_set for > when using shared sbitmap). > > [...] Applied, thanks! [1/1] blk-mq-debugfs: Show active requests per queue for shared tags commit: 9b84c629c90374498ab5825dede74a06ea1c775b Best regards, -- Jens Axboe