Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp160544pxb; Fri, 29 Oct 2021 07:35:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjJyn3hZBVZCSZRY7OVV5DvHiSOT4WRMtWC6cf5WjYHqdheXF2In1DPe1Tqrzxdt3KtizB X-Received: by 2002:a5d:9b0f:: with SMTP id y15mr8432534ion.5.1635518140343; Fri, 29 Oct 2021 07:35:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635518140; cv=none; d=google.com; s=arc-20160816; b=XCpOnfuhn06BUMWM14Medny/6dWCW7/Et30hJAXNqKWBa+k06gSvau5QeLDv8fjaXJ GPdqACHLiOXqWgnAfgHonDjBcO3JLvzZhXzq3RNgdn4tIAr96PhonFFuT8mAJQ7Z1Whb Nt/H4oBUWt57QD2f9dm+PHX50AAyaeJzvJiqdeob/fWkAxcN0DMDEh3ZVk8hdIZLnqGZ 1xoYIg1qpnTcWumWjK1lYkEm9og4CwU6nUB6vOOpobtkh27JOg4n0zdaKbIb9vgjPDf6 e/1AZpoBeymY1sXSnxzmar5JBMqosy27fJKh/MwZz2wfc9hEA6Z8tUyCYxHfq9PhfoRF AKsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XiM+B9qyPSJmz+1nGIcnoNS9xSSaJAUzee605rT86OM=; b=WLiEHPXeNaeuORWaz+ZvrQ7OoUFqHyNNez96p80/hfnnVLMZVjDURa4dGcqj2saUD8 KON8oHCQZY2Bx5sCAfHLylIkGVkTLjfTju5LSJG82q9XmGlRfm4aQvV2S421qHGGSlUG YNh+/IjfOsaz+5Tq6bh/loSnch0/5uSyvSDlA2Rk4aStuKTuoLvWavYTrYlfASrlqrFC skppBLF/OwV00TLKJ3j2MT8u1msb0WXIJMk+UpwCOoAy3I5u2Z9A+xykUDDvI7hutbGn 9kZD1dlE0D+gGpq3cUzmvBMT18pcCgBEN6tqGs64f1fH7GwEIfJbAQcj0A9d/cqIgi4t QBAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=X34VJuP8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k12si9521297ilu.89.2021.10.29.07.35.28; Fri, 29 Oct 2021 07:35:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=X34VJuP8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbhJ2Ogp (ORCPT + 99 others); Fri, 29 Oct 2021 10:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhJ2Ogo (ORCPT ); Fri, 29 Oct 2021 10:36:44 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F51AC061714 for ; Fri, 29 Oct 2021 07:34:15 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id s1so7848291qta.13 for ; Fri, 29 Oct 2021 07:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XiM+B9qyPSJmz+1nGIcnoNS9xSSaJAUzee605rT86OM=; b=X34VJuP893dPnyKj7tKDZS5M8bu1vj5GUEbKqC0ehlOgup3it/mOc80zNH2MD7O5sv L6Sok1uA+G0ndCy/c83EQ25tJbqOJtJ+sWgYAEywCf+ODAJyahVsmS1V9Ya1uXi6P4dC 9ROX96pWoQaIrPqYl17HUBgUBvM5U/qqKvGfg1uly5yQsv70bZo4C2jIj4glbnGDmot4 XOyoyqzgMiMF+keg6zrOiKfwYEMBxCG4F8wVzYK93GabPXiPZC8vp3jOzx1lhuqgzlGz fh+Z0QQ0bvFp5KF/7DTgS5aG0LV3rQOI6ktMEFTXGWZr7W5Yff2fvK/rCTo9VS+bjGL3 gMYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XiM+B9qyPSJmz+1nGIcnoNS9xSSaJAUzee605rT86OM=; b=u2D+KidWZLE35yXZpmCLdW3eBM8FKPRGvQJK/AlSVN8KW0t3R0dIOTuunHTI1/qzbe eZAJNmRFQKmWY+y9J34r+8zyNyWh7yhmYyGj17Th1E5qoYOhXIAIrSi9kzb6ca8GOx+Q 289MIDJ0VsUTYEGUEz7jfXmzQopFHANN+CDIvWWB1mGWOAX/UKRWcVGD6tu7DaYfekKm D11udF8KWkX/3I12dESWJnVnV2DF9thHDcmQa5ihjdiopBAQqy1zelKhWWqDUxSGuypx mrd5a2tvN9XuqeQXIDsa4Bxk70rYzv/r+ZscQJslEWcsfWOKb9y/mNYUkVEkZP97T2Ge osKQ== X-Gm-Message-State: AOAM532dAEZXhqm0mFf1+o/HhSzSX03Tnl+mH9mYaJpAOzx03F9VcsLI 1upAPLW5UCRgDc/KiRH6uVyaoM6DdZ55OA== X-Received: by 2002:a05:622a:28e:: with SMTP id z14mr12014795qtw.24.1635518054536; Fri, 29 Oct 2021 07:34:14 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id a15sm3925121qkp.17.2021.10.29.07.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 07:34:14 -0700 (PDT) Date: Fri, 29 Oct 2021 10:34:12 -0400 From: Josef Bacik To: Ye Bin Cc: axboe@kernel.dk, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v3 1/2] nbd: Fix incorrect error handle when first_minor big than '0xff' in nbd_dev_add Message-ID: References: <20211029094228.1853434-1-yebin10@huawei.com> <20211029094228.1853434-2-yebin10@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211029094228.1853434-2-yebin10@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 29, 2021 at 05:42:27PM +0800, Ye Bin wrote: > If first_minor big than '0xff' goto out_free_idr label, this will miss > cleanup disk. > > Fixes: b1a811633f73 ("block: nbd: add sanity check for first_minor") > Signed-off-by: Ye Bin Reviewed-by: Josef Bacik Thanks, Josef