Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ASoC: tegra: Add master volume/mute control support
From:   Sameer Pujar <spujar@nvidia.com>
To:     Jaroslav Kysela <perex@perex.cz>, broonie@kernel.org,
        lgirdwood@gmail.com, tiwai@suse.com
Cc:     jonathanh@nvidia.com, thierry.reding@gmail.com,
        alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1635159976-17355-1-git-send-email-spujar@nvidia.com>
 <79541c76-2c2b-fd4b-60c8-67ee6b8ea3fa@perex.cz>
 <8cb777f9-b73b-136c-f560-de4c31af931e@nvidia.com>
Message-ID: <18b61046-ac0b-0fb3-669c-6524a03eecf0@nvidia.com>
Date:   Fri, 29 Oct 2021 20:38:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <8cb777f9-b73b-136c-f560-de4c31af931e@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0NmS2NTdEdMSGFjRUZ5cDNHUlFBa1luZ3UxTzJMUnFnL2hBRzFjeW92aTBR?=
 =?utf-8?B?eWN4Y3Z5TUpESkFVM0RMZGpJS3lxNFhpdHF6ZE1sZWRDc1B0QTFYT3QvREV5?=
 =?utf-8?B?NHhPR1NZV0JHNjZaZTJSeTdIT1pUNmdsZEFUaU51cTQ4VU9VQVRyUmdONDhy?=
 =?utf-8?B?RmRyZCsxY3JIeWE1V1RVbERGaTJoRHdmUzdDaVBYcHJtUWVmWGZ0enZuVER4?=
 =?utf-8?B?amg1R1Z6SXZHRnBKME1FMW1lbFpTZXJTdHAvZ3k2M1F6MnRnV2NJWjZ2Qzda?=
 =?utf-8?B?MFNxVEVPajYvOW9pQktsVjFPVVlFWHJnNzFmM3EyS21BMU1aaVBISFFCOTF2?=
 =?utf-8?B?c2FuM0t0MWovcjlYdk9ob3hmbTFNWGtjaXg5Wmp4aWFGSFp6UU9pOVZLT3Js?=
 =?utf-8?B?a245UkxlaHJiSnlpQUJsY3g4bGFiSk5wY29XSU5JK1phaDZwTXl5cS92VmJ6?=
 =?utf-8?B?OWczMDN1SlgwOEpKMDdYWUo3NER4Y3RFZ3JoU2dIcmYxb1VaTEQ0ZlFyZndw?=
 =?utf-8?B?M0RFZ3dRb1RqbkdHWXdtNVJzYkM2cFY4Zmh2bEJZdWlhY1JFWlYvNW01ampR?=
 =?utf-8?B?bUFCOHBNVDZiditQa0dJYWRpUkN3YXhBRk42Y2Z2RHN5ZElhdXgwSDhnenhT?=
 =?utf-8?B?KzJRRGRVcTVib1NSL3YrKzNGYmFtOE54U0xqa3RLQUlXbmhoVC9wQUpEZUQz?=
 =?utf-8?B?dnBFU3RwakNPTGp3bGdRLytEa2MzRnpPUWtQV2xDZW8xcmdEcDJVV0EyMWpH?=
 =?utf-8?B?eStMRVkyT1RjRHZ4eXZwTkdrSmdNTDBaMUsweUR3eWNRSXNqbXhaaWVtSzFP?=
 =?utf-8?B?dWtOcC9kbFJIZkpWTHRZYnJ2WkJrb0JYb1hDRVhwT1Y3SmdUbHlrT21iRXFF?=
 =?utf-8?B?SnBSZHZCajdrSDlTVzY1eWJDaUM0aUtUR2lOdjVoWFVBWlQzRk9OZm1uVjAz?=
 =?utf-8?B?dEdlSVpjUXhZNXQ2dGJiL1VldDI3MWZYTmxhNlBUV1ZFWU5SRVhyeHZiNXFp?=
 =?utf-8?B?ejhnVnMvY3YrWHd2a1VnSW5YT2FzZDdhbm45NStaU2dldERGcDI0R1JBQ0hK?=
 =?utf-8?B?ZWgraTRVYXZtMTFYQll2T09tL0t0T2xWMVMzdkxKanpPNWJlQkVLQjJldElj?=
 =?utf-8?B?NjlJVFZuc1A1bUZuOGJjaVlpZUFDTFVLallUTHRZeWxUemtBOUhvRFRXZ0Vz?=
 =?utf-8?B?NU1kN1hDdi9yQkV0a2hNNUlrQ1pWbkNNTG5HVDliOG9jYlpJSWhwSTFJMlZ2?=
 =?utf-8?B?dTNRdll6Sy9PR2NxTjdqZUsrY0xPMTBBbE40L0JPZWc4eDhEQlRSblcyMDFU?=
 =?utf-8?B?WTROTEY3MU5RT0taVXFQYUpkZjgva1d2WEFDY3lCSXE4L0tGcDZ6TjJOL1Zk?=
 =?utf-8?B?SUVkcG9LZk1ONVJ3d0lnQi8zcGVZczhSa2wxWTkwRnNWWlJkbHh5VnFUTVIw?=
 =?utf-8?B?TjBkbnVQSUV0TU5GdkpjbTNFRnVGMFlYcnNGUmttbEdKU2V1TjBqT0ZCc1BH?=
 =?utf-8?B?Y3c0WmxybGdVVlVxWU9rUG1adUVEVERUYWR4NVBaYm1VcTRaZWovTlREY0da?=
 =?utf-8?B?SHBEWFlUTFk4NFZURXkwaG5rWVovMUszVEhlMXp3M09kV0xJM28yNndHT2J6?=
 =?utf-8?B?ZURaUHpkRmQra2ptTEV1T3lFR3AxeFl2cDM1Rkt3bGg3MVpMQlJxTzczbElI?=
 =?utf-8?B?RXVNVHNOdllzMGpPaHJINER6NHpsRGsvSWVBMTdnc29sKzF6blY1SGExQ08r?=
 =?utf-8?B?dDRnT0lGVE5OelJIMUhtMjU3RXBZLzFTRVBwV3VNTnEwdGtDQjY4RjYrY3VT?=
 =?utf-8?B?WEw1a2dTTGd1NiszMHhVNHFPM3BldFlJS250REVyOUlGaHFPQk54ZlBTUnRE?=
 =?utf-8?B?dmppR2RVMVd6MkZlM2FMVjNPeE00T0QwQ1VGR3d4TDc5cDZpczJpaTVIdlli?=
 =?utf-8?B?NkRydUJYWENHYnU2YzlDdDhSZGR0dkRQZnhzNTlzZFovbHV5c0QrdUNGSlZh?=
 =?utf-8?B?eExLWGltWUJwYnRvTXQxV25JTzdobkxYL3dXam5hVGZYa1ViUEdFRmg1YUJw?=
 =?utf-8?B?TzVYdkl4SE53NzVsWXo2U2FWOWw5RjlvSmpsbFU5c3V1aXhteStmLzBUNi83?=
 =?utf-8?B?ME1JT0N3aTdTYlROTTBXSVBFU0RqZzlNYXhRWUluUE83RGJkUXJ6b2VMNEhK?=
 =?utf-8?Q?AP+RSYLTMPO0bGZemgXMdwU=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb12dd0-bcae-4bc7-2d45-08d99aee0e4d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5317.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 15:09:08.4957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7Zy9kkwHH3CUN+DMra9o6ydgT9U59A8Oyd2ZCksY/lMCcnmgp3nGewdj6rIa4NeicsIm+I28slZunOTcotWL0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5380
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/26/2021 11:53 AM, Sameer Pujar wrote:
>
>
> On 10/25/2021 6:28 PM, Jaroslav Kysela wrote:
>> On 25. 10. 21 13:06, Sameer Pujar wrote:
>>
>>> @@ -150,11 +186,22 @@ static int tegra210_mvc_put_mute(struct 
>>> snd_kcontrol *kcontrol,
>>
>> ...
>>>
>>>       return 1;
>>
>> It's a bit unrelated comment to this change, but it may be worth to 
>> verify all
>> kcontrol put callbacks in the tegra code. Ensure that value 1 is 
>> returned only
>> when something was really changed in hardware.

There are cases when the mixer control update is not immediately written 
to HW, instead the update is ACKed (stored in variable) and writen to HW 
at a later point of time. Do these cases qualify for "return 1" as well?

>>
>> The tegra210_i2s_put_control() has opposite problem for example - 
>> returns
>> always 0 which means that the change notifications are not send to 
>> subscribed
>> applications.
>>
>
> Thanks Jaroslav for review. I will keep a note to review put() calls 
> in Tegra drivers and send fixes accordingly.