Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 Oct 2021 13:21:29 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Dan Schatzberg <schatzberg.dan@gmail.com>
Cc:     Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Boris Burkov <boris@bur.io>,
        "open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrey Ryabinin <arbn@yandex-team.com>
Subject: Re: [PATCH] cgroup: Fix rootcg cpu.stat guest double counting
Message-ID: <20211029172129.smeyk5adocjrwtlb@oracle.com>
References: <20211028221528.2174284-1-schatzberg.dan@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211028221528.2174284-1-schatzberg.dan@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z7hD7L4Rr2orsX1LjzNWg0mBWyvuKBfPGjarfZU/HcRhByvQcEDg8YF7tgP3?=
 =?us-ascii?Q?kOrkXJz4x0vdLV2vb9DPOepfsqSayq2MU9qdmm8ZtlNbztT8QJR+eJGeweBk?=
 =?us-ascii?Q?EeReBQKEAuisM7DmcD6WEjjRuc9nfJpUT3co1OcxQ8MyOCojH3qQy7x2sBfq?=
 =?us-ascii?Q?c+FT/Y+KJiqzlWScVisGgGYYM5vSuQbC2uXBR4MZ/ZTAh8xAx09mZVRfWbgn?=
 =?us-ascii?Q?Pyr+ep7Y1zR3YB2A12TdOONmXGcEMiCjn77cP5kxe45qFBh30ltelfTJ0vpp?=
 =?us-ascii?Q?KLvl/JjQSNYCeJV7tmOEIaJNdnDIYzkLPpReEZB5QZQKQNg/Q+mw/2xHOoWX?=
 =?us-ascii?Q?YztFlp8bJ38xVHTqZa5hddcfamVKdUTdV8d4S8jLtbXAT9Jf7WtykW9Gx/nV?=
 =?us-ascii?Q?W71Uc3wy6DDl3HOsv++/sJCTO2a19TWcYRExwHBANytGu/9Zgo/uGRWQTdkh?=
 =?us-ascii?Q?9VjSTCZcEIPOSwg0mRfgVURsiYn8YzhNN4AgcnJAwiSxe0TqJiJDuY6uc1gp?=
 =?us-ascii?Q?JpzL7XF//OhXAjO5I7w88Al8bhzmqRJrT6bkhUL682j0R9Dd+Qd49eZa6wrS?=
 =?us-ascii?Q?Cg6D9R+Ce9nq3d9kHmr/LMUBQ1G1JnK5shkL4fX07VFA1EIVy287kL5kYOyC?=
 =?us-ascii?Q?k2rUXonrRnAVaLX7a6An5kruNls+d8rSMMtGYCXfoimTWghYLWOldDUU5CkH?=
 =?us-ascii?Q?QOBdLlJGKOs/gaSpo7sUMP/pCaO8uOYTJ5ax0PkoCZjq0D4yYoEcqYoBAOUk?=
 =?us-ascii?Q?CE/LRwDh7n6OKcTXpik7VLrBRyM2JVxj5z8pX3bca9ooUS4Bzu9nejfM46Ze?=
 =?us-ascii?Q?J+OKYr25mY7XBZHzzn9JptNqFKx+RV/bPrcgKPf7hk7ba/ULD5idbTO3DCDx?=
 =?us-ascii?Q?iow/NPax57egDxmRlhbjqLN6dgqLpgO/geJVbcbqRC/BJi+kHOc0tEmFxtAg?=
 =?us-ascii?Q?FXf3LAujH5/8v7Hs1ROZVhxlbuznRIuTlAZ+QJAwOlwUVOpKDGo754UAXx9S?=
 =?us-ascii?Q?rgxzwAddkzwvEjgb9LYgbyvuu9KnGmgWY91Opx1HUbTwygXXKv3OIDFK6Gmh?=
 =?us-ascii?Q?HiOLGFqgYQ37SJMGnnqrRRwCyhE+1+e+B/oE3goVaQ+KeA7C2gwrJqPZjLfE?=
 =?us-ascii?Q?2uku6Rbi03qHG0LsDEkJudSuXMji3EIBycuuwoW4s8zELhh7o52WMGwlCbuq?=
 =?us-ascii?Q?QuExI/PV9Oejg5QTOKnoop9WkWyce3X/jH2ozZCJ99VwiaaRVLKQINGXfL2Y?=
 =?us-ascii?Q?nwTkjGbElm2dQaN6QnbO4d+9yl43kMXfluwXSrBts5e5w3vw8MofUfkGZWGU?=
 =?us-ascii?Q?1tTwpSp7cUwSic/EZoyyRZJZBxJKp+XgT9GAQbh8IjgzOQeFmSKh4gTOQoVl?=
 =?us-ascii?Q?lfMbI1PDq/nxE0v9XgjdwvhZS5ImXyUx8w5r4YGuIbxisqM+6sGzcAhYcMFw?=
 =?us-ascii?Q?yayi3Ae/5Jvhk1r0RaHyZycMxlWW3E6XCQyNsbeQvPRz9U+T9fRUCFugOWzM?=
 =?us-ascii?Q?BfO+a+3sQk8y1iZgBYcqQXxukPrReucyS48hqt73AATeYnVJjmLDSZmetQ6e?=
 =?us-ascii?Q?yGJhcWZv4YHTn/O4BaNxHO5fxImqy6sKo6NsGhY86FEzP90yOeUb+RTVIqLv?=
 =?us-ascii?Q?S41o9UbxOj2EiIVbTCdAZm3tEKlprtx8edEaMvxJ1GqbWwz83+UmJZyCInXF?=
 =?us-ascii?Q?VJxpcQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca252eff-f404-4cf0-e17e-08d99b008eda
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2966.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 17:21:35.4207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kn2unLY9g+jABdX67Vfpcc/lUjVjzlOUUPl4feYplgrIvJ6X88D8+mWe2F+KcNw8mKpGAtkyDIKzWjK6Xx//rSibZO+9ZFHESAAmejE5uzI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3029
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10152 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=720 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110290096
X-Proofpoint-ORIG-GUID: AOl0Z25NyWf4epKcOct-yLhScpuU0S46
X-Proofpoint-GUID: AOl0Z25NyWf4epKcOct-yLhScpuU0S46
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 28, 2021 at 03:15:27PM -0700, Dan Schatzberg wrote:
> In account_guest_time in kernel/sched/cputime.c guest time is
> attributed to both CPUTIME_NICE and CPUTIME_USER in addition to
> CPUTIME_GUEST_NICE and CPUTIME_GUEST respectively. Therefore, adding
> both to calculate usage results in double counting any guest time at
> the rootcg.

Yes, definitely a bug.  The same fix was posted a couple months ago as
part of a series but never picked up:

  https://x-lore.kernel.org/all/20210820094005.20596-3-arbn@yandex-team.com/

The series also touched cputime, so we might be waiting for scheduler
folks?   +Ingo +Peter +Andrey