Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
In-Reply-To: <000201d7ccb2$300dba50$90292ef0$@codeaurora.org>
References: <1635408817-14426-1-git-send-email-pillair@codeaurora.org>
 <1635408817-14426-3-git-send-email-pillair@codeaurora.org>
 <CAE-0n50z=h-avn+K-weZnZFVN7nsR=fLAtge7jFZ0JLx2JvP2w@mail.gmail.com> <000201d7ccb2$300dba50$90292ef0$@codeaurora.org>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.9.1
Date:   Fri, 29 Oct 2021 14:04:04 -0500
Message-ID: <CAE-0n5155J4vvvFES9V5=v+nX3BhZsBgZxkB=uLQOPij=-sf-Q@mail.gmail.com>
Subject: RE: [PATCH v7 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
To:     agross@kernel.org, bjorn.andersson@linaro.org,
        mathieu.poirier@linaro.org, ohad@wizery.com,
        p.zabel@pengutronix.de, pillair@codeaurora.org, robh+dt@kernel.org
Cc:     linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        sibis@codeaurora.org, mpubbise@codeaurora.org, kuabhs@chromium.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting pillair@codeaurora.org (2021-10-29 03:46:03)
>
> > > +
> > > +        glink-edge {
> > > +            interrupts-extended = <&ipcc IPCC_CLIENT_WPSS
> > > +                                         IPCC_MPROC_SIGNAL_GLINK_QMP
> > > +                                         IRQ_TYPE_EDGE_RISING>;
> > > +            mboxes = <&ipcc IPCC_CLIENT_WPSS
> > > +                            IPCC_MPROC_SIGNAL_GLINK_QMP>;
> > > +
> > > +            label = "wpss";
> > > +            qcom,remote-pid = <13>;
> >
> > There are a few properties here that don't seem to be required. Is that
> > intentional?
>
> Hi Stephen,
> All the properties in the example are listed as required (except for status, which will be removed in the subsequent patchset).
> Do you mean the glink-edge node properties ?

Yes I mean all the properties in the glink-edge node. Are they required?
If so then we need to list them in the schema.