Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <78a1bdf6-a5f0-0305-5e43-c1f9290d9b79@intel.com>
Date:   Fri, 29 Oct 2021 12:03:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.2.1
Subject: Re: [PATCH V2 03/15] x86/sgx: Add an attribute for the amount of SGX
 memory in a NUMA node
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, <jarkko@kernel.org>,
        <linux-sgx@vger.kernel.org>, <shuah@kernel.org>,
        <dave.hansen@linux.intel.com>
CC:     <seanjc@google.com>, <linux-kselftest@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <cover.1635447301.git.reinette.chatre@intel.com>
 <6df03c54cc8b533de4389b663ec9e4803ced1beb.1635447301.git.reinette.chatre@intel.com>
 <eb41bbbe-8563-7b6d-3883-61ab43b0b10f@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <eb41bbbe-8563-7b6d-3883-61ab43b0b10f@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3FRa1ArNHFZWkZ6SCsxZ3dncC85a3BaaGJIUTJWdVFEOHFoNHFCN0g3SzZ2?=
 =?utf-8?B?WUdnQk5KSnBzNjI1emc2b3FUYU1JazJUY1FNK3pKMFN6bFhFSVc3U0JWYmRF?=
 =?utf-8?B?N045bFFIRXlrbDREMWsvYlpDSGNOVHllb2c3MklLUlBHak5vZG5IbUNuMUNq?=
 =?utf-8?B?T2FVQnFpNG92OFBuK0pzcE5JZGhKMTdxQklRQ0RlVVZaNHFsd3NteUxGT2Vl?=
 =?utf-8?B?djFaRnRmcWlrY2dpNXJ6Q2l3MlUyYlBqWDBoUkdaVVUySlZ0Sk5ZbmV2NERk?=
 =?utf-8?B?YlJhRmhzUlA0ZDJ0djBXQXFLWlp4a0ZHcWxGekc3TldDMmcrc0pmV09lMThW?=
 =?utf-8?B?U0NlcmN5UFFrRVZXUTBBZGJDWUxFWnpzUVUvZ1RzNndYSFgxVk9OYUR3azAz?=
 =?utf-8?B?U2IrNXNnYVBPaWYzdk55TU8yNGVXc1loTS9IYnZwRkZpSFQrZnJBRFQvT29V?=
 =?utf-8?B?Z1A4YTZ2NzR4TVB0aUlBTEFuTHZnT0UxQStDQ0hkNW9nTnBUenY0bGVGdDRF?=
 =?utf-8?B?UEwzdWNQcEdYWXVBM3QydWxmenpZT3ViRGhXT1hJc2F4ZC9HUHlQN1BkZmIy?=
 =?utf-8?B?OUtST25Ud2VVYXhNckZFeTQybUtmQ09xWng4ZStxS0plbW9pcHBEOEphTk1p?=
 =?utf-8?B?NTVobnN2WEFJVmRwcEE2OTRkeldYQy84anFtS3J5VmwrTlU3RzJqdmxWbFRK?=
 =?utf-8?B?cTlpSk82UjhkM1lXRUZtNjZjR0lzdENkZExqR1oxeWhsOVVSZUdvclhZSlZr?=
 =?utf-8?B?KzJTb211VkdQbXM5OHk0VFlNVE1JeUhHdzRRRUp2V0oxYlRESTgvMGJiTkh3?=
 =?utf-8?B?VE03ZVlTNitLdUZGc0NrZUJCZHpQc2JmQ3FVblR0R2ppVEp4bGRSY2JrUHB0?=
 =?utf-8?B?VFhhc3JMdWEvNzd4L0c0OWpPVlQrOU1la3JnUm8xMnJxMDI3amhaWS9haWZ4?=
 =?utf-8?B?a0Q1ZHJRbkh5ZUtqR0ZGQ2MvTk04UHBqeXJESW9jeDgxZGJ1b1lhMnFRWGJ2?=
 =?utf-8?B?NTlmWGduNUNKVmpaWlV5Y21TSW1SSCtKd2ZsOUFDMmUrVGZRMkZCV0ZhZ2dV?=
 =?utf-8?B?U1lmQ1ltM1F6NGNtcWdCbS9hSWJRZ0k3OHMyL0JXQWxvU2tTQXJFL0VJZ1JH?=
 =?utf-8?B?MldVeE9JaERMNDZqc3RkcTdkTGl1MlhZV08zTEdqK0pKM1pWS3hWM1RMcTRP?=
 =?utf-8?B?bnVNVTRuUFJQNWpxdXpLTUcrTWtJSXJnbVpIaEhFVHNML1hWa3V3RmZLU1dq?=
 =?utf-8?B?MmJDMnZlcEVtWkdoL1dNTVlRaXE1SFkraC9uZ0FqcWRmNGZNV3ZZbmJpN2Rq?=
 =?utf-8?B?blo3cnkwME9aNEdJTmdsdVlmdEhPTThpenBxeStyNTk5NzNucjVpeDdXUVRx?=
 =?utf-8?B?a1FWWGhmc0xOdFFxNmhGTnVEZ2RZeG5pYW9uVkI1emNyTk1NdVVRTmcrNXNS?=
 =?utf-8?B?N2xlVFJXczcyNlB6L3pYN3NZbXBjL0pHYmxPYTdscDFvWGxqeE9GczByZldK?=
 =?utf-8?B?UnNBemNNb3V1VkhNVnpvbmJrYjR1V1dkd00yOVBtSFIyOG9MbWNPek1kdFNK?=
 =?utf-8?B?VW4zVjYyU0l6L0txSnlaUUhaQ3IxTlVzV05aTHFvNkdFYit6QnR0MmJGdTEv?=
 =?utf-8?B?K3VWNSt5bk15S3VoZVpmTzJDT2luYXpRSHZWYkFMT2p1ZysraWJGbUJNWkFs?=
 =?utf-8?B?RkR0ZWNhanQ2MlkrcDNnam42aTRpdDQ5LzdQa2FqdTFQN25LbEVleGRCYzdv?=
 =?utf-8?B?UWdoZm5WTHVwZ3NMN1UvNkRMTVBDK0lXdTZENVlvWXVrU2VxN3IwRGtMWGFp?=
 =?utf-8?B?UnJxNnQ5b0YvYkw0SUs5SnV4NkhoRDdHUm5CSGs1RmQ3emtCL29mOFY1MWdT?=
 =?utf-8?B?YlhxeXVUQXc2Q0N3TFdkOUhkdThSc0w4cHNEdzBsNURkWFZ4VHozbVNsWXBq?=
 =?utf-8?B?QXBXeWRjS2FvOGFpdmNMRFJHMGFneTRVWkhXZkhvTG03aEdEOW1PcCt3NHc1?=
 =?utf-8?B?MHJiekkya3V5RDNrSWdsalFmbFhmSFNCRzVyUU1PeFkvWlphNnNZenZ6Witv?=
 =?utf-8?B?ZXFqVFAvVW4xKzJITUdHSDdWUEZibFJvVmFqTnpoRjRqTUIzVHZNNTJwNFg2?=
 =?utf-8?B?cU1EL3p4WDJrbm5DbWVzUTFzTDdGMHVScjJEbVFQcTdyN2tlZG04T01md3pw?=
 =?utf-8?B?Q0h2Q3A5Szd5UWdTMHoxZWdnd1MxbUs4b0hCSHdVU09LOXN4dElTeU1WVzN3?=
 =?utf-8?Q?LOiDyWSuIKvyLZtesd3FF9dS71VGsBKB4P/QflkQTc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2265b073-af28-4a1c-d526-08d99b0ed006
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 19:03:37.3563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yePbo90+RkeWvmc10Zmhqk2B7HQL5DPo/LZjVBYBVRsQYHFchp0WztPdQHPhll4dy9eOpaXiU2veRqsDb/u/H5UHD6dyfrNfcZM0xZa6xYI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2529
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dave,

On 10/29/2021 11:06 AM, Dave Hansen wrote:
> On 10/28/21 1:37 PM, Reinette Chatre wrote:
>> The amount of SGX memory on the system is determined by the BIOS and it
>> varies wildly between systems.  It can be from dozens of MB's on desktops
>> or VM's, up to many GB's on servers.  Just like for regular memory, it is
>> sometimes useful to know the amount of usable SGX memory in the system.
>>
>> Add an attribute for the amount of SGX memory in bytes to each NUMA
>> node. The path is /sys/devices/system/node/node[0-9]*/sgx/size.
>> Calculate these values by summing up EPC section sizes for each node
>> during the driver initalization.
> 
> For now, can we just make the selftests read the SGX CPUID section
> leaves?  It's not as precise as knowing how much the kernel actually
> decided to use, but it's good enough for a selftest.  It also means we
> can merge something without having to worry about long-term ABI.

Yes, we can do that.

> 
> This is also why I once suggested that we first make the selftests
> depend on some debugfs file that would be short-lived.  But, if we use
> CPUID, we don't even need to mess with debugfs.

My apologies, this was not intended to avoid your suggestion. V1 did use 
the debugfs solution as you suggested as placeholder but after the 
debufs solution evolved the tests were adapted to follow those changes 
instead of sticking with the debugfs solution as proposed in
https://lore.kernel.org/lkml/6f3cc681e10877e639b882eaabf1a5e21bd2fc94.camel@kernel.org/

> You can even just steal the code from sgx_page_cache_init() to do it.
> 
> Would that work, or am I missing something?
> 

I do think that will work. The selftests are only interested in the 
total SGX memory (as opposed to memory per numa node as exposed with the 
current interface) and that can be obtained via CPUID. I will adapt the 
oversubscription test case to obtain its needed info via CPUID.

Thank you very much

Reinette