Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp470305pxb; Fri, 29 Oct 2021 13:26:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIaHKw9ktpC8s/qs2q0s/BZi9EMYh2848Bq7N/7IlmV7E4//7Cnu8cLF6+bcwNUgFzN51W X-Received: by 2002:a05:6602:2e95:: with SMTP id m21mr9760192iow.21.1635539212771; Fri, 29 Oct 2021 13:26:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635539212; cv=none; d=google.com; s=arc-20160816; b=oEFar00OHG11ec6kWppx6g5klQoKmn+qvBeizfSZh3myp8xzKyixUyFCsplS79nlVz H9agHG5alcYViyf+1jK4E3rXNqYCnUno4VMa7zCYlrtTKv5DRloZl3xvUX4ztcCa7ywk hbHSJUf1mvvJYURTeap/0kEWc5duGmeNeydCwdTFZzUX71J97Ph9D/d40AI4qdTx4vs7 2wKbUxapNoBHj8uO3cGs5CbO5MZ0v/pFZkiM7uckbbgMrpZ1zWLRngf0El6fSYNTFgvz MFm6QnJZrfPVkoS15Iz3dpF70Pnn2IcdWlXNamYgyoi0+fk7E+jDxZSSJrA3x9BMIVoL eKNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=RJ/TZBmAjtBZEQ7SF9pt737iGPmZZZE1EbwprVB6+B8=; b=vMrjUAcd3o+WeBd61qwM1LvHYnRY2hz0gxh5leEOFckCf0zu+NklqOJGPK38a68P4S 6PnMNUmvuiHCbOYorqrGf/T7gr2akjpv8sKPVZkO5/PA1N8L31oaaq3TjXKB3c3pXsDc Jw7GXcsepvlmuHAgi7dM4/pPMwCJONBG5JDa2/rglQpYABqMVDmXWT4VsjT/vLsZc/Me 7elZHZ5DD3ZlXZyBvB24IZJ5HgeO8UqritBQbf4YvaDe5IPKa8ld6ZMpRO1gLYWwEvtI R0+yn1RPrIeozDyx2CxHrmfDogQJFACgDJKdYgSS1U7KhO3zIXjwVRdCJxajoOYpmwVC j4fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=V7zUdGU5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si9991204ild.28.2021.10.29.13.26.39; Fri, 29 Oct 2021 13:26:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=V7zUdGU5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbhJ2U1M (ORCPT + 99 others); Fri, 29 Oct 2021 16:27:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbhJ2U1L (ORCPT ); Fri, 29 Oct 2021 16:27:11 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 789C4C061570; Fri, 29 Oct 2021 13:24:42 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id h14so9466141qtb.3; Fri, 29 Oct 2021 13:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RJ/TZBmAjtBZEQ7SF9pt737iGPmZZZE1EbwprVB6+B8=; b=V7zUdGU5OyPHKOSW+97qNFQxF978EXAixxGqEZ/Y94ga83e7oOSPzqKe+u2JVmW7Jm Bodlq8QjoBnsQpOQNr800FHsezKSLgcnEYmVL8K6cy5nfykrtBWhdaHwV+f5nSyE3E7l 9NgumIDsGN6PIXx77Igm39kZUDxzmIBRIxdQNHDdHPNEgIJkEy1shiABtP8DPqzikX/u k8/vJlbeJkVTaTjFm4T2IqglG2X+PfAYU5FyTXTFV4RiUxfhbcSlsWDtdZZANarSvAZu 00A0UjgGdy6pvLHlfiJKOFii5OmfW9Fywp8C6h5AL5dlP59Ha6Xf4x/VPJsD/KDYK4U4 LgAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=RJ/TZBmAjtBZEQ7SF9pt737iGPmZZZE1EbwprVB6+B8=; b=A56jMOOPy+kNRXRd+9j8QDtSPp64s9wH/F6XMUHciCSbq9GWRmc3q3l4P48UqkTOfn Mr855zgbJh4I+uB360Zls819KuLGluyvXAdnehDkRtxKWK4TZtuEllFRNp3LEbDybVwO YAhun7bgCryHuxHCJ3mpoErAdlw/0xpmzqdb58jQJ6lA+/n07G2mAks8+/8xag8p5/RT VVtziIq3dF08grJlecW9PKh2V9n4Fu9/WCkJkqdy31lt26BksZtT5YuYZhsIjIHC8GfY YjJDeqpUODJt4xfojSiWMEdyOplCchactk++TQZ8FUccS8frvLa981OkMbVs74UxWbdJ jVwg== X-Gm-Message-State: AOAM53079wf7iGz/mI5mWLfdldQr6rOklUIOIsHG66gGXy02jZhCeAGa p6XZWGO4GAQBCKczWcDt+PE= X-Received: by 2002:a05:622a:18a6:: with SMTP id v38mr13999725qtc.208.1635539081677; Fri, 29 Oct 2021 13:24:41 -0700 (PDT) Received: from ubuntu-mate-laptop.eecs.ucf.edu ([132.170.15.255]) by smtp.gmail.com with ESMTPSA id x6sm4851479qko.83.2021.10.29.13.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 13:24:41 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com, rdunlap@infradead.org, daejun7.park@samsung.com Cc: fazilyildiran@gmail.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON Date: Fri, 29 Oct 2021 16:24:40 -0400 Message-Id: <20211029202440.7852-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When RESET_TI_SYSCON is selected, and RESET_CONTROLLER is not selected, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for RESET_TI_SYSCON Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y] Selected by [y]: - SCSI_UFS_MEDIATEK [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y] This is because RESET_TI_SYSCON is selected by SCSI_UFS_MEDIATEK, but SCSI_UFS_MEDIATEK does not select or depend on RESET_CONTROLLER, despite RESET_TI_SYSCON depending on RESET_CONTROLLER. These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha --- drivers/scsi/ufs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index b2521b830be7..0427f8277a5d 100644 --- a/drivers/scsi/ufs/Kconfig +++ b/drivers/scsi/ufs/Kconfig @@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK tristate "Mediatek specific hooks to UFS controller platform driver" depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK select PHY_MTK_UFS + select RESET_CONTROLLER select RESET_TI_SYSCON help This selects the Mediatek specific additions to UFSHCD platform driver. -- 2.30.2