Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <11956c14-f1f7-70f0-40a6-aad31a264af6@oracle.com>
Date:   Fri, 29 Oct 2021 17:46:18 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH v3] xen/balloon: add late_initcall_sync() for initial
 ballooning done
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        stable@vger.kernel.org,
        =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= 
        <marmarek@invisiblethingslab.com>
References: <20211029142049.25198-1-jgross@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211029142049.25198-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHFCdE1CZDdYRlI4eWhxUWNGZytNWTNMbXgxa0p6Q01vM0VOVDBFOFNmK0x5?=
 =?utf-8?B?eE84TU0xN3B4cklxRVR6YjZpRy9ndGl1M0laWW9WbnRsdVM2SzAvK2pKb3li?=
 =?utf-8?B?S2RqUTE4WmFuajhxQjcwZHZxYVZIcVJUUW1IdFZycmdlWTBlUDZxcWdNWG9n?=
 =?utf-8?B?d0Zhb1pWWkV2SUd6aVFCMHpCMExEcnBBeVFvSitCZDkra2RQeHNCcDk5T08r?=
 =?utf-8?B?dWlheVRiNm02bHE5U25RM2thKzBHTktrVmlmd0w0ZWFMaGNVYXREMGQ2dTlJ?=
 =?utf-8?B?OU5aUVpCUER2cDhsQlhpbmpnTFpHelZTV3FVZDhUMVJFUkYybUJSdWxqWS82?=
 =?utf-8?B?NnBXZERORnRtZnlOMEdCS2hhQTNLVXJReXZmQ25sVmxtRU9DZS9lMjhYRkdO?=
 =?utf-8?B?NlI1UXRJNEs2R0J6L2JVTzdZQmdsRzQ5V0FJOU9pdnBCM2Y5ckZ6RFpJNGgy?=
 =?utf-8?B?NnZYZzRKa21hQlNTZ0dncTdPbS9pRGM5S2IyWUFzRXdld0UvMnIzTHEzRnFB?=
 =?utf-8?B?L2xzdFZudWE4VVZjUC9tZVRLanorL2djd2J6dW96NExBZCs2RS9Pc2NUSjFu?=
 =?utf-8?B?Yk9jbGNBclg3M0lieUhuOE5ZWEJVRzZGak5ZMEE0TExMNGNmRnJiWG9JalR4?=
 =?utf-8?B?eDVuUXVISjFIb1oxNk5Ed1kyVHF2YktseUtIYjFkM245d3owSCtxQVlqcXBn?=
 =?utf-8?B?bEdQOERML3NmVDFpY0t6RGhyZHphUGJJY1pqOGdYWXBYYlJkcWFQZHJIaW1Y?=
 =?utf-8?B?Mm1DQU9MWTZDUEovVEFnZVB1Um8yZ0xrQkZxQjk0MUZiSGdtOFg3YXNPVmhR?=
 =?utf-8?B?aVR0UUc1dkxZMTFtRU0xS1lPQWNnTUFuT0ZyUEVGL29ndGZvZjdESEMxdWZk?=
 =?utf-8?B?NTEzT1JiTlpjMUdJWDNUdTMxYVp0NERadWt4eFZlQTJPNDN1Yk1TdWFyTXRJ?=
 =?utf-8?B?c3BiejdLRFV6NHpQQ21tODV2UEMrMUl3dHROdEZaNm5LMGNpa2JnU1R4MXRJ?=
 =?utf-8?B?MitGSWN5bGYyT2dnRHo0aXFybnhqa3pmTGN3eGQrSHRHaTE5cnkyaGlCRFpx?=
 =?utf-8?B?S0FGL2R3RGpuSXBHKzV0MWRzTldJQXBCVkxyaUErbFdsU2o4T2NncUlwNEla?=
 =?utf-8?B?VEZaeXBRSWhsL3llN2hNb0xOY1Z4ZHo1c2pield4ckZ4VUhONzJPVUp6UWt1?=
 =?utf-8?B?MUVML3lqUkpKL3BEeCtlNWxDem0yZWEwdE5zUERVTjdGdktZUEZ1Z2tLTEJh?=
 =?utf-8?B?QzRwa09YUnhuZmJFTHlHd1llay9xL1BicTJQWUEyZzlsaW9XenUvS2dlUDVl?=
 =?utf-8?B?NEZvWjZIYTNDUjZEUjM3L25FeGpPTWpWaFNybEdCUFh2eDExTllaZlJYZjlM?=
 =?utf-8?B?VTBJZ21KYnZyVGZISHpmRW4ydjVEQnNzZkZXaVZYS09uSG12QlpmT1lEcTNo?=
 =?utf-8?B?VERaSjFVTXI1aUJCZXhhMWJZVlJkSjJYZjVHWEdZbXEwczdTekh5MmtuZ1Q5?=
 =?utf-8?B?NW42eUtMWmRRQVVnSjh3MnF4cVB0NVI0TlhhckYzeGVjY3krRUNyZ0VwRUNo?=
 =?utf-8?B?aldXOE9LVy9EWXplQWthZEN2dStEN0krSUUvQS9nR1M4TmVKaFV3bkc0NlF4?=
 =?utf-8?B?Z29sekZkZnZhTzNvSER5cE5MWHp5Lys3YjRRbU5CeWRNZ2FyajN6cjVodUww?=
 =?utf-8?B?V05kMk9rL2pNeGFDelhhT3AvZkFBNjZKRlRYVUgrOFdiM05VdEpMZnprMWRB?=
 =?utf-8?B?RW9RSHIvQmN5RlFjUUhNU2FqRXdmZHNPV04xZTUrSlQrZUYxYTR3REJ2SHFa?=
 =?utf-8?B?SnlNYzBmWHVVVko4T24xVHN2V1E2eWlKRENXdUxYMlRCa0x1bjFDMG9rVEZk?=
 =?utf-8?B?VzhOOXdiMThNeEdYdzJCNzI4OS8vZ0VOUGRrdVorSmV3aE5WWHdtQTBDNVZ1?=
 =?utf-8?B?bE9qM29XNlVvT2xEOU0rT1YySmNFVWZWZ2dNNEpHVjJ4NWtvalUvYzR3RWph?=
 =?utf-8?B?ZUFqcE1hazNRMXBKQVhwZGM4eTMxSXRzM0FsOGVZK05HOTlMRnJUdnRBaDYv?=
 =?utf-8?B?WjBTNFdyTW0rT0FIY0NDWTN0QmpDODVmMUp5SFhKQ216WUh0Z3hRWlA1dGQ1?=
 =?utf-8?B?c2tnWlFlZGZqcVM4T3BMaGcrTEJXT3lPSiszaGdhQlM5VXI4ZWlacGRoVHpT?=
 =?utf-8?B?NVBscDhuM1RBVU9FOUNvbkdUSTFvQWJRR0dhOURzTXZRckJXWXRCYm9mMm5s?=
 =?utf-8?B?SDB4bHFCOXJQODZrVFFwY2NkRktnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe358997-26eb-43c5-55ed-08d99b258df1
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 21:46:24.8389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VT2TRdoxL967hFSaEZq4CDhXZgCUmSQJBUD59+lMzOvDaJdBdEbVobwct9yPUdc8wEdBpVm7VLvBfvmopjyePVRhFLb655fcrcoxz9kt0kQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4029
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10152 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110290120
X-Proofpoint-GUID: ih75n44LEzAuxc5fujNyjz6BAbENJBSn
X-Proofpoint-ORIG-GUID: ih75n44LEzAuxc5fujNyjz6BAbENJBSn
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/29/21 10:20 AM, Juergen Gross wrote:
> --- a/Documentation/ABI/stable/sysfs-devices-system-xen_memory
> +++ b/Documentation/ABI/stable/sysfs-devices-system-xen_memory
> @@ -84,3 +84,13 @@ Description:
>   		Control scrubbing pages before returning them to Xen for others domains
>   		use. Can be set with xen_scrub_pages cmdline
>   		parameter. Default value controlled with CONFIG_XEN_SCRUB_PAGES_DEFAULT.
> +
> +What:		/sys/devices/system/xen_memory/xen_memory0/boot_timeout
> +Date:		November 2021
> +KernelVersion:	5.16
> +Contact:	xen-devel@lists.xenproject.org
> +Description:
> +		The time (in seconds) to wait before giving up to boot in case
> +		initial ballooning fails to free enough memory. Applies only
> +		when running as HVM or PVH guest and started with less memory
> +		configured than allowed at max.


How is this going to be used? We only need this during boot.


>   
> -		state = update_schedule(state);
> +		balloon_state = update_schedule(balloon_state);


Now that balloon_state has whole file scope it can probably be updated inside update_schedule().


> +	while ((credit = current_credit()) < 0) {
> +		if (credit != last_credit) {
> +			last_changed = jiffies;
> +			last_credit = credit;
> +		}
> +		if (balloon_state == BP_ECANCELED) {


What about other states? We are really waiting for BP_DONE, aren't we?


-boris


> +			pr_warn_once("Initial ballooning failed, %ld pages need to be freed.\n",
> +				     -credit);
> +			if (jiffies - last_changed >=
> +			    HZ * balloon_stats.boot_timeout)
> +				panic("Initial ballooning failed!\n");
> +		}
> +