Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [PATCH v2] scsi: ufshpb: Opt out pre-reqs from HPB2.0 flows
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <avri.altman@wdc.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bean Huo <beanhuo@micron.com>,
        Daejun Park <daejun7.park@samsung.com>,
        James Bottomley <James.Bottomley@HansenPartnership.com>
In-Reply-To: <20211029193002.4187-1-avri.altman@wdc.com>
Message-ID: <1891546521.01635546902168.JavaMail.epsvc@epcpadp3>
Date:   Sat, 30 Oct 2021 07:30:07 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
References: <20211029193002.4187-1-avri.altman@wdc.com>
        <CGME20211029193014epcas2p10300c03ccf0337f9dd3653f29e2057d1@epcms2p1>
Precedence: bulk

Hi Avri,
 
> @@ -1841,13 +1575,7 @@ static void ufshpb_lu_parameter_init(struct ufs_hba *hba,
>          u32 entries_per_rgn;
>          u64 rgn_mem_size, tmp;
>  
> -        /* for pre_req */
> -        hpb->pre_req_min_tr_len = hpb_dev_info->max_hpb_single_cmd + 1;
> -
> -        if (ufshpb_is_legacy(hba))
> -                hpb->pre_req_max_tr_len = HPB_LEGACY_CHUNK_HIGH;
> -        else
> -                hpb->pre_req_max_tr_len = HPB_MULTI_CHUNK_HIGH;
> +        hpb->pre_req_max_tr_len = HPB_LEGACY_CHUNK_HIGH;

They are should be not changed, because it makes ufshpb_is_supported_chunk()
determine to non-HPB READ when the its size is bigger than 4KB.

>  
>          hpb->cur_read_id = 0;
>  
> @@ -2858,8 +2586,7 @@ void ufshpb_get_geo_info(struct ufs_hba *hba, u8 *geo_buf)
>  void ufshpb_get_dev_info(struct ufs_hba *hba, u8 *desc_buf)
>  {
>          struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
> -        int version, ret;
> -        u32 max_hpb_single_cmd = HPB_MULTI_CHUNK_LOW;
> +        int version;
>  
>          hpb_dev_info->control_mode = desc_buf[DEVICE_DESC_PARAM_HPB_CONTROL];
>  
> @@ -2875,13 +2602,6 @@ void ufshpb_get_dev_info(struct ufs_hba *hba, u8 *desc_buf)
>          if (version == HPB_SUPPORT_LEGACY_VERSION)
>                  hpb_dev_info->is_legacy = true;
>  
> -        ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> -                QUERY_ATTR_IDN_MAX_HPB_SINGLE_CMD, 0, 0, &max_hpb_single_cmd);
> -        if (ret)
> -                dev_err(hba->dev, "%s: idn: read max size of single hpb cmd query request failed",
> -                        __func__);
> -        hpb_dev_info->max_hpb_single_cmd = max_hpb_single_cmd;
> -
>          /*
>           * Get the number of user logical unit to check whether all
>           * scsi_device finish initialization
> diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
> index a79e07398970..a4e7e33d451e 100644
> --- a/drivers/scsi/ufs/ufshpb.h
> +++ b/drivers/scsi/ufs/ufshpb.h
> @@ -31,8 +31,6 @@
>  
>  /* hpb support chunk size */
>  #define HPB_LEGACY_CHUNK_HIGH                        1
> -#define HPB_MULTI_CHUNK_LOW                        7
> -#define HPB_MULTI_CHUNK_HIGH                        255

Because of above issue, they should be remained.

Thanks,
Daejun