Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <867f6da4-6d38-6435-3fbb-a2a3744029f1@huawei.com>
In-Reply-To: <867f6da4-6d38-6435-3fbb-a2a3744029f1@huawei.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Sat, 30 Oct 2021 20:23:12 +0800
Message-ID: <CAMZfGtU+wyjD6e0Xm7-toqqfA2tsu8nSUQJsZdC=piZzgq76fw@mail.gmail.com>
Subject: Re: [PATCH] mm, slub: place the trace before freeing memory in kmem_cache_free()
To:     Yunfeng Ye <yeyunfeng@huawei.com>
Cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, wuxu.wu@huawei.com,
        Hewenliang <hewenliang4@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 30, 2021 at 6:12 PM Yunfeng Ye <yeyunfeng@huawei.com> wrote:
>
> After the memory is freed, it may be allocated by other CPUs and has
> been recorded by trace. So the timing sequence of the memory tracing is
> inaccurate.
>
> For example, we expect the following timing sequeuce:
>
>     CPU 0                 CPU 1
>
>   (1) alloc xxxxxx
>   (2) free  xxxxxx
>                          (3) alloc xxxxxx
>                          (4) free  xxxxxx
>
> However, the following timing sequence may occur:
>
>     CPU 0                 CPU 1
>
>   (1) alloc xxxxxx
>                          (2) alloc xxxxxx
>   (3) free  xxxxxx
>                          (4) free  xxxxxx
>
> So place the trace before freeing memory in kmem_cache_free().

Could you tell me what problem you have encountered
here?

Thanks.

>
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> ---
>  mm/slub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 432145d7b4ec..427e62034c3f 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -3526,8 +3526,8 @@ void kmem_cache_free(struct kmem_cache *s, void *x)
>         s = cache_from_obj(s, x);
>         if (!s)
>                 return;
> -       slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_);
>         trace_kmem_cache_free(_RET_IP_, x, s->name);
> +       slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_);
>  }
>  EXPORT_SYMBOL(kmem_cache_free);
>
> --
> 2.27.0