Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chengfeng Ye <cyeaa@connect.ust.hk>
To:     mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com
Cc:     linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Chengfeng Ye <cyeaa@connect.ust.hk>
Subject: [PATCH] clk/mediatek: fix missing null-check for mt7622
Date:   Sat, 30 Oct 2021 07:07:40 -0700
Message-Id: <20211030140740.6947-1-cyeaa@connect.ust.hk>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tJX2fJf5sZRj8vwXm3WjPGc+WpIOKBc0GG5IRki83Hy9p0Mqq73DKi6fydAU?=
 =?us-ascii?Q?Kr5UMsNtSiBKxGnhD0yy9KZ+uGlQWvul01Z5gozWfNQlMN3oozzsY8ztWImU?=
 =?us-ascii?Q?cpDuCmu4few083nd9P4ZHQ9WnCanEI9mcUP5ZmwFHDqcUO5jb4Bcmn7/bbWK?=
 =?us-ascii?Q?uO/o0Md4mqW5C7ADJGTNlQAl9MF3V+jzgf3duhC0sOZ7lFrh+RrmMQru7o/y?=
 =?us-ascii?Q?2Xbeq74Q5qZCBb3b97/UkX0whqVVgvHxPGEqs3UWxOAAopV5ww2CqW7Ru3Fi?=
 =?us-ascii?Q?vsjXKRZCTbnFH71hSprVBup8PVKX6XP/QqSBjx8jWP1yJfVhKev2hatDP0Le?=
 =?us-ascii?Q?5PlQez9CqOEdgddVLZtD4ws4VH2jHef+BhSIy2i93qwutThJEMegmbQcuPGZ?=
 =?us-ascii?Q?smjhPUj7FbuEpEmFoDyKY4hrR1NPpFaDHi5FsVOgXxwnkx1JjjdGUNlMuHEU?=
 =?us-ascii?Q?pyLQxiqwpRyJTlpTFdQGCaTUW3rMWUqsivy6j6V1n1NBqDu+NhkcINi4GYHZ?=
 =?us-ascii?Q?0GFHHHWixSDGCbZdlLgtxirmdYddS0u45s8b76J49oIHT39csc/YtSF2SLC3?=
 =?us-ascii?Q?boQkpBG9ako1SXXoOISV1hRYapXypQbZOANTibw+YK3RsJnSFvJlUA7VoEhh?=
 =?us-ascii?Q?THsxj0pe+xERz2C67D20M5NwOTLUj/+m1jKVbCt/b6kIqIdjm5LMG00bRZfB?=
 =?us-ascii?Q?hH1jkxQaFDi/NRvvdJ0298wOhKrwmoRi1TeaHKGJHA1siNPCy/wd+XcCSyyQ?=
 =?us-ascii?Q?SlyI4KjnZz1Kmblwh/CP6DHUjpc+9cSpXaUcsCoo3dK7eHiPq2UxcNNtaL6Y?=
 =?us-ascii?Q?mA16F6m0ED/g9TZt6cm1mc+Dg1sO/pXidolH4RFhU/Fq60rLd+zMjfSEQJy+?=
 =?us-ascii?Q?2mwxhy7QxJgUb66vyrT4K/tOaO1lFsOSiTLy1v9bjG2kI0kn8GVu3bs0Phb7?=
 =?us-ascii?Q?gQ8R1z/+6qN6PmmIaAoZzXAN0uf81KLrqnn07wpQPnYKR3z9MlBTrn1DYqgJ?=
 =?us-ascii?Q?EVZLCUZnhOLncO9+RRUVeA3fdnjHLSFgBFICxkJ4kF30RY7EJIn9L578iV/A?=
 =?us-ascii?Q?se7zQAWzdOmZb5ovj3GNq+VK0KAyb4Wny6D1dbIvwl/Fpx81NTaJ1LZe/boV?=
 =?us-ascii?Q?7PcVyM1VoMp6KVfVcJ0nAOCrr1yQoBwKlUucyvSbe754FeYz+kiE9QrYoWBZ?=
 =?us-ascii?Q?o9dRdVQeXAE0tmCPJA0zG+Kswe4CC3tfEdBJDANtv0o/Z900vM7d8WkYouR/?=
 =?us-ascii?Q?gCVdZ+v5k2/qxOKJEbU7pVDgvnWkjFP5GsUWBLu6Mav3dMQFBqxhfs6p1pVg?=
 =?us-ascii?Q?NpuV22XnJmNq8UjFcKwAtHRIw157YISn2vRfMmG/ZGhBBfrshQJBBE/bS+rf?=
 =?us-ascii?Q?Xy8HMviiVOeOjKcm/JKi8PD//z0xBcURfcw7reIMYixLJCTEG47z1V6yLSTD?=
 =?us-ascii?Q?1y0BRFW1pWabSWHUJkOW34I9wxwPv30IxAsI7v7ZG9di0OCYjQVN3LB69QNE?=
 =?us-ascii?Q?kEMikfIwb6i/ezoVoAqIhpNP+TBWiGpXYVgu27IPBEy0OGYQ6eOLFXhNuVzo?=
 =?us-ascii?Q?IUCBhb2IKch36Br+rArO9Go+ruu32JcxrNTVaEs9NNYJjodI6AfYO3g+tP4Q?=
 =?us-ascii?Q?Qx2XTs/+ekq9mDQdPmQFCGc=3D?=
X-OriginatorOrg: connect.ust.hk
X-MS-Exchange-CrossTenant-Network-Message-Id: b5652177-7c59-4c66-8c5f-08d99baeab46
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2021 14:07:55.1261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SmW4GVBNT+t8HAOXrZiGB9zlIzYvDytHh8mbzVq+33Kr5pTIWfwtXQS1ELgEVHeykCf4a/AfUhjMyQtctB1CNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB0985
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The return pointer of mtk_alloc_clk_data could
be null, adding null check for all the call sites.

Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
---
 drivers/clk/mediatek/clk-mt7622.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/clk/mediatek/clk-mt7622.c b/drivers/clk/mediatek/clk-mt7622.c
index ef5947e15c75..f16b3655ff76 100644
--- a/drivers/clk/mediatek/clk-mt7622.c
+++ b/drivers/clk/mediatek/clk-mt7622.c
@@ -620,6 +620,8 @@ static int mtk_topckgen_init(struct platform_device *pdev)
 		return PTR_ERR(base);
 
 	clk_data = mtk_alloc_clk_data(CLK_TOP_NR_CLK);
+	if (!clk_data)
+		return -ENOMEM;
 
 	mtk_clk_register_fixed_clks(top_fixed_clks, ARRAY_SIZE(top_fixed_clks),
 				    clk_data);
@@ -650,6 +652,8 @@ static int mtk_infrasys_init(struct platform_device *pdev)
 	int r;
 
 	clk_data = mtk_alloc_clk_data(CLK_INFRA_NR_CLK);
+	if (!clk_data)
+		return -ENOMEM;
 
 	mtk_clk_register_gates(node, infra_clks, ARRAY_SIZE(infra_clks),
 			       clk_data);
@@ -700,6 +704,8 @@ static int mtk_pericfg_init(struct platform_device *pdev)
 		return PTR_ERR(base);
 
 	clk_data = mtk_alloc_clk_data(CLK_PERI_NR_CLK);
+	if (!clk_data)
+		return -ENOMEM;
 
 	mtk_clk_register_gates(node, peri_clks, ARRAY_SIZE(peri_clks),
 			       clk_data);
-- 
2.17.1