Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <abf21c4f-5bbb-a0bb-534a-3d2758b4a8d6@suse.de>
Date:   Sat, 30 Oct 2021 22:58:47 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] bcache: remove unused struct member in cache_stats
Content-Language: en-US
To:     Lin Feng <linf@wangsu.com>
Cc:     linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211029115939.92309-1-linf@wangsu.com>
From:   Coly Li <colyli@suse.de>
In-Reply-To: <20211029115939.92309-1-linf@wangsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/29/21 7:59 PM, Lin Feng wrote:
> Commit 1616a4c2ab1a80893b6890ae93da40a2b1d0c691
> ("bcache: remove bcache device self-defined readahead")
> remove stuffs for bcache self-defined readahead, but
> cache_readaheads field in cache_stats is leftout, remove it.
>
> Signed-off-by: Lin Feng <linf@wangsu.com>

Nice catch. I add it into my testing queue. Thanks.

Coly Li

> ---
>   drivers/md/bcache/stats.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
> index ca4f435f7216..b6bfea66c01f 100644
> --- a/drivers/md/bcache/stats.h
> +++ b/drivers/md/bcache/stats.h
> @@ -18,7 +18,6 @@ struct cache_stats {
>   	unsigned long cache_misses;
>   	unsigned long cache_bypass_hits;
>   	unsigned long cache_bypass_misses;
> -	unsigned long cache_readaheads;
>   	unsigned long cache_miss_collisions;
>   	unsigned long sectors_bypassed;
>