Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 30 Oct 2021 17:03:33 +0200
Message-ID: <s5hzgqqr1ve.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jason Ormes <skryking@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HX-Stomp XL USB_ID.
In-Reply-To: <CABDyYE53Eh4+rMyJC94MePSnhxCy5h_1Eh-nwj-d46NUaaDJbQ@mail.gmail.com>
References: <20211029183105.28503-1-skryking@gmail.com>
        <s5h7ddusw91.wl-tiwai@suse.de>
        <CABDyYE53Eh4+rMyJC94MePSnhxCy5h_1Eh-nwj-d46NUaaDJbQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 30 Oct 2021 16:32:36 +0200,
Jason Ormes wrote:
> 
> It appears to, it's basically just the HX Stomp that they have added a few
> more buttons to.  The USB ID has changed so it doesn't get the fixed rate that
> it needs.  After I added it, I've spent several hours recording through it
> without any issues.  Even the midi functionality works.  

So give such useful information in the patch description and
resubmit.  At best, align the Subject line to the other patches,
i.e. with the prefix "ALSA: usb-audio: .....", and put the maintainer
(me) to Cc in addition to alsa-devel ML.


thanks,

Takashi

> 
> Jason Ormes
> 
> On Sat, Oct 30, 2021, 4:22 AM Takashi Iwai <tiwai@suse.de> wrote:
> 
>     On Fri, 29 Oct 2021 20:31:05 +0200,
>     Jason Ormes wrote:
>     >
>     > Signed-off-by: Jason Ormes <skryking@gmail.com>
>    
>     Could you give a bit more description?
>     e.g. does the device work fully compatibly?
> 
>     thanks,
>    
>     Takashi
>    
>     > ---
>     >  sound/usb/format.c | 1 +
>     >  1 file changed, 1 insertion(+)
>     >
>     > diff --git a/sound/usb/format.c b/sound/usb/format.c
>     > index 50efccbffb8a..e8fc2c350a9f 100644
>     > --- a/sound/usb/format.c
>     > +++ b/sound/usb/format.c
>     > @@ -414,6 +414,7 @@ static int line6_parse_audio_format_rates_quirk
>     (struct snd_usb_audio *chip,
>     >       case USB_ID(0x0e41, 0x4242): /* Line6 Helix Rack */
>     >       case USB_ID(0x0e41, 0x4244): /* Line6 Helix LT */
>     >       case USB_ID(0x0e41, 0x4246): /* Line6 HX-Stomp */
>     > +        case USB_ID(0x0e41, 0x4253): /* Line6 HX-Stomp XL*/
>     >       case USB_ID(0x0e41, 0x4247): /* Line6 Pod Go */
>     >       case USB_ID(0x0e41, 0x4248): /* Line6 Helix >= fw 2.82 */
>     >       case USB_ID(0x0e41, 0x4249): /* Line6 Helix Rack >= fw 2.82 */
>     > --
>     > 2.25.1
>     >
> 
>