Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 01/13] platform/x86: Rename touchscreen_dmi to
 dmi_device_properties
To:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Andy Shevchenko <andy@infradead.org>,
        Wolfram Sang <wsa@the-dreams.de>,
        Sebastian Reichel <sre@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Ard Biesheuvel <ardb@kernel.org>
Cc:     Yauhen Kharuzhy <jekhor@gmail.com>,
        Tsuchiya Yuto <kitakar@gmail.com>,
        platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-efi@vger.kernel.org
References: <20211030182813.116672-1-hdegoede@redhat.com>
 <20211030182813.116672-2-hdegoede@redhat.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <c01f2bf6-1385-3cf8-d180-9051494fc04e@infradead.org>
Date:   Sat, 30 Oct 2021 12:07:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211030182813.116672-2-hdegoede@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 10/30/21 11:28 AM, Hans de Goede wrote:
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index b110a2e6b8f3..9cb8d33cc6e1 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -981,17 +981,19 @@ config MLX_PLATFORM
>   
>   	  If you have a Mellanox system, say Y or M here.
>   
> -config TOUCHSCREEN_DMI
> -	bool "DMI based touchscreen configuration info"
> -	depends on ACPI && DMI && I2C=y && TOUCHSCREEN_SILEAD
> +config DMI_DEVICE_PROPERTIES
> +	bool "DMI based extra device properties"

	      DMI-based

> +	depends on ACPI && DMI && I2C=y
>   	select EFI_EMBEDDED_FIRMWARE if EFI
>   	help
> -	  Certain ACPI based tablets with e.g. Silead or Chipone touchscreens
> -	  do not have enough data in ACPI tables for the touchscreen driver to
> -	  handle the touchscreen properly, as OEMs expect the data to be baked
> -	  into the tablet model specific version of the driver shipped with the
> -	  the OS-image for the device. This option supplies the missing info.
> -	  Enable this for x86 tablets with Silead or Chipone touchscreens.
> +	  Sometimes ACPI based x86 devices do not have enough data in their ACPI

	            ACPI-based

> +	  tables to fully describe the hardware. This option enables support for
> +	  supplying the missing info based on DMI (vendor & model string)
> +	  matching for devices where this info has been added to the
> +	  dmi-device-properties code.
> +
> +	  This option is often necessary for correct operation of x86 based

	                                                          x86-based

> +	  tablets and 2-in-1 devices. If in doubt, say Y here.


-- 
~Randy