Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932319AbXADIAS (ORCPT ); Thu, 4 Jan 2007 03:00:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932322AbXADIAR (ORCPT ); Thu, 4 Jan 2007 03:00:17 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:58976 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932319AbXADIAP (ORCPT ); Thu, 4 Jan 2007 03:00:15 -0500 Message-ID: <459CB3E6.9080906@bull.net> Date: Thu, 04 Jan 2007 08:59:34 +0100 From: Pierre Peiffer User-Agent: Thunderbird 1.5.0.9 (X11/20061219) MIME-Version: 1.0 To: Ingo Molnar Cc: LKML , Dinakar Guniguntala , Jean-Pierre Dion , =?ISO-8859-1?Q?S=E9bastien?= =?ISO-8859-1?Q?_Dugu=E9?= , Ulrich Drepper , Darren Hart Subject: Re: [PATCH 2.6.19.1-rt15][RFC] - futex_requeue_pi implementation (requeue from futex1 to PI-futex2) References: <459BA267.1020706@bull.net> <20070103123536.GA9088@elte.hu> <459BBF15.5070505@bull.net> <20070103155609.GB11066@elte.hu> In-Reply-To: <20070103155609.GB11066@elte.hu> X-MIMETrack: Itemize by SMTP Server on ECN002/FR/BULL(Release 5.0.12 |February 13, 2003) at 04/01/2007 09:08:09, Serialize by Router on ECN002/FR/BULL(Release 5.0.12 |February 13, 2003) at 04/01/2007 09:08:12, Serialize complete at 04/01/2007 09:08:12 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 28 Ingo Molnar a ?crit : > * Pierre Peiffer wrote: > >> Ingo Molnar a ?crit : >>> looks good to me in principle. The size of the patch is scary - is there >>> really no simpler way? >> Humf, in fact, for the 64-bit part, I've followed the rule of the >> existing 64-bit code in futex.c, which consists of duplicating all the >> functions which can not be kept common, and add a suffix 64 to all >> duplicated functions. Perhaps I missed something ? > > i dont think you missed anything - but some consolidation here would be > nice. Only if possible of course :-) Ok ;-) So, you are not only speaking about "my" part of duplicated code, right ? But, just for information, what is the sys_futex64 for, exactly ? Is there a plan to have in the future a 64-bit PID ? Because for now, 32-bits futex is enough, so... ? Otherwise, I don't have a "clean" way to avoid this duplication.... :-/ -- Pierre Peiffer - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/