Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1481789pxb; Sat, 30 Oct 2021 14:49:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMPidox7nWko0jYJyqwVPEbx+iuFd9PXfDzRrXBWjwFnA5gqisRFDu/5Wgcmr7Tw8WPfxO X-Received: by 2002:a17:906:a851:: with SMTP id dx17mr1969511ejb.484.1635630548221; Sat, 30 Oct 2021 14:49:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635630548; cv=none; d=google.com; s=arc-20160816; b=x/sj4I8v8bztrzyQBkiLV/++Ja+cZzwnVVyT5Idk+EZM1CEmWREJqMEXi/3/X+ozXX UjUzTp8R53YAUQrNuV2rjsevByNVeLHCEpHUERwWa35YQMi60BMjbwmuRMS2/xM+ba5N HfOEk0a3nCjLD5RwMEOhcLu5Q1jf+j60GFsAyVDF9EQbZz4KEaq4DDzBCwtSKvoT9DWg eb6F+n7wS8KWT5D5kya7GH7OSB1Te1TIQVX0i6yFk4DjzwfwkV1Q1GGVVlB3Gv55kv2W fn9nTkGB2PattGlYY6Dyzm/1Xuau1gJ3L3HqqEJWGp+bBIBLIFPshYWQ1pNKrxduMzxN elfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=UpOdkkmedu+MT1j0qOKM0vMS+Pldrns6CkXNStQ3Jvo=; b=PJ4Oo3yWxQatBHPJOucLzLXuQwyWAZqXL2v+7+xhvPTCQZ5Vt3KTfj62jCuC9CKB3Z rCApLfTJwGrPLb/jninlrzSb/zjl+urHeQZ8MUlDecZvHSmu/uA65KFhcSXZI/VLHgIR kQamjkWCqZJikrCY65JY9GK22sIWve2H0mlKmgQ5UI024es/ESe+xd03kTrHMEn3qiIp S4uVqFfAB2DIQ4+6V1sAuXZgmseBSroIWIQvvNBIRdkPCRj9bAX8+V8VPa48wdl/KY/U supTsZGfeIUqXztPOqvbRS5Ux4epByvB2+HHcGBH2MLZSzOr0aOSdQhHcHiL6yTkK401 buWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@o2.pl header.s=1024a header.b=yQXxf5LB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=o2.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm20si7609499ejc.248.2021.10.30.14.48.45; Sat, 30 Oct 2021 14:49:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@o2.pl header.s=1024a header.b=yQXxf5LB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=o2.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231960AbhJ3Vtd (ORCPT + 99 others); Sat, 30 Oct 2021 17:49:33 -0400 Received: from mx-out.tlen.pl ([193.222.135.142]:9756 "EHLO mx-out.tlen.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231494AbhJ3Vtc (ORCPT ); Sat, 30 Oct 2021 17:49:32 -0400 Received: (wp-smtpd smtp.tlen.pl 9507 invoked from network); 30 Oct 2021 23:46:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=o2.pl; s=1024a; t=1635630417; bh=UpOdkkmedu+MT1j0qOKM0vMS+Pldrns6CkXNStQ3Jvo=; h=From:To:Cc:Subject; b=yQXxf5LBWVPU8mZVhPOegk6fDQ/G7I7MT9VUsz1b3QRIqqR7pQOIGU+CZ8RafjqZG Us8PxzaZkAR9wo9O+S4XBj5hyITbm6RO6CqyNzkymUJy+9lfDCi5IO8OYDYJJEGTnS e1eHNEQm468AhuawENmZgb94LRf1eDhN4tjnqjrY= Received: from ablz112.neoplus.adsl.tpnet.pl (HELO localhost.localdomain) (mat.jonczyk@o2.pl@[83.7.219.112]) (envelope-sender ) by smtp.tlen.pl (WP-SMTPD) with SMTP for ; 30 Oct 2021 23:46:57 +0200 From: =?UTF-8?q?Mateusz=20Jo=C5=84czyk?= To: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Mateusz=20Jo=C5=84czyk?= , Alessandro Zummo , Alexandre Belloni , Greg KH Subject: [PATCH v3 0/7] rtc-cmos,rtc-mc146818-lib: fixes Date: Sat, 30 Oct 2021 23:46:28 +0200 Message-Id: <20211030214636.49602-1-mat.jonczyk@o2.pl> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-WP-MailID: ff46f2686c595fe53ef6cf992f297bac X-WP-AV: skaner antywirusowy Poczty o2 X-WP-SPAM: NO 0000000 [gXME] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, This patch series fixes some issues in the RTC CMOS handling code: 1. A missing spin_lock_irq() / spin_unlock_irq() pair in cmos_set_alarm(). 2. A failing presence check of the RTC: the clock was misdetected as broken since Linux 5.11 on one of our home systems. 3. Do not touch the RTC alarm registers when the RTC update is in progress. (On some Intel chipsets, this causes bogus values being read or writes to fail silently.) This is my first patch series, so please review carefully. v2: Drop the last patch: Revert "rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ" which was made obsolete by mainlining of commit 13be2efc390a ("rtc: cmos: Disable irq around direct invocation of cmos_interrupt()") v3: Rework solution to problem 3 (I'd like to thank Greg KH for comment), drop x86 refactoring patches (I'll send them later). Greetings, Mateusz Signed-off-by: Mateusz Jończyk Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Greg KH