Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e84733ca-ce46-9f4f-e082-f04c18301389@axentia.se>
Date:   Sun, 31 Oct 2021 00:31:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v2 2/2] i2c-mux-gpmux: Support settle-time-us property
Content-Language: en-US
To:     Horatiu Vultur <horatiu.vultur@microchip.com>, robh+dt@kernel.org,
        linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Lars Povlsen <lars.povlsen@microchip.com>
References: <20211028125341.2457171-1-horatiu.vultur@microchip.com>
 <20211028125341.2457171-3-horatiu.vultur@microchip.com>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <20211028125341.2457171-3-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajNQZ3lWT2t3K25XZ2RJTlVXaC9aOFZxYVAyTjR4SjZlZTBMQnNvOXdtL0Vj?=
 =?utf-8?B?eFBlUmhCU082czdzb09OejVob2lnTE85aXBqYkRkTnpKWmdZK2NKcTRJUTVT?=
 =?utf-8?B?UnR5QUhMdDFPeWhyWWE3T2hyS3hDMG1xeUZkaG1GblhvMXdTWnJtSWthTkZJ?=
 =?utf-8?B?ZnVYV1ZKSEZ2K3o3QkRVdUxkci9IQk03ajVQWnQxU1p5Ym5SQ3VMUWc0NmlV?=
 =?utf-8?B?VW0ralpnZWtoMjJHamxPRTc4b0dSTU90K014NFloZ24zTDB1SmJRZ0lOWUoz?=
 =?utf-8?B?UDVYTlJJa0I5UzB6YUNxUDZjOVJEc1ZySWxKd1VzMmxkSlhNU0Q0clJFL3FJ?=
 =?utf-8?B?dWViV1c2NjY3anFIbFErNXk1bUlPODk1cEh0aUp4eXRHekROdzJTMEo4U1Ns?=
 =?utf-8?B?S0tVU2dVaVlaWjRFZ0YvMndKU3Z3QkhRVHpBQklMbm1XbzdPaGRVazd0ZDkv?=
 =?utf-8?B?ZnNidndVLzlmNW5aZGwzeE04UnA5OUU4b1lEK1BFMU5YMXYzbnlvOXhtNEha?=
 =?utf-8?B?NnpZM25ubG5OQjgxK21HaUJaaG0xenhndnpSdkFkN0p3K283ekNCajc4MGc3?=
 =?utf-8?B?SFRnaWl1Zy9QTFUrUE52TkRJSE1jTExPYlBiak0zYXgxL3hkVUNFVzdaUXda?=
 =?utf-8?B?UnloVERlNlJ3eHhZQVVOc1p1bjg0akM3aCszTmRKTURIRnJMQTRPZExCN1dS?=
 =?utf-8?B?VVVVczU4N3NKUFFCTUVubjBOUVVUSU5SRk03L3NRUjhmTTFVSUU1SHNUcHd0?=
 =?utf-8?B?RFRCWngraG1CSzllWTFmVllvVjN1dk1wRWk1NWVXSWRVeFNoZ01hbWNnR1lY?=
 =?utf-8?B?d21nWXByMlEvbnNuZDE1cFFtNmtyWHE1M1hJVU9paFV1RmY5b2JxdTFsRXFY?=
 =?utf-8?B?U1NIWDgwUkxnSjZ3Q3dlRHpRYThFdmZUNHlOYjlVY2pZY1I5SS8zQnNUaUZl?=
 =?utf-8?B?UU53Z0xVSXU1VGsyYUNLUG9BSDIvSXZtTzljZkpTWjNldjA1Z0lBR3JoR0J0?=
 =?utf-8?B?Qlp5cnh6c1lZTXJORW1jcmdVZWVxSWs3NzZlZFl6WW5KZmtERTE4cndaNXNz?=
 =?utf-8?B?QkJPUVY5N3UxaWFPa2J0QzBVb0gyUDZzMWowMjVlVjh0NXpvMGVCUE91U3Ba?=
 =?utf-8?B?RWl3QndSb1NVRHRzVy8wem0veC82UWcwYmlBZm9ad3FjbTJ6Wnc5ejBGM2RV?=
 =?utf-8?B?WDAwRmQ4M2V2RW1oTng5ZTR5VVdmOWZPTVFnWVRaRHF2Ly9vbkxMYk44aVJx?=
 =?utf-8?B?QWxGMUh5aEtrWkZRQVVidTRlckJvd1AwNWFUS0h3WmxmeTFScGhwOEpabjVv?=
 =?utf-8?B?a3VDMG5uUFg2czhnUk5lemVXODR5dndJTkpWZEU2a25BUDdiZCtxY3lYWEx0?=
 =?utf-8?B?U1ZPK3lHNTl0eW9sSzlLN0FBMTRieHhmcEp1NWVLVFNpaitQUEZ6NzB1MWdN?=
 =?utf-8?B?c2QzMWNUNmgvNjYrTnBkNGpRWWpXdE9hRm5WVFppZkJHOFlReVAraXJDenJU?=
 =?utf-8?B?UXlyRmkwZ1FPNDhnWDJ0UWdZYk9nV3BzZTlwM0ViWXEwZ0NZQlB2OGFnbG9R?=
 =?utf-8?B?SmNZaDVrWmtSa2JMWjJwNHJrSjg1YjlGY09KSmlWQkprZU42dzFnd2h2TFJG?=
 =?utf-8?B?RmpidGoyS3BRbHZhbTB1Nm5UcHcwRHhOUWNpcjI2NUZOaUhIQlV1NHBoSDFn?=
 =?utf-8?B?RjVsb1dpblZ3Uk5mRzdoUXlwTDFzSmRKZTJhMiswdFhuaVN4aHFIWHZVaFJE?=
 =?utf-8?B?VGhDQ3hzWFhhTEkrSlZZR2VLKy82amR2OWJBZG5XdFFtYVNZSXp1U1FEWWNl?=
 =?utf-8?B?U2UwdS83YnA3ZmEwVGFzclZMK0l2ZFJhMHlnZWJpN01yQ3E4Q0ZZdGtJSjJC?=
 =?utf-8?B?TzEyTUFsSHU3amF2Ymxodko2WkhjakdxTHAyR3FGVHlZWXN6cmk1QVdPeVdZ?=
 =?utf-8?B?YkZ6SnhDSTBlOEpmLzdLcjBySGpqOFp4b0ZUdWw1SEFrcGpheDhuTkhNZkxx?=
 =?utf-8?B?aGxGQmdFdXcrVncxd0MxWHpGUXJHWXg0Y0FyNkpxVlp6SmlYcUNVVVJ4dm9q?=
 =?utf-8?B?RkNrSjB3NHN4b2Mvcmp0dHVZazFUWFYwc3czeitaWDA3Tk1Fek9idnhkQ056?=
 =?utf-8?Q?27D0=3D?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: c18e686d-31e5-4f35-e2f1-08d99bf50bb4
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2021 22:31:41.6591
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ENif/0bMaPO3kOsY9pt/OLXYAPmguki3+my0+L1pb+k4h6QsqjUX3PEC6lMsr6DS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR02MB4474
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-10-28 14:53, Horatiu Vultur wrote:
> Add support for settle-time-us property. If this is defined in device
> tree then add this delay to mux APIs.
> 
> Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/i2c/muxes/i2c-mux-gpmux.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpmux.c b/drivers/i2c/muxes/i2c-mux-gpmux.c
> index d3acd8d66c32..569de1d8fdc1 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpmux.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpmux.c
> @@ -16,6 +16,7 @@
>  
>  struct mux {
>  	struct mux_control *control;
> +	u32 delay_us;
>  
>  	bool do_not_deselect;
>  };
> @@ -25,7 +26,7 @@ static int i2c_mux_select(struct i2c_mux_core *muxc, u32 chan)
>  	struct mux *mux = i2c_mux_priv(muxc);
>  	int ret;
>  
> -	ret = mux_control_select(mux->control, chan);
> +	ret = mux_control_select_delay(mux->control, chan, mux->delay_us);
>  	mux->do_not_deselect = ret < 0;
>  
>  	return ret;
> @@ -89,6 +90,9 @@ static int i2c_mux_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, PTR_ERR(mux->control),
>  				     "failed to get control-mux\n");
>  
> +	mux->delay_us = 0;
> +	of_property_read_u32(np, "settle-time-us", &mux->delay_us);

Some nitpicks, zeroing out the variable is not needed (the memory has
been cleared already) and I would like this a bit further down next
to digging out the mux-locked property.

Cheers,
Peter

> +
>  	parent = mux_parent_adapter(dev);
>  	if (IS_ERR(parent))
>  		return dev_err_probe(dev, PTR_ERR(parent),
>