Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1633326pxb; Sat, 30 Oct 2021 19:12:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPM2E3R+vZHzbDkhB6EkKHuEZIuxm9coqVECAUyshIfvXP+V68afGb2UIEYUpBvesaFeQ1 X-Received: by 2002:a17:907:6e0d:: with SMTP id sd13mr6423222ejc.482.1635646322220; Sat, 30 Oct 2021 19:12:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635646322; cv=none; d=google.com; s=arc-20160816; b=wcgKjf5RoVnmedVeti9SdR5+MacFUdyTIcliKHspzqR/nUajz8bzoRxjqKJLpU5mUV a/QaE8QDfWLXAEUsEi7qomfN2pje1S+zDBOJzWc5z/qtQZTP9ah41TSn5DXGiQa68dvK Sew98reIpVSTQZyaAsb+v4Q/Kivo3p8UkhXc9QaIuZgqc709Pajqp+XUdtrp/m14VKM3 No7p2xZt7NcYDaxeMePp1+3JH/FlOOJsuMeWvnSDO7/EXWQDTNTuypUkyLhfI6j0oqn9 QXG2nUmclfHvivqbRCixqJXnQO906uYhtrFttR3lUgem9ug3iG4dlbCoPFQVU6C+rJ24 pTBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=vqKYg6dNuNcTvm4gAvh9iY3XhP1oG3tG2dM4lX9EWLU=; b=rA9DENhQ1T/gl/v0c33g4ana42wYsaqgXU2uSnzbxRcubrPaN+Wvo2sbHvPj5XshGF 4qL1ERpKmTaIPkCVSFChpLiJcIWAITtoPkcqaUJ/Ht1zaW0mAWUabssNTd6x9Gqoq9Xz g6pIZWUAjZvj2VvrY6DoVLRmD2gGe0SpAuhRFkCP5MiXfvdpayVhwIleCFHAILbserTx W8e8Hd7BFvWU+JVXkUQB0PbErhZi91wK2yqoAxNrIX8XmtsyStmFEecYm1Q9+klGfC65 MlOzUzSCQgg1EZrrirJ+l1VO8n8uBrJGEBou5985NjE5GfvNy++D36uLEjLNUCrN1eLP Ul4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FqQ+WYpz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cs11si18997390ejc.624.2021.10.30.19.11.12; Sat, 30 Oct 2021 19:12:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FqQ+WYpz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232098AbhJaCK1 (ORCPT + 99 others); Sat, 30 Oct 2021 22:10:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232103AbhJaCKH (ORCPT ); Sat, 30 Oct 2021 22:10:07 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9683C061766 for ; Sat, 30 Oct 2021 19:07:34 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id e65so13794160pgc.5 for ; Sat, 30 Oct 2021 19:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vqKYg6dNuNcTvm4gAvh9iY3XhP1oG3tG2dM4lX9EWLU=; b=FqQ+WYpzW/8dJmtef4TQNCOMBHv/+8ehEx1sXKW5SitexXRcNqc+kl2iD6C7cIH13t X4dzh4sqB7sgNq9qVJB7U3Jid9Q8mzo5Oy3wcZFDK2RWR27DUzkz3xr7pplD1of6Hsln IME09zob+JHkU03vNL3kYCfnlEgVavqnKxEucgRolhsTqyHs6Jss015kuXyYPOrmctbf +2RQU8TGjmQVisadqnXVN2rXhe++c4jXuHDabGWx45QrcdsGlCG8dJkR+B2hLRbrxd+0 BBSpUOngyF+xyjH+G/0Vc7xZtncucyEwszkpZlGqQlkOXaYb32iktiOZqZgLA6vxe4yb d1JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vqKYg6dNuNcTvm4gAvh9iY3XhP1oG3tG2dM4lX9EWLU=; b=RSNd++6fxEdgoib/qfl8CAnihVjRxqHbWzol+FBZA90lviRxut+mwyW8Q3MH202IOw pnzoOyPT8FfbxzdePA13lgZnlMGRguHi8Xjd7RrENkLxsV7tJiy7wunr7m/UuBywKxEg 0al7/5zG9t0SUF73ll3wgm+DbVEIy1Czz/XydTXKo3Z2QCY6ni1lvtGAdVr3SBN2YSW2 RoLJ44E4We/Zfxbf7ACw2UWgGIH0HGQnBVW6eZADHwBtPojHLD3qOcEJsZ9ZlBkf6fgN 9msCwfVer+IwQRaevIB1niQv8zk+4oOfu/hzQsrSCCLecVgnLfQ7zsx+PHau5DGo8H7q +bvQ== X-Gm-Message-State: AOAM532xDhnYXbIeeH3DdRMtOxHrstlgbKIu8ZazWgpqj8LQZjUeSVYT gwPYYkQUs3Zakk/E72ZyrrUJzw== X-Received: by 2002:a63:155d:: with SMTP id 29mr5700982pgv.245.1635646053900; Sat, 30 Oct 2021 19:07:33 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id p9sm10748986pfn.7.2021.10.30.19.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Oct 2021 19:07:33 -0700 (PDT) From: Shawn Guo To: Stephen Boyd Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH 3/3] clk: qcom: smd-rpm: Drop binary value handling for buffered clock Date: Sun, 31 Oct 2021 10:07:15 +0800 Message-Id: <20211031020715.21636-4-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211031020715.21636-1-shawn.guo@linaro.org> References: <20211031020715.21636-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The buffered clock binary value handling added by commit 36354c32bd76 ("clk: qcom: smd-rpm: Add .recalc_rate hook for clk_smd_rpm_branch_ops") is redundant, because buffered clock is branch type, and the binary value handling for branch clock has been handled by clk_smd_rpm_prepare/unprepare functions. Signed-off-by: Shawn Guo --- drivers/clk/qcom/clk-smd-rpm.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index dd3d373a1309..ea28e45ca371 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -189,10 +189,6 @@ static int clk_smd_rpm_set_rate_active(struct clk_smd_rpm *r, .value = cpu_to_le32(DIV_ROUND_UP(rate, 1000)), /* to kHz */ }; - /* Buffered clock needs a binary value */ - if (r->rpm_res_type == QCOM_SMD_RPM_CLK_BUF_A) - req.value = cpu_to_le32(!!req.value); - return qcom_rpm_smd_write(r->rpm, QCOM_SMD_RPM_ACTIVE_STATE, r->rpm_res_type, r->rpm_clk_id, &req, sizeof(req)); @@ -207,10 +203,6 @@ static int clk_smd_rpm_set_rate_sleep(struct clk_smd_rpm *r, .value = cpu_to_le32(DIV_ROUND_UP(rate, 1000)), /* to kHz */ }; - /* Buffered clock needs a binary value */ - if (r->rpm_res_type == QCOM_SMD_RPM_CLK_BUF_A) - req.value = cpu_to_le32(!!req.value); - return qcom_rpm_smd_write(r->rpm, QCOM_SMD_RPM_SLEEP_STATE, r->rpm_res_type, r->rpm_clk_id, &req, sizeof(req)); -- 2.17.1