Date: Thu, 4 Jan 2007 03:48:20 -0500 (EST)
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Thomas Hisch <t.hisch@gmail.com>
cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Simplify some code to use the container_of() macro.
In-Reply-To: <20070104084224.GA3630@unknown-00-0d-60-79-ca-00.lan>
Message-ID: <Pine.LNX.4.64.0701040347360.5101@localhost.localdomain>
References: <Pine.LNX.4.64.0612311547200.30821@localhost.localdomain>
 <20070104084224.GA3630@unknown-00-0d-60-79-ca-00.lan>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 853
Lines: 21

On Thu, 4 Jan 2007, Thomas Hisch wrote:

> On Sun, Dec 31, 2006 at 03:55:22PM -0500, Robert P. J. Day wrote:
> > @@ -1810,8 +1809,7 @@ lcs_get_frames_cb(struct lcs_channel *channel, struct lcs_buffer *buffer)
> >  		LCS_DBF_TEXT(4, trace, "-eiogpkt");
> >  		return;
> >  	}
> > -	card = (struct lcs_card *)
> > -		((char *) channel - offsetof(struct lcs_card, read));
> > +	card = container_of(channel, struct lcs_card, write);
> the last argument in container_of should be read instead of write.

gack, i really made a mess of that one, didn't i?  sorry, i'll send
andrew a revised and healthy patch.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/