Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bc976b72692512f33ae90183f588af38a06a2aa1.camel@perches.com>
Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement
From:   Joe Perches <joe@perches.com>
To:     Pavel Skripkin <paskripkin@gmail.com>,
        Saurav Girepunje <saurav.girepunje@gmail.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        martin@kaiser.cx, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Cc:     saurav.girepunje@hotmail.com
Date:   Sun, 31 Oct 2021 12:17:02 -0700
In-Reply-To: <f26b4aec-c0a1-8c93-b34e-8b1a36ac81b3@gmail.com>
References: <YX7cCtVss2RWOJ/a@Sauravs-MacBook-Air.local>
         <f26b4aec-c0a1-8c93-b34e-8b1a36ac81b3@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 2021-10-31 at 21:43 +0300, Pavel Skripkin wrote:
> On 10/31/21 21:10, Saurav Girepunje wrote:
> > Remove the goto statement from rtw_init_drv_sw(). In this function goto
> > can be replace by return statement. As on goto label exit, function
> > only return it is not performing any cleanup. Avoiding goto will
> > improve the function readability.
[]
> > diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
[]
> > @@ -480,48 +480,34 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
> >   {
> >   	u8	ret8 = _SUCCESS;
> 
> Btw, this variable can be removed completely then. It's used only for:
> 
> ret8 = rtw_init_default_value(padapter);
> 
> with your patch applied, but rtw_init_default_value() always returns 
> _SUCCESS.
> 
> > -exit:
> >  	return ret8;
> >  }
> 
> And just `return _SUCCESS;` here.

And maybe one day s/_SUCCESS/true/ and s/_FAIL/false/
with appropriate conversions to bool