Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2297843pxb; Sun, 31 Oct 2021 12:29:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/PngGuPWHT8mK4846vU6PnnjJYC6hk5G+XcU0nQCPbGY1sFfCXW4wwPIWh4MwKlQ4i9DL X-Received: by 2002:a05:6402:5252:: with SMTP id t18mr33573828edd.129.1635708586282; Sun, 31 Oct 2021 12:29:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635708586; cv=none; d=google.com; s=arc-20160816; b=k2y9RCpcCZg1hZFsCVkZyc0NZOEzPSZLYmTE6cESZ5iUWgKHhCCekh0w+FiUEOuS+n 0t86PoW7h9TtaDF8YHbh7HoO3j4fMn5ydjsD1Gl9NCSNVj5sMwnYigrDFDcJPeVvmcup It8HPH32xkq8Sy+DkqWJHUPd9tyXd1VNkufMGx5OCJzpxCAqA0aJk1TCKrgBGH3ARDYX GlCkC9Wc0W8rBOimgS1P/QbsAq7LZfDnETwdj06MDLQf0VAkd3gaXDPLQfOvgR9lqvHt cAPhySp1JUdAofs1To/fZ7d2tCeG04t4G0scnVgS/aMtGcFsa14i/6PnlEpjqNBzOlGk xbNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=V5/S9C66G0DHMWVujgT6AW2yL+Z8DSmr42TXOBZj6ZQ=; b=TEn15UHniuhN2hGSNILCMr9L9TXU895wQeQaJXjl8jDeMnVQtbkOBy6B3AAteLK/qW u68Evw48T9xafFQHubFQEQ0OBQ9SShhLScXj10Mj1hJuXpW3Ey7+v9UfMS/OJ7Bqd4NI HUshso3dC23wATR7Lmul5o5U3wBk3nznEakeq6CRRST+MCVmWoNVu5Bag8r1sU2WWmZL v58V8EuNefBT1T/OPztK7iF6Cl3pbQVe3vu4oGwOx1hS0PjgYZ/DeMtskJvW8yi5NqMR 1UydORS5uQnrYrg1cGaGkRjBJa+nM3qzEeJWkSRTDepPpqMwc3WVQxe3ZlnDfThDnCBb /kCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MyFkvskn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y1si22923821eda.279.2021.10.31.12.29.23; Sun, 31 Oct 2021 12:29:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MyFkvskn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhJaTaP (ORCPT + 99 others); Sun, 31 Oct 2021 15:30:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230258AbhJaTaP (ORCPT ); Sun, 31 Oct 2021 15:30:15 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1BD9C061570 for ; Sun, 31 Oct 2021 12:27:42 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id t11so7626850ljh.6 for ; Sun, 31 Oct 2021 12:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=V5/S9C66G0DHMWVujgT6AW2yL+Z8DSmr42TXOBZj6ZQ=; b=MyFkvskn4vvk4JibQW6Cjx0hLJfgjh/VZQkhxbXCj15B6SbCVM7Py0eDRG88HIYGRW I0AzWBqabAOFKmPgApTWYQYm7gP5fKowkZ1DGxRyw6Mib0MAB04oi77HDVMW79dtRPTq /Ai05P1rXjrLfjMPETFG8+D+sdowFZY8akZx/43xX6/gpxPILBZvjDVQuWTQSjAHLOEp xk0TaZrFEHKbMMEzq7yJ75h5e8OkxrRDVKgJiEsQU+Mj8DULLPVOX8cglRyp6IQJ6KiL zeDbOxo0Aya4ULrdU9LMdGq1tYtGY4kxDfCmryznZrEO2pL8FzEqrIGswms3UmlJ9Fjd Tmnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=V5/S9C66G0DHMWVujgT6AW2yL+Z8DSmr42TXOBZj6ZQ=; b=8JeIRVtuzAyT+aFqh3xZFRJVKBWgFFGXw5oqu0F7/YUPUDDIoVvngqyaF0/d2dpKAg CwEXPmeblczAyNyEMlGFyowt5/Bqi7wAKnZHlZ6R+ezVthQA381HSn4pDfTQLlhdAvNu C6nxrYC24oOVFg2ST+Oqimi7/hscvUczTsPipPonJmL3ZsOa5mDoj51Lc3AMz2rjgWXH QMb10VYnWzyhaVj6gnyDZy1+NkL3xbjg7xtOe7ftZ9IzmTuwoFhrYWHa3RI7KkFjq2xN 4iOSRtCUVatalLlorwyPFaXRcldZNh0zUEFAStNm6X1K6ytm0+q7dw7NBg28aor3wz8d irIw== X-Gm-Message-State: AOAM533q8hgtOBTWnfBbnIxVs4GK92UpnnwbppgQ6SaUSQnkEBMGDejb D1wMeg8RAFvigHXGhmLxASs= X-Received: by 2002:a05:651c:1549:: with SMTP id y9mr27220821ljp.327.1635708461105; Sun, 31 Oct 2021 12:27:41 -0700 (PDT) Received: from [192.168.1.11] ([94.103.235.8]) by smtp.gmail.com with ESMTPSA id x14sm552614lfr.110.2021.10.31.12.27.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Oct 2021 12:27:40 -0700 (PDT) Message-ID: Date: Sun, 31 Oct 2021 22:27:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement Content-Language: en-US From: Pavel Skripkin To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: <4c566e71-2426-b776-17a2-38f5f0b6f2b6@gmail.com> In-Reply-To: <4c566e71-2426-b776-17a2-38f5f0b6f2b6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/21 22:24, Pavel Skripkin wrote: >> I think rtw_init_default_value should return void. It's return value is not useful. > > > Sure, but you need to firstly remove > `ret8 = rtw_init_default_value(padapter);` and then make it return bool ^^^^ I mean void, of course :) With regards, Pavel Skripkin