Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 31 Oct 2021 16:01:41 -0700
From:   Benson Leung <bleung@google.com>
To:     linux-kernel@vger.kernel.org,
        Prashant Malani <pmalani@chromium.org>
Cc:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC struct for
 features
Message-ID: <163572120352.2079946.6960520137860452667.b4-ty@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="twKEpGLg3YemdzOe"
Content-Disposition: inline
In-Reply-To: <20211004170716.86601-1-pmalani@chromium.org>
Precedence: bulk


--twKEpGLg3YemdzOe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Prashant,

On Mon, 4 Oct 2021 10:07:09 -0700, Prashant Malani wrote:
> The Chrome EC's features are returned through an
> ec_response_get_features struct, but they are stored in an independent
> array. Although the two are effectively the same at present (2 unsigned
> 32 bit ints), there is the possibility that they could go out of sync.
> Avoid this by only using the EC struct to store the features.

Applied, thanks!

[1/2] platform/chrome: cros_ec_proto: Use EC struct for features
      commit: 7ff22787ba49c2e66dcec92f3e2b79ef6b6a0d71
[2/2] platform/chrome: cros_ec_proto: Use ec_command for check_features
      commit: 297d34e73d491a3edbd6e8c31d33ec90447a908b

Best regards,

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--twKEpGLg3YemdzOe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCYX8gVQAKCRBzbaomhzOw
wliEAQCbb1oSHT+l35Dit0ZNiukuRBSXXnhtUrnBh3Fh8dY5OAD/cwuYeDrbDXIF
mRnfNRYQz9GLjp7HGIUd8XcR1f/X8wo=
=8WoH
-----END PGP SIGNATURE-----

--twKEpGLg3YemdzOe--