Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964814AbXADMdo (ORCPT ); Thu, 4 Jan 2007 07:33:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964815AbXADMdo (ORCPT ); Thu, 4 Jan 2007 07:33:44 -0500 Received: from myw-stp-196-34-113-139.sentechsa.net ([196.34.113.139]:38333 "EHLO craigdell.detnet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964814AbXADMdn (ORCPT ); Thu, 4 Jan 2007 07:33:43 -0500 X-Greylist: delayed 336 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Jan 2007 07:33:39 EST Date: Thu, 4 Jan 2007 14:23:30 +0200 From: Craig Schlenter To: Komuro Cc: YOSHIFUJI Hideaki / =?utf-8?B?5ZCJ6Jek6Iux5piO?= , bunk@stusta.de, jgarzik@pobox.com, viro@ftp.linux.org.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net Subject: Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer Message-ID: <20070104122330.GA2233@craigdell.detnet.com> References: <20061230185043.d31d2104.komurojun-mbn@nifty.com> <20061230.102358.106876516.yoshfuji@linux-ipv6.org> <20061230205931.9e430173.komurojun-mbn@nifty.com> <20061230.231952.16573563.yoshfuji@linux-ipv6.org> <20070105054546.953196e5.komurojun-mbn@nifty.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070105054546.953196e5.komurojun-mbn@nifty.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1107 Lines: 34 On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote: > Hi, > > I made a patch below. > With this patch, the ftp-transfer-stop problem does not happen. > Therefore, I think this is not a problem of vsftpd. > > Mr.YOSHIFUJI san, why did you set TCPOLEN_TSTAMP_ALIGNED > to iov_len? > > > > --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.000000000 +0900 > +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c 2007-01-03 15:30:44.000000000 +0900 > @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_t > TCPOLEN_TIMESTAMP); > rep.opt[1] = htonl(tcp_time_stamp); > rep.opt[2] = htonl(ts); > - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED; > + arg.iov[0].iov_len = sizeof(rep); Perhaps this was supposed to be arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED; That's what the ipv6 stuff does in places. bye, --Craig - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/