Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Zhu <hongxing.zhu@nxp.com>
To:     Mark Brown <broonie@kernel.org>
CC:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never
 came up
Thread-Topic: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never
 came up
Thread-Index: AQHXxxe5hpSrQkcPqkWGr8lEYEKQh6vjlGkAgAAC9gCAAPQyAIAAlv4AgAFuIxCAAcUHAIAA/dUAgACTWACABA5hcA==
Date:   Mon, 1 Nov 2021 01:46:35 +0000
Message-ID: <AS8PR04MB86761F6DD5395282A472CFBC8C8A9@AS8PR04MB8676.eurprd04.prod.outlook.com>
References: <1634886750-13861-1-git-send-email-hongxing.zhu@nxp.com>
 <1634886750-13861-4-git-send-email-hongxing.zhu@nxp.com>
 <20211025111312.GA31419@francesco-nb.int.toradex.com>
 <YXaTxDJjhpcj5XBV@sirena.org.uk>
 <AS8PR04MB8676A0F3DA3248C6A27801148C849@AS8PR04MB8676.eurprd04.prod.outlook.com>
 <YXffRmvPYwetsg3L@sirena.org.uk>
 <AS8PR04MB8676AF8685A951E19B1CE0688C869@AS8PR04MB8676.eurprd04.prod.outlook.com>
 <YXqOcAIO2aYkr1sM@sirena.org.uk>
 <AS8PR04MB8676CF52F4D8E9E4E6C07F758C879@AS8PR04MB8676.eurprd04.prod.outlook.com>
 <YXve+HlpEWOzZ+k3@sirena.org.uk>
In-Reply-To: <YXve+HlpEWOzZ+k3@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NqV6nzBg9/2UQ/ZwzMgQcXEI92r0sY3v0E515GT0tgQDp7asgqlUPb9FtK9X?=
 =?us-ascii?Q?6KMZnrliWv9UxRQiytDXHTNIJ4R9nopk2U7Zitq8nVOdJBLwWht42RqCe++i?=
 =?us-ascii?Q?ybeuxOpn9jYVdJTpZ6YrXHFXnHzUpCrERoymnLCUBD6IYuGkM0kkjmMBQl2p?=
 =?us-ascii?Q?POS64ySsiEhLNR0qOgeRuC3XkLNsYeZTX7AMvPRKRb3gH8JihnlTBcteVcDY?=
 =?us-ascii?Q?gcN4Ze2oO2jdRADlfXz3AwDD3vTB3LdhDGvGDOIAkYXNPrQIhmBD0TmRaCQf?=
 =?us-ascii?Q?xez73y8IM3QAyDVLBD5e9yuRtmkcqBoo8EbYVPpNbl1T0iONhBzmNeYagZI7?=
 =?us-ascii?Q?mf1B9q85MhqgdazDX5rr53goU9l4f21ysGYi3WovX5Wnfz9+taHmV+110osz?=
 =?us-ascii?Q?ux0xkfvk2sIEFOXr91YLeYcAhhlW2hhCzy3lIg36t1OCD+oEG4BtvLcLjTzD?=
 =?us-ascii?Q?XxuiVIq5wxRNIoV7gasVdVTGt5l7svnOplgwJqzLrSWu4V7+nCUxm2o6hKHc?=
 =?us-ascii?Q?NvW6N59Td61lY6JcFjV8Kso3N066cqZm1YkhZ5t6YcXa+rwM4bPLVLYqyAkn?=
 =?us-ascii?Q?2iVLl8iPRxB/L+/yYF9bL7efV0a4/JmqteGHH9FRxjLegBSljzU9QEPPe0GG?=
 =?us-ascii?Q?xfLZ+vx+GsZDwZdh3yzKnACLFaljOm3hg9SchaHxKowbUUfpoEau3IaO1/lB?=
 =?us-ascii?Q?Lkkb9DBqjfMdTlHEDhBs9DiH7DryZ5sd9sjb8ZVjiJDPyXvPpqEhjSP/VadI?=
 =?us-ascii?Q?/nYKNah2q3yHX/yA7/Y9zerYhpW1fFuc9eGB1zN5p9BQwhu00Q9/ZBzVS9cs?=
 =?us-ascii?Q?8YzhnPYMBm/U70uy48n7y3whVUSzYvB3pqhJBKgZqBSRGSrqG6a38GKbAOfF?=
 =?us-ascii?Q?X/ZHiA2UYn1TdgltIXnuorzU9MrSGeXIJSGVHMESuGpdjnrx5UODY/PlzqAP?=
 =?us-ascii?Q?SAY+GHUeAQkRsxFRnUeqNpbkhUUIKcDgtYNcqCHKHz/ATCKUSinVP01ileIW?=
 =?us-ascii?Q?QeOhtTEwprl5SOmgx0T3//zW/SF8SELbKkpORPuvmG7NKxkU8oyqZ3PQApk6?=
 =?us-ascii?Q?hCMHcSLhb29vJl//HGqvolMPT8l+08KSGKTbUZ8qto8PnPq8wwDxAce6nkOl?=
 =?us-ascii?Q?OUYky9BdLGrpaknJWU4n9FbpmN3hx3yAsTzBZiLzzqNjIPtAWTlXroXeUyKC?=
 =?us-ascii?Q?B6hFEKw55qMP5tUCn4Gcmau360oXLVKUALdUSufIt47DX412RMXj8MS352c3?=
 =?us-ascii?Q?cJ49gO5BAgowYNhZBjoumIxD2AmGMVCYRmdrpBzmmHwni7NBLbbTTMDNZGEl?=
 =?us-ascii?Q?WKtRMtSEVMMFhOBooOWPVY1k3IcoGmnTxkPXoAQbEn+q89vnWMXma9jf2iMq?=
 =?us-ascii?Q?5CuMJMXJ9zTq2Jxy/nVgYtW2pq/xypUeImxEIiD6OfGgtoiqKsgFqWy0sdbK?=
 =?us-ascii?Q?tb59Kely9vfEKzqDyfPT+/YpZuuIRk6M+lhQ1gixsL+PawjRCulCrE4LcXyv?=
 =?us-ascii?Q?M7L3/KoIhxbZB3B+fs3dPn01eS/7ZM8VAe8xlvnjFUg9+vrWLXen5OjpCQXr?=
 =?us-ascii?Q?q2YgCvfCdg4s/3CViPByAT0IwqU4+H6OmReATitaG0jFbC5l0Pv0EogyBjXb?=
 =?us-ascii?Q?bQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc11d0b8-2162-4ada-be30-08d99cd9701b
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2021 01:46:35.1322
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DCVUyfZc7qKtOOm4IqilSZrCopH8ugS/LeArIL5aV2qvggAonBekGLo2hbpfW8aUVmQFKxhUTsoOF4ohtEZKig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9208
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Friday, October 29, 2021 7:46 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Francesco Dolcini <francesco.dolcini@toradex.com>;
> l.stach@pengutronix.de; bhelgaas@google.com;
> lorenzo.pieralisi@arm.com; jingoohan1@gmail.com;
> linux-pci@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de
> Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link
> never came up
>=20
> On Fri, Oct 29, 2021 at 03:58:41AM +0000, Richard Zhu wrote:
>=20
> > > The driver should undo any enables it did itself, it should not undo
> > > any enables that anything else did which means it should never be
> > > basing decisions on regulator_is_enabled().  While the regulator may
> > > not be shared in the particular board you're looking at it may be
> > > shared in other systems.
>=20
> > [Richard Zhu] Understood. Thanks.
> > Can I disabled this regulator in PCIe probe failure handler without
> > the
> >  regulator_is_enabled() check?
>=20
> If the driver called regulator_enable() (and that didn't return an
> error) it can always call regulator_disable() as many times as it called
> regulator_enable(), no need to check if the regulator is still enabled.
> When the driver hasn't successfully called regulator_enable() it shouldn'=
t
> call regulator_disable() even if the regualtor is enabled.
> This means that after your driver has enabled the regulator it can just
> disable it but between the regulator_get() and regulator_enable() it
> shouldn't do that.
[Richard Zhu] Got that, thanks a lot.
BR
Richard