Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Nov 2021 14:54:42 +0800
From:   Dave Young <dyoung@redhat.com>
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH 0/3] x86/kexec: fix memory leak of elf header buffer
Message-ID: <YX+PMtj0gN458gTQ@dhcp-128-65.nay.redhat.com>
References: <20211029072424.9109-1-bhe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211029072424.9109-1-bhe@redhat.com>
Precedence: bulk

Hi Baoquan,

On 10/29/21 at 03:24pm, Baoquan He wrote:
> The memory leak is reported by kmemleak detector, has been existing
> for very long time. It could casue much memory loss on large machine
> with huge memory hotplug which will trigger kdump kernel reloading
> many times, with kexec_file_load interface.
> 
> And in patch 2, 3, clean up is done to remove unnecessary elf header
> buffer freeing and unneeded arch_kexec_kernel_image_load().
> 
> Baoquan He (3):
>   x86/kexec: fix memory leak of elf header buffer
>   x86/kexec: remove incorrect elf header buffer freeing
>   kexec_file: clean up arch_kexec_kernel_image_load
> 
>  arch/x86/kernel/machine_kexec_64.c | 23 +++++++++--------------
>  include/linux/kexec.h              |  1 -
>  kernel/kexec_file.c                |  9 ++-------
>  3 files changed, 11 insertions(+), 22 deletions(-)
> 
> -- 
> 2.17.2
> 

Acked-by: Dave Young <dyoung@redhat.com>

nitpick: the first two patches can be merged togeter, but I'm also fine if
they are in two patches.

Thanks
Dave