Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1634870456.git.wuzongyong@linux.alibaba.com>
 <cover.1635493219.git.wuzongyong@linux.alibaba.com> <CACGkMEv8+1YMhXfS31CoyFuwJ-toCLXd12ny7b=Ge+3fXWNYUw@mail.gmail.com>
 <20211101062250.GA29814@L-PF27918B-1352.localdomain>
In-Reply-To: <20211101062250.GA29814@L-PF27918B-1352.localdomain>
From:   Jason Wang <jasowang@redhat.com>
Date:   Mon, 1 Nov 2021 15:02:52 +0800
Message-ID: <CACGkMEvZkdEgAFpSo1Oen5JWthSowZ7NHqnp_X5AhNt+jxuiZg@mail.gmail.com>
Subject: Re: [PATCH v7 0/9] vDPA driver for Alibaba ENI
To:     Wu Zongyong <wuzongyong@linux.alibaba.com>
Cc:     virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        mst <mst@redhat.com>, wei.yang1@linux.alibaba.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 1, 2021 at 2:23 PM Wu Zongyong <wuzongyong@linux.alibaba.com> wrote:
>
> On Mon, Nov 01, 2021 at 11:31:15AM +0800, Jason Wang wrote:
> > On Fri, Oct 29, 2021 at 5:15 PM Wu Zongyong
> > <wuzongyong@linux.alibaba.com> wrote:
> > >
> > > This series implements the vDPA driver for Alibaba ENI (Elastic Network
> > > Interface) which is built based on virtio-pci 0.9.5 specification.
> >
> > It looks to me Michael has applied the patches, if this is the case,
> > we probably need to send patches on top.
>
> What do you mean by saying "send patches on top"?
> Sorry, I'm a newbie to contribute for kernel, could you please explain
> it in detail?

I meant you probably need to send incremental patch on top of:

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next.

Thanks


>
> Thanks
> > Thanks
> >
> > >
> > > Changes since V6:
> > > - set default min vq size to 1 intead of 0
> > > - enable eni vdpa driver only on X86 hosts
> > > - fix some typos
> > >
> > > Changes since V5:
> > > - remove unused codes
> > >
> > > Changes since V4:
> > > - check return values of get_vq_num_{max,min} when probing devices
> > > - disable the driver on BE host via Kconfig
> > > - add missing commit message
> > >
> > > Changes since V3:
> > > - validate VIRTIO_NET_F_MRG_RXBUF when negotiate features
> > > - present F_ORDER_PLATFORM in get_features
> > > - remove endian check since ENI always use litter endian
> > >
> > > Changes since V2:
> > > - add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE instead
> > >   VDPA_ATTR_DEV_F_VERSION_1 to guide users to choose correct virtqueue
> > >   size as suggested by Jason Wang
> > > - present ACCESS_PLATFORM in get_features callback as suggested by Jason
> > >   Wang
> > > - disable this driver on Big Endian host as suggested by Jason Wang
> > > - fix a typo
> > >
> > > Changes since V1:
> > > - add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1 to indicate whether
> > >   the vdpa device is legacy
> > > - implement dedicated driver for Alibaba ENI instead a legacy virtio-pci
> > >   driver as suggested by Jason Wang
> > > - some bugs fixed
> > >
> > > Wu Zongyong (9):
> > >   virtio-pci: introduce legacy device module
> > >   vdpa: fix typo
> > >   vp_vdpa: add vq irq offloading support
> > >   vdpa: add new callback get_vq_num_min in vdpa_config_ops
> > >   vdpa: min vq num of vdpa device cannot be greater than max vq num
> > >   virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min}
> > >   vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE
> > >   eni_vdpa: add vDPA driver for Alibaba ENI
> > >   eni_vdpa: alibaba: fix Kconfig typo
> > >
> > >  drivers/vdpa/Kconfig                   |   8 +
> > >  drivers/vdpa/Makefile                  |   1 +
> > >  drivers/vdpa/alibaba/Makefile          |   3 +
> > >  drivers/vdpa/alibaba/eni_vdpa.c        | 553 +++++++++++++++++++++++++
> > >  drivers/vdpa/vdpa.c                    |  13 +
> > >  drivers/vdpa/virtio_pci/vp_vdpa.c      |  12 +
> > >  drivers/virtio/Kconfig                 |  10 +
> > >  drivers/virtio/Makefile                |   1 +
> > >  drivers/virtio/virtio_pci_common.c     |  10 +-
> > >  drivers/virtio/virtio_pci_common.h     |   9 +-
> > >  drivers/virtio/virtio_pci_legacy.c     | 101 ++---
> > >  drivers/virtio/virtio_pci_legacy_dev.c | 220 ++++++++++
> > >  drivers/virtio/virtio_vdpa.c           |  16 +-
> > >  include/linux/vdpa.h                   |   6 +-
> > >  include/linux/virtio_pci_legacy.h      |  42 ++
> > >  include/uapi/linux/vdpa.h              |   1 +
> > >  16 files changed, 917 insertions(+), 89 deletions(-)
> > >  create mode 100644 drivers/vdpa/alibaba/Makefile
> > >  create mode 100644 drivers/vdpa/alibaba/eni_vdpa.c
> > >  create mode 100644 drivers/virtio/virtio_pci_legacy_dev.c
> > >  create mode 100644 include/linux/virtio_pci_legacy.h
> > >
> > > --
> > > 2.31.1
> > >
>