Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Nov 2021 09:46:23 +0100
From:   Sean Nyekjaer <sean@geanix.com>
To:     Boris Brezillon <boris.brezillon@collabora.com>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks
 while scanning bbt
Message-ID: <20211101084623.xrpwwvweez24svib@skn-laptop>
References: <20211026055551.3053598-1-sean@geanix.com>
 <20211026055551.3053598-2-sean@geanix.com>
 <20211101083824.236b9983@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211101083824.236b9983@collabora.com>
Precedence: bulk

On Mon, Nov 01, 2021 at 08:38:24AM +0100, Boris Brezillon wrote:
> On Tue, 26 Oct 2021 07:55:48 +0200
> Sean Nyekjaer <sean@geanix.com> wrote:
> 
> > From: Boris Brezillon <boris.brezillon@collabora.com>
> > 
> > The BBT scan logic use the MTD helpers before the MTD layer had a
> > chance to initialize the device, and that leads to issues when
> > accessing the uninitialized suspend lock. Let's temporarily set the
> > suspend/resume hooks to NULL to skip the lock acquire/release step.
> > 
> > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
> 
> I think I already mentioned this Fixes tag should not be there.
> 

No, I didn't recall that, but nevermind :)

Hmm when ('mtd: core: protect access to MTD devices while in suspend')
is backported we want to live with the use before init of the rwsem?

/Sean