Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Nov 2021 17:02:43 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        Steven Noonan <steven@valvesoftware.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3 08/21] cpufreq: amd: add acpi cppc function as the
 backend for legacy processors
Message-ID: <YX+tM7FOQBKqHetw@hr-amd>
References: <20211029130241.1984459-1-ray.huang@amd.com>
 <20211029130241.1984459-9-ray.huang@amd.com>
 <16386852-7ccb-47de-5b29-b64481b59237@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16386852-7ccb-47de-5b29-b64481b59237@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Akvo65018BgQB8XnDv3mmVYzEH2GqNmm0i2voME7rFTrKWpoO95FVPg4TCtR?=
 =?us-ascii?Q?dIt8KazLtEqBZkjezpfvrvykPVqr6/Erybu2AJeCjCuJ/R1IgwhPSGBXUpP1?=
 =?us-ascii?Q?1HohIXYP3e7c/WcvLh3luejSMP8k1AHGiS4gT8UsgcxNemRp6aAL4GxPo6de?=
 =?us-ascii?Q?fQgWrfD4rKa9Vxc1a11CjfQ4JDx9vREJPn5/m5JlbKj06iauuQ66/UZfbhgI?=
 =?us-ascii?Q?V4cuQk/l7PLrUc25GgMOcRYt1U2eGbEGAivv7YqM5tkRLqpum28lutwg28sX?=
 =?us-ascii?Q?eVeHjVHcUABD8cWnJbJy/e6YIaaoNtCQKqEg9u4SnuLw49cn96P8efl/KSsp?=
 =?us-ascii?Q?3w9W0gK/nex0RAB87Y6KFfHtRQb5I6AXT5Gi/thGIZE6YK7MieUuTKWnY3fN?=
 =?us-ascii?Q?k1KBWmQMxsg2Nb9GGkixj9YjusCLVkKuLVaj2ao2qSTBCAUIYjshCHH8TFO3?=
 =?us-ascii?Q?mM1eAlN2rZV5Sxlxr2bOYLCl/uNAr8V/cHjkIFG4DHhx6qYAn0RhaPu8m223?=
 =?us-ascii?Q?KSAR2gWToVeoCJ4UoZuCxUk8TFSHEvbTGInV88jTj0P4za2cNUtniGwRXMgk?=
 =?us-ascii?Q?75Bj+aR4k9OqIQI1l/E8qaPEfFhotiofQsDQHbBKX/n7AbrkfZ6qsL7lQal7?=
 =?us-ascii?Q?w6DH+sdVmrdDjJkcM+UnY5IjZ4bKFaPDh+kucsq9NFF3YOL1Ouo+hnpULF3R?=
 =?us-ascii?Q?/kSpVEsgD/y42ufAzWLYJRtHbU+2r1gqUiIUGXbREg9P0A/WAegCIq0mkOR7?=
 =?us-ascii?Q?k750vRaMolAf4GUXJd2zzqzQ7/il5BnC14Jj4YIZhq9Cca+kmYW7GnrI7ILI?=
 =?us-ascii?Q?uFC0FMEsK4+SoSHwO8jbQ+Itqd3wbDtnYV5op5omZkO9MRGGAkXZI5uPaNaz?=
 =?us-ascii?Q?ER0fpE44hAVyQhP9H1l3q0ShYhusXO6GkTJYu9UCsoXL11hrRpXxTYGnkllK?=
 =?us-ascii?Q?gTK0stlnzTqI2U+C6/32mb1RGzCziQ8D+JPBVF//lVkgwNLh0CX6uuyqJJ5D?=
 =?us-ascii?Q?cDCC5Jvblr+mygRIh1mP3CuR3BeipFm97eZzFcPhtbT48q80TnSy0TvchJ8v?=
 =?us-ascii?Q?/QZODh8qEcqlZrL1f88XpWWUDnAQJ/L9WbRxm0rHg31WVkbKKo1bMbOUYFte?=
 =?us-ascii?Q?83CbCHlmLpmnAOgOTNyR4oxqg+SJCaYCYfSq5k43tP9FkTYf7qwjb9oNG85k?=
 =?us-ascii?Q?oF4L24g6tS3u6XIiDkvW0IFLWO5Pv6bfnM8A23CAcLHqs0uDF7arMIpMcRmv?=
 =?us-ascii?Q?wkXmlyR06+zxRJA8XLRP/qlwKhJxjoAKMOo5crRRe6AVHUya3PmdIqH13/x2?=
 =?us-ascii?Q?+/fXLvLyxCDE0RzfRU59WXmTrSq3Gh0sJOVk0nx2uTQuxrdgfB6cvRIB+FE+?=
 =?us-ascii?Q?5WzpO3E9o2uQDKAES4ii7SA6uQY1iOVmc0awTyuidP7lHtLD4UK/KBdz2GXh?=
 =?us-ascii?Q?WARvZqOG3vXfd8qtCkXQDqwaeQ6DoZrvj2YTk2B75ufmWSm8DohUrMlcdmQm?=
 =?us-ascii?Q?gLG9lM7cdPDJo5s+GyUGZbd33qWiaf0Dk6QFhFKVh1qAqduxOHzxWjXti0eL?=
 =?us-ascii?Q?+n3pKfIpIFAx89+1PiztQ757/T3UmYNujNVBiZUNpL8w9SFmhJnLsQcFR/xK?=
 =?us-ascii?Q?REmPTe+4jHdei0G2mry9sew=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 558f681d-5dbb-4e12-fd22-08d99d166b8d
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB0246.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 09:03:07.0853
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1xgG2MpLsnZsADYRDFtDwi/CGDF4tGpcwBR0opOMYWVyUOpMpKPCXsSjmNSlL3bopYbhaQEeAYvkftF6M1ub/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1864
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 29, 2021 at 10:20:09PM +0800, Limonciello, Mario wrote:
> On 10/29/2021 08:02, Huang Rui wrote:
> > In some old Zen based processors, they are using the shared memory that
> > exposed from ACPI SBIOS.
> 
> I don't think this is only "old" processors.  I think there are "new" 
> processors that just don't happen to implement the MSR too.
> 

Yes, I will correct the description.

> > 
> > Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com>
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> >   drivers/cpufreq/amd-pstate.c | 58 ++++++++++++++++++++++++++++++++----
> >   1 file changed, 53 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 55ff03f85608..d399938d6d85 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -73,6 +73,19 @@ static inline int pstate_enable(bool enable)
> >   	return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable ? 1 : 0);
> >   }
> >   
> > +static int cppc_enable(bool enable)
> > +{
> > +	int cpu, ret = 0;
> > +
> > +	for_each_online_cpu(cpu) {
> 
> I wonder if this should also be changed to present CPU instead of 
> offline CPU.  Otherwise could this turn into a situation that the user 
> starts with some CPU's offlined and enables them later but this doesn't 
> end up applying to the CPUs that were started offlined and changed?
> 

Yes, make sense. It is actually similiar with previous acpi_cpc_valid fix
patch. I will update it in V4.

Thanks,
Ray