Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/3] ARM: dts: aspeed: mtjade: Add some gpios
From:   Quan Nguyen <quan@os.amperecomputing.com>
To:     Joel Stanley <joel@jms.id.au>
Cc:     Rob Herring <robh+dt@kernel.org>, Andrew Jeffery <andrew@aj.id.au>,
        devicetree <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20211019060155.945-1-quan@os.amperecomputing.com>
 <20211019060155.945-2-quan@os.amperecomputing.com>
 <CACPK8Xcp0ruL-7p3AA+yvba3Drrwm-=-hMnMpd=a1aHwQHnE1A@mail.gmail.com>
 <87d82a93-cdc2-d95a-4ab9-085ff31c4387@os.amperecomputing.com>
Message-ID: <4eb31178-cf05-24cd-6a75-6628689cef25@os.amperecomputing.com>
Date:   Mon, 1 Nov 2021 16:25:38 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <87d82a93-cdc2-d95a-4ab9-085ff31c4387@os.amperecomputing.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3M0OEJlT1pMMUZkdDFkQStSdU5OVU0rTEpyWk14RjdwZ29KMjFmYTRiVW5N?=
 =?utf-8?B?b1BRUStKdDMrYWdEdENjSTF2V0tZNjhTeHBydUlUR2pwRE51Q1c3ZEJhWk4y?=
 =?utf-8?B?MXduNWY1ZkVPeVpSZHRmY0NuRWQrd2dSZ09GdnZvZ1JlN2c2NUJaL1B2Tnox?=
 =?utf-8?B?RExicWU5VDhxK2hKejBrakRmODIxRTlCdnF5OFNsNFIwR3BKVjhjN2xMMUla?=
 =?utf-8?B?OXJjcFEydlNPeklhbVVzeG1qaGMvNXY0OUpoQVVrc1VVbTNTYjUySm5LMnNR?=
 =?utf-8?B?ZTU4RUZpRmVIRXg3UnA5bE9SME1qa2tzWHpPZDRTTnlFSFdsd3pxdDl6Wmdt?=
 =?utf-8?B?b1Ivam1aUXhra1pQLzZsV3QrYkJtUlEzbHJXRjNkckxaWkVQMy9vQnc0enl0?=
 =?utf-8?B?OVFQZDdIOHJKTTY0d25LOWRYRjQ0MmdnQkE0UTRqM0ppckVJbnBBLzJkUzFw?=
 =?utf-8?B?cy9ZdHI3c01aT003V2xldWlpbm1CUXluZG5wck9xQWJDT1B2MXgyMktyVnlh?=
 =?utf-8?B?NU1pQTVJenJaZjM1WldFZUZaeks5NEZyVTM2MHV3Zk9GSTgxYnVIdUd1elJY?=
 =?utf-8?B?T3Y3SjJsWGplampuZ3FlTkxHWVpockt5ZHpZeEtKMVdJUnhrNWdWREJqdTNa?=
 =?utf-8?B?M05QM0pWM2VmZ1VySWFLQllqNTNmOUo5TkVIVEZHOG5qUDhrL0toR1dQQmU5?=
 =?utf-8?B?cjRRN0xsRVJlRXBNYzVvKzJ2dUg4UnN4YmRDNnorZTI4TkNzQkRCTklpRjN4?=
 =?utf-8?B?dm9SZFM4RWIvSVYydXpGcmM1dFRCQ0p5ZU9yM3RHamU4RVlkMHF2QTQxZUV0?=
 =?utf-8?B?UjJHNyswR2dMci9QVnFYKzNtSnhmRkpmbmNkWTluYzNPRFN3d2pmQnh3ZnZG?=
 =?utf-8?B?YUNJV3JPMWsyTDAvMERvQ2JoOVN5RnNjK3JONkdFVncrZTdDckxCU0hxNlJZ?=
 =?utf-8?B?Y3VGN2Z0SVdLNGcySnVDbXdPRE1mR1V0ZmxHOW1DVXkxREVSWHdWN1JxT2s4?=
 =?utf-8?B?MnByWVREVGMzbENCQ1lWWjJWU0lyVjJQa2tHNnJOSFF1elc0TUlNUXlOM1Z3?=
 =?utf-8?B?aDJZV0I5eWJXZ2FSVkJWc0tDbHUyT1Bmdk9PeDFHYTZ3YWErbnp4VE9ydWhn?=
 =?utf-8?B?TC9yQWhqZ2l5dzY4Qzlqem1SbXlEWC95aGVmK3V1eDY5SGN1ZjdleThLOFp3?=
 =?utf-8?B?M0RyeFUvTldqTlpZWWtRLzBDL1F2VVkzSnBkUVd0WjI3WkJhSEtuUUNZUUxC?=
 =?utf-8?B?RHJVTldVV3NWQmRxQzQrZnNXM2Z3ZFBrcUwrVDBvUmNaUFNMbThqZC9PTE9S?=
 =?utf-8?B?bnlIcVl2eDZVZW9xNTQ3V1crS3VnVkFDL29zcFQyYVpGSnM2WmJ2czQxaC9m?=
 =?utf-8?B?M1VYVEt5dnFrL1ZPOTFDS0FybzBmNU85MUdrWUFrUVFLV1duMGsyd2tKdkhC?=
 =?utf-8?B?blowc3hpZitUUGpUeDV5R3F2Q1lPc3hSNjJrcFd6K1h5SFhZOGV3T0ZxbzZl?=
 =?utf-8?B?S2Z6d0RWUDl1amExVFNvWU5GY05QT0pIeGxpK01mTTdJTmtVZmVrTlhqazJM?=
 =?utf-8?B?U3lCcVpaZTEwZGNjU1FpTHpiYkJoU3lqTEVJRENwSW1JV1VvZ09IL2pKT0tv?=
 =?utf-8?B?WXQ4UGNQUVdZOE9aa0U3M0xGMzc3Ni9GTkJvcWhkYWU4QnJCbEVBT1VsVi81?=
 =?utf-8?B?YUFLSllRRDFpQVUzNWZ1TlR6QmYrQWpGL3Z4R2JuOEJqRFRyLy9KaFFXenND?=
 =?utf-8?B?WkRpSEZkZFpGQTl5R2wzdDB3a0ZBVlVVc3dlUmVVZFU1ekc3T2dwTHJ0UHRW?=
 =?utf-8?B?M3BkMGdyNGk4TERLd0gvTWVOcXh1SkQyZGlocmNsYSs2WTBLeFpTdGRGbjhI?=
 =?utf-8?B?bGo2RzhBR1hqdE9uYi9rNTJTa3hua1lHTE5rRWpOWkpYb21sZFZiemRObCtl?=
 =?utf-8?B?emQzWU5XL2ZEYWkwbHVyVEZZZnNZaGFZTkhQRHp1OXI1UTIyMHVQRHc4L01O?=
 =?utf-8?B?d3FOVzV4V0RIZUJHb3lRY1pieVA3d3BEMWVjenJvNTJ3eDh4S2Z2eEZLcEhH?=
 =?utf-8?B?YW43SlNGTnFzN29IRnowbUprRmhmOUNaeFpWSEdqVDVyVTFXaHlVRC81YWFi?=
 =?utf-8?B?TkJRZUFCSlJPallmaytkTHJVdDVNcVZwMG1VaU9xd2RrT2t1RWpvSG5rY2h0?=
 =?utf-8?B?dG1wZzA3a0RuQ2pJL2ZyczhJL3NZVEE4ZU1YUnVYaXRnY0M2N2JVcTgrdEc0?=
 =?utf-8?B?MGdraUh4RFVmS2RtWmhPVFNFWExBPT0=?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d24f3781-ee90-4fb2-e45b-08d99d199676
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 09:25:47.6331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iACUcMsSKxYPDsqAgovTNy5ehWPlI0kf1NXgHXL3W7uB6wQOSM1wDb2EUPddbK2Wkza6+lHK+ycTCMGNtiihh3C/q1x1dsG6sc2LWEY395k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB7415
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Joel,

I found this patch appears in linux-next tree as in [1], can we expect 
the remain two patches in this patchset ([2] and [3]) will be merged soon?

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20211029&id=0b32c1b4071c482f2cf98b717cfc7380423ec619

[2] https://www.spinics.net/lists/kernel/msg4115571.html
[3] https://www.spinics.net/lists/kernel/msg4115572.html

Thanks,
- Quan

On 25/10/2021 11:44, Quan Nguyen wrote:
> On 19/10/2021 13:46, Joel Stanley wrote:
>> On Tue, 19 Oct 2021 at 06:02, Quan Nguyen 
>> <quan@os.amperecomputing.com> wrote:
>>>
>>> Add S0_SCP_AUTH_FAIL, S1_SCP_AUTH_FAIL gpios to indicates firmware
>>> authentication fail on each socket.
>>
>> These use the gpio-keys API to expose the GPIOs. I think OpenBMC is
>> moving away from this abstraction, and instead reading the GPIOs with
>> the gpio chardev interface.
>>
> Thanks Joel for the review,
> Yes, will switch to use gpio chardev interface and will remove these 
> gpio-keys defined in next version
> 
>>>
>>> Add gpio RTC_BAT_SEN_EN to enable RTC battery adc sensor.
>>>
>>> Add BMC_I2C4_O_EN gpio to go high at boot to enable access to I2C4 bus.
>>
>> OpenBMC has started a process to document GPIOs that are exposed to
>> userspace, initially so a common userspace can be used across
>> machines. I like doing it for the additional reason that it provides
>> consistency in the naming.
>>
>> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md 
>>
>>
>> If you could take a look at that document and add your GPIOs where
>> possible, and then update the device tree.
>>
> 
> There is on-going discussion about naming of the RTC voltage sensing 
> enable gpio pin in [1], So I'd like to address this change later in 
> separate patch when this is settled. Hence, I will remove this changes 
> in next version.
> 
> [1] https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/48018
> 
> About the BMC_I2C4_O_EN, this is needed as gpio-hog to make the i2c bus 
> accessible at boot time so I will keep this in next version.
> In fact, I'm still a bit of confuse if this pin needs a common name as 
> it is just to enable the bus access and does not serve for any 
> particular common purpose.
> 
> Thanks,
> - Quan
> 
>>>
>>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>>> Signed-off-by: Thang Nguyen <thang@os.amperecomputing.com>
>>> ---
>>> v2:
>>>    - None
>>>
>>>   .../arm/boot/dts/aspeed-bmc-ampere-mtjade.dts | 21 ++++++++++++++++++-
>>>   1 file changed, 20 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts 
>>> b/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts
>>> index 57b0c45a2298..3515d55bd312 100644
>>> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts
>>> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts
>>> @@ -86,6 +86,18 @@ S0_cpu_fault {
>>>                          linux,code = <ASPEED_GPIO(J, 1)>;
>>>                  };
>>>
>>> +               S0_scp_auth_fail {
>>> +                       label = "S0_SCP_AUTH_FAIL";
>>> +                       gpios = <&gpio ASPEED_GPIO(J, 2) 
>>> GPIO_ACTIVE_LOW>;
>>> +                       linux,code = <ASPEED_GPIO(J, 2)>;
>>> +               };
>>> +
>>> +               S1_scp_auth_fail {
>>> +                       label = "S1_SCP_AUTH_FAIL";
>>> +                       gpios = <&gpio ASPEED_GPIO(Z, 5) 
>>> GPIO_ACTIVE_LOW>;
>>> +                       linux,code = <ASPEED_GPIO(Z, 5)>;
>>> +               };
>>> +
>>>                  S1_overtemp {
>>>                          label = "S1_OVERTEMP";
>>>                          gpios = <&gpio ASPEED_GPIO(Z, 6) 
>>> GPIO_ACTIVE_LOW>;
>>> @@ -590,7 +602,7 @@ &gpio {
>>>          /*Q0-Q7*/       "","","","","","UID_BUTTON","","",
>>>          /*R0-R7*/       "","","BMC_EXT_HIGHTEMP_L","OCP_AUX_PWREN",
>>>                          "OCP_MAIN_PWREN","RESET_BUTTON","","",
>>> -       /*S0-S7*/       "","","","","","","","",
>>> +       /*S0-S7*/       "","","","","RTC_BAT_SEN_EN","","","",
>>
>> I suggest you create a proposal to call this one
>> battery-voltage-read-enable. I know that some of the IBM machines
>> intend to have this same GPIO.
>>
>>>          /*T0-T7*/       "","","","","","","","",
>>>          /*U0-U7*/       "","","","","","","","",
>>>          /*V0-V7*/       "","","","","","","","",
>>> @@ -604,4 +616,11 @@ &gpio {
>>>                          "S1_BMC_DDR_ADR","","","","",
>>>          /*AC0-AC7*/     
>>> "SYS_PWR_GD","","","","","BMC_READY","SLAVE_PRESENT_L",
>>>                          "BMC_OCP_PG";
>>> +
>>> +       i2c4_o_en {
>>> +               gpio-hog;
>>> +               gpios = <ASPEED_GPIO(Y, 2) GPIO_ACTIVE_HIGH>;
>>> +               output-high;
>>> +               line-name = "BMC_I2C4_O_EN";
>>> +       };
>>>   };
>>> -- 
>>> 2.28.0
>>>
>