Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2827069pxb; Mon, 1 Nov 2021 02:38:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXnaAkaZ3VpCK63r5TsJvwEmiXJC7d9B9iz80KYEiQcLyUtNIcdmvdaTu/TlyevH4jhp0c X-Received: by 2002:a02:c761:: with SMTP id k1mr21261244jao.74.1635759519037; Mon, 01 Nov 2021 02:38:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635759519; cv=none; d=google.com; s=arc-20160816; b=RaTyyMJcBNwAF0IRhqO0yNU6o4Z6jOXrcPO+YYA0s0k6seQJpDHVKa6VDsa1n+xc5p ET4gZaJefqb69lLuSu4/hMhTm/ou8tDu3Vucbb2vRBv1Z7Jg7S+buBq/TwuTQT0/8Wpw hoU/Ta3Mrzlnmv4f4EMzuSlAwfvUjUz7Rx3MH5iDv77juBeAL5RpKBonoXoYwyWiOcSn it+71d9QGau2m5lib9jVDdSG6+lhgZI3a20iODPR9FY6VvWX3DQXx2Ul+llSanvHFixI b6jqxhXtU3BrVIs2/qowduQa5ZkkZAvt6qBEGZvQdZ60iMWaA5HfyFTA4Uwo4eJYmAxT 45iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mzJ0gxV46ujOPDBdeAI16t3EioogZHrPSSeUKCbGw4c=; b=GjE8J8OxipOx9srTvfTcrQyRywsEQkTh1LRIJSNlRoZ62L08XMEPaURfFHYcARTNM0 ROV3f2/gy6PE/4kPSdTXfFLgqDZE2P3W/yYDfOnjHmrH+cdOBWlEnzM+CxZpq/zaKT1P 7szwx60Yi1OOb06EvQeE9Uyg5P7eUcpXjvyjQUi/UkKaweXPsaZPLQlyZKOMxREq7YaP sIU9i6supzlxfeJvtXLPOrgqoy8r0jf/1bYfQK8+OSCr77Z+EaJGs2vhyRcjDzW3f4nv 3izGfRCWSHSqMg3mKgKxN3uwfSVTbUkzVx1ZLCcPnX79RhYjnaJ8I2TxhvvlTM1I/961 d3BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yj09Bz2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m15si12371148jat.58.2021.11.01.02.38.27; Mon, 01 Nov 2021 02:38:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yj09Bz2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233834AbhKAJiV (ORCPT + 99 others); Mon, 1 Nov 2021 05:38:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:43582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233097AbhKAJfq (ORCPT ); Mon, 1 Nov 2021 05:35:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 10FF6610A8; Mon, 1 Nov 2021 09:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635758758; bh=neNbb1lS9mPDKJJTeoCw3hvhNrfP6N74eu6k6XZsfNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yj09Bz2bpqbNMY1eOoXJ28znkT2wEWDMhXz1bNN534oMatkrtBj1dyxWOmqOTgyoS At1Leyuqma+0WgGy9fMMn/i/l7SHOlUJ/eeySique+SPqBOYugASzhgkyXH3jRZEG5 U8YeeJE/YSyPq3XMlWn6KtLpIzhX2NLYL+CRXfqM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jim Quinlan , Florian Fainelli , Philipp Zabel Subject: [PATCH 5.10 47/77] reset: brcmstb-rescal: fix incorrect polarity of status bit Date: Mon, 1 Nov 2021 10:17:35 +0100 Message-Id: <20211101082521.697454410@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211101082511.254155853@linuxfoundation.org> References: <20211101082511.254155853@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jim Quinlan commit f33eb7f29c16ba78db3221ee02346fd832274cdd upstream. The readl_poll_timeout() should complete when the status bit is a 1, not 0. Fixes: 4cf176e52397 ("reset: Add Broadcom STB RESCAL reset controller") Signed-off-by: Jim Quinlan Signed-off-by: Florian Fainelli Link: https://lore.kernel.org/r/20210914221122.62315-1-f.fainelli@gmail.com Signed-off-by: Philipp Zabel Signed-off-by: Greg Kroah-Hartman --- drivers/reset/reset-brcmstb-rescal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/reset/reset-brcmstb-rescal.c +++ b/drivers/reset/reset-brcmstb-rescal.c @@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct } ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg, - !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000); + (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000); if (ret) { dev_err(data->dev, "time out on SATA/PCIe rescal\n"); return ret;