Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2831442pxb; Mon, 1 Nov 2021 02:45:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynIOjtznVNQhJX3dH5D5wZ1VoIs3HoBNC6F6nTYkT5DsouicfeE0OrdLF6jCI6DqhZI76d X-Received: by 2002:a92:3642:: with SMTP id d2mr19702480ilf.234.1635759934963; Mon, 01 Nov 2021 02:45:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635759934; cv=none; d=google.com; s=arc-20160816; b=NnoapYgldL0Vz2r2lt0DTozcqznsVrsfh/cSHbFfG2FQ66TCFJw56C+T7gklkqa8Go e0A6/sfJKVd1cnqx23875H7VZZtZk0WBtvzR7/TaZEhc3vjwL6wTzsuUq5E1NuysS448 JBlGE4ykMJuwGjvPnx4a+6WM2rWgkVMDr0fg7fVheGRoqggFXMINv+oM78bV5u/piSi/ y6wgyVUQjuItU7ObA0lnAKWb19DqNwxNAbVIwZ4CgHYdxaT+HHaJ59pVxpj9+7djcTGl qe9Wv8kudC+gXaXZ7UdoXWsImJ1/SO+bcTKb3g1EDOcN/c42E2ZySg3gkvTSg3UQLs5z ZFdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WFFb2AZabGEzgbRk6ixkI4AmWx8nqE8vcv2w08QCT9w=; b=kbcO4C7hXzpuN7pVLLe4c9Ufn5mwcps2FXBV4lE5C9I5JP12E1wUne1cgORVpvWMak /jbENuO6PGp+auKtRJOT/UP+prJzrT3m3YbgBeMbHK65TUx6SNulzwDmW28qIqZiiYsp DUDOQmxj4bNuowO7zZdLEw4pc2FNygUb4xhXn55YWK1ci9Xifu9QBFWAQ5YAOClGw6Jk zC14RqBCuzCGAxmPjWMdPQtlyDCbhsL/cozGKdcsORZYTp1ZuZH2FVg6znh+XSe0Ba0O VgF+YqDSlEkSe5Q2NtaYGFc7BfNa2kcEwq0WdNvCoOBP34tNsWeGNM8Sh46lZCLtmHPO lbRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XbSR1ng3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si11720398ilm.76.2021.11.01.02.45.23; Mon, 01 Nov 2021 02:45:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XbSR1ng3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234507AbhKAJqv (ORCPT + 99 others); Mon, 1 Nov 2021 05:46:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:47954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233378AbhKAJmC (ORCPT ); Mon, 1 Nov 2021 05:42:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 208296120A; Mon, 1 Nov 2021 09:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635758919; bh=m4vu12vnujXJGiY9YknzWfRdnNvdxK4B2TtJrvSzznY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XbSR1ng3dj5DblevfX3oxj9at1Kz7Quxhoze970NexW7vEpAVhCIfi9MEqMBqiZgS nEO4m2MHfodcLpyYu6vVdincvVSfg3WeQWg+h+Mk/mx79Q/KZuP4L55hjyN2dp4pBD s+ZMQHbEXaNRDvuqAVNjORUWpBwGOP09GeWTbMmw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum , syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com, Johan Hovold , Jakub Kicinski Subject: [PATCH 5.14 008/125] usbnet: sanity check for maxpacket Date: Mon, 1 Nov 2021 10:16:21 +0100 Message-Id: <20211101082535.007667353@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211101082533.618411490@linuxfoundation.org> References: <20211101082533.618411490@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 397430b50a363d8b7bdda00522123f82df6adc5e upstream. maxpacket of 0 makes no sense and oopses as we need to divide by it. Give up. V2: fixed typo in log and stylistic issues Signed-off-by: Oliver Neukum Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com Reviewed-by: Johan Hovold Link: https://lore.kernel.org/r/20211021122944.21816-1-oneukum@suse.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/usbnet.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1788,6 +1788,10 @@ usbnet_probe (struct usb_interface *udev if (!dev->rx_urb_size) dev->rx_urb_size = dev->hard_mtu; dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1); + if (dev->maxpacket == 0) { + /* that is a broken device */ + goto out4; + } /* let userspace know we have a random address */ if (ether_addr_equal(net->dev_addr, node_id))