Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2834187pxb; Mon, 1 Nov 2021 02:49:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzggksuuQxCbRMRiusbmI1bcQNSLYTttJuFD10i1L304U0UeFUdo9Z5BL4IFurO+IrD7cHc X-Received: by 2002:a05:6602:29c7:: with SMTP id z7mr20398671ioq.93.1635760188319; Mon, 01 Nov 2021 02:49:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635760188; cv=none; d=google.com; s=arc-20160816; b=CpGLpdXF3+xk9owrb8+WLW0ose2UhL5ktJ9mBS0Tfsq/IrMdalKitPlBWULQLXnZf9 nN71X1V835/UkCfyOUMw79edmjQ/e78wkfE6tJn9vduPJKlNApeiDQl7MhDJ6IbChdtX SUz9+SQJpnjTtfqCC3U9pUVQwc/bhQbYnslQFu+xWwLlEH/9K7jZ3i30D4aVVqtsd9O6 enrHaNefi6732zxmVHr6sg9xkGPsHj9ccY+nHEc3K84eXrrTnjt5oI6uKVT9IyAb/5yC I61X4ZQJWf02zpxssrxqrmQ9MLLYQmQzt7dKCnf6Yeov+1J1I9/20qFPRSXST8FnEDna niMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7fIBeSnNJFZb7XNj+UvHcNXO/UAD9vTZ6txEgGx7oSU=; b=lgEIPWt+g3XriiLJPC3m0WYcTVDOhenkqFLhBUEBLeokC/RZJAZPXRwapkLKzjk+cZ y6FjSCgQaEApQbg9vZJOBRmynruy4JMcp5cPv/RWN0OgM5v1xrrk2REvZhr1n91pKjJh 2Mh/C6MixYdTna6jPjGGn2MfPCHU0cxLiF5tGCVMBSQnGjww7D/UfJx6XbQKQic3vFrR erioukQJ9v5RRqrm32Ktazg35EFSetisod2F/Z4x8stpf2djzQlFX2BNOSRSNQhxnfqP EbuwXsV1hBSFpfp+iRdcwu8MSJoXus0kRWbhSZ/zAwzxDoyWcESbDP7GfjeWawWb9e9c eBkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XSmg2U9p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s22si2091113jaj.128.2021.11.01.02.49.37; Mon, 01 Nov 2021 02:49:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XSmg2U9p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234539AbhKAJu6 (ORCPT + 99 others); Mon, 1 Nov 2021 05:50:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:51404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234222AbhKAJrV (ORCPT ); Mon, 1 Nov 2021 05:47:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D0A32613D0; Mon, 1 Nov 2021 09:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635759045; bh=iSymP04eayXhdaeGBYoXyAWFkq35uLJ1B/yaG+QOIgE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XSmg2U9peoVewmOKiCzrgk6BD9Z2Y4ahfnGSrtRKgQ0WDcmOtdgLuOqir2MSk8AjV f1nB0son8mgdwXSr1R6QzVLsNCeEHydOcQiBzdYEjBn4vLqn1nfiwVMzryD/SfaFOF tqONECKpAwj+oL7kzeKCOfVpbw3ttjQ/Kr0uZqnM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Daniel Jordan , "David S. Miller" Subject: [PATCH 5.14 091/125] net/tls: Fix flipped sign in async_wait.err assignment Date: Mon, 1 Nov 2021 10:17:44 +0100 Message-Id: <20211101082550.322947855@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211101082533.618411490@linuxfoundation.org> References: <20211101082533.618411490@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Jordan commit 1d9d6fd21ad4a28b16ed9ee5432ae738b9dc58aa upstream. sk->sk_err contains a positive number, yet async_wait.err wants the opposite. Fix the missed sign flip, which Jakub caught by inspection. Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance") Suggested-by: Jakub Kicinski Signed-off-by: Daniel Jordan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tls/tls_sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -459,7 +459,7 @@ static void tls_encrypt_done(struct cryp /* If err is already set on socket, return the same code */ if (sk->sk_err) { - ctx->async_wait.err = sk->sk_err; + ctx->async_wait.err = -sk->sk_err; } else { ctx->async_wait.err = err; tls_err_abort(sk, err);