Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2834813pxb; Mon, 1 Nov 2021 02:50:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziuURdtd9H9iNT9jAGWwmOFaP5HfvjyogsybDHkEeSazP7yb4+9+MB/8/XV7d2nRnRck/N X-Received: by 2002:a5e:890e:: with SMTP id k14mr18691968ioj.187.1635760245486; Mon, 01 Nov 2021 02:50:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635760245; cv=none; d=google.com; s=arc-20160816; b=BwgC6gbpJMan8coYIlPxlbgARj5L2pTjARCkY6fBbA0uyy/0ytffXcocE8RjhC3bt+ IEZ7qONCLBpqne6V0LuXHeQzJ6vhxpIJSXRcR6X/dWBHMjKdEy2yHFwUFqpXKNrdCVZ3 wR+4p0Ql+rrfzG//gMWX1u4LVddqp+6MelTQcK88p2ww2xYWwcrRxzov0pWkae8JvGMz hBmYiU3KxxEdTf52MumazameAJBOMfxRPe7g2+UMzPQnZlGe6meTSScmg1bBp2DPLd0W /2PqNahzvPSVH2Kp+y6e0XZjsDXUcLzuyR8qOzzyHUycR2hkqNbDJSspZ+blBf/9nOul GV2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/XK5ahqllXJLRkAfs4RRYj35r5DG5kgq+ivsspLIu9w=; b=wU3d0zAEroRMAGg5GeaKtBY+ARoW6WuuO+JsXWdZZcoUpSG+17ckZ66/6jEXAiFrnC M2ALoqJknWNq1Fc3JrvoIN1GF2i+InQsBGc4WRCkK6Np5QcmBb0p727SO9bpGxMyU4xB glfPzLejcv2mSg8w0iKuVzB18e+pz5erYApZALJNi8efEApG7PAjNc1kLnT5vbqkTJfC x3rFIiFuTklaWlhI+EaTcgKDIzrbJdLBsA7Oyh8Mm8zjpj27PBptUug/bwbf6xEFb7oe +MD2Sy9KnypGc6I5FV3aNJrYsD4z5lCftUEQA5Nu0SwMOkqQr2eihkqKm/KvHU7Qg9mQ sqtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IAJeUxp7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si13112561iow.101.2021.11.01.02.50.33; Mon, 01 Nov 2021 02:50:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IAJeUxp7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233187AbhKAJwO (ORCPT + 99 others); Mon, 1 Nov 2021 05:52:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:52156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234054AbhKAJqb (ORCPT ); Mon, 1 Nov 2021 05:46:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 82FC8613CF; Mon, 1 Nov 2021 09:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635759022; bh=JA/Hy1hpfPf7wnT5E4+pX4LGsaySt6Qf6WS3/GHh638=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IAJeUxp7sQzaWjq4UQ6e09SQH5WWz4lHQ0QMR3BSYJHTKAFviYaX5rwgHn11VUaTO VRFB7x8LUyao7RVchQA9gR4N95nHJoHyaRU1CDJdO20TOCXy79KGJv9R5vig/MPb5W Y4JSSgeLgKtnItYvzN/iqXM1lFgyWs5tnI1dvtSI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonas Gorski , Chris Packham , Florian Fainelli , Linus Walleij , Bartosz Golaszewski Subject: [PATCH 5.14 082/125] gpio: xgs-iproc: fix parsing of ngpios property Date: Mon, 1 Nov 2021 10:17:35 +0100 Message-Id: <20211101082548.797499643@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211101082533.618411490@linuxfoundation.org> References: <20211101082533.618411490@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonas Gorski commit 85fe6415c146d5d42ce300c12f1ecf4d4af47d40 upstream. of_property_read_u32 returns 0 on success, not true, so we need to invert the check to actually take over the provided ngpio value. Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver") Signed-off-by: Jonas Gorski Reviewed-by: Chris Packham Reviewed-by: Florian Fainelli Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-xgs-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpio/gpio-xgs-iproc.c +++ b/drivers/gpio/gpio-xgs-iproc.c @@ -224,7 +224,7 @@ static int iproc_gpio_probe(struct platf } chip->gc.label = dev_name(dev); - if (of_property_read_u32(dn, "ngpios", &num_gpios)) + if (!of_property_read_u32(dn, "ngpios", &num_gpios)) chip->gc.ngpio = num_gpios; irq = platform_get_irq(pdev, 0);