Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2836413pxb; Mon, 1 Nov 2021 02:53:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqXLO7HAEs/tKBrbRxfkdrhDMHpUxT7UrR6MNYnyKUCt+i9yg+/ztbGSi+Bfhx+oWXK/rN X-Received: by 2002:a17:906:6089:: with SMTP id t9mr36292282ejj.323.1635760408203; Mon, 01 Nov 2021 02:53:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635760408; cv=none; d=google.com; s=arc-20160816; b=XuyQh57IpuscJstxfEl1tyGhsybXbXhzk3ie2SZ4tXUHBKnC0WPyNTmd8E3YPVGCTY Bl3CsuCi1/I2BSrGvmmJ5djRyJSjEIcnJbUYGZC3/8UMZnVOJi0NUQMK+0Unyxcp9iGT CBI5OxUFSs+2fqyN9PbfaaQFDBgz058FOc2T1L4SkwXPjETots3SYSXP7raj3j6K7Kwe 1I0SgHXW4bnjQEK4qEMIo7tqAgJruiv38QDp1pMmgxdgGseGDQr9RyyYWWWotG9cmonH xF0GjdSJVEytTKF/KZ/Jzvm3fo85TU+Fh97mwGJLWuevx2/wvXYDtuxQit8tEZzY8ZcM TCyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mzJ0gxV46ujOPDBdeAI16t3EioogZHrPSSeUKCbGw4c=; b=ohQHv9lJRJEMCaGDkD6MKhyzotwc001TFI1GV/xgpQePDUNXeeaz9XfBTOh43XTue9 JCV3RuM6H5WiR3Ns2zx4ppcn9jjRpmDZGfXbZxMsLKZh6j2/cx1VarFJRs3jK7tY879B e3cIrr/kQ3JLATLf16iTk4LAW6qLNC2N7ImiP6eobDx2V1miBvoUi7Pmw6oAVXIYpBkc LXRefgmhMBe0hZewqWANNVpW3A6+nq3DG1x5ENRNtJszp4VP6Uz9x0oQz1mPk9VybjPo QWO/8OodE9vMkxeZLcTOi2VNcrspEh3733As5AVY96qTkW5OH818VpM9CQ5UcCFrSOya LxKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kfkmfHZu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si25295669edb.538.2021.11.01.02.53.04; Mon, 01 Nov 2021 02:53:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kfkmfHZu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234837AbhKAJxN (ORCPT + 99 others); Mon, 1 Nov 2021 05:53:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:50956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234731AbhKAJss (ORCPT ); Mon, 1 Nov 2021 05:48:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 21E9A6117A; Mon, 1 Nov 2021 09:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635759080; bh=neNbb1lS9mPDKJJTeoCw3hvhNrfP6N74eu6k6XZsfNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kfkmfHZu956Qf3etTizVZfGwTZlemKapYA7empkh+PVg77h0xV/EM3NYwRtnj4q45 XMudmcdjNjILRYxQCMxSvuM9KuUa5JWzqUfOcVqPhr5itjY+4YaAV805uPY2lAdOQ+ 3kM+kA/ng77ZQc63ppVfmba8/X1S7+zizZh9NLoM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jim Quinlan , Florian Fainelli , Philipp Zabel Subject: [PATCH 5.14 074/125] reset: brcmstb-rescal: fix incorrect polarity of status bit Date: Mon, 1 Nov 2021 10:17:27 +0100 Message-Id: <20211101082547.226921183@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211101082533.618411490@linuxfoundation.org> References: <20211101082533.618411490@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jim Quinlan commit f33eb7f29c16ba78db3221ee02346fd832274cdd upstream. The readl_poll_timeout() should complete when the status bit is a 1, not 0. Fixes: 4cf176e52397 ("reset: Add Broadcom STB RESCAL reset controller") Signed-off-by: Jim Quinlan Signed-off-by: Florian Fainelli Link: https://lore.kernel.org/r/20210914221122.62315-1-f.fainelli@gmail.com Signed-off-by: Philipp Zabel Signed-off-by: Greg Kroah-Hartman --- drivers/reset/reset-brcmstb-rescal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/reset/reset-brcmstb-rescal.c +++ b/drivers/reset/reset-brcmstb-rescal.c @@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct } ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg, - !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000); + (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000); if (ret) { dev_err(data->dev, "time out on SATA/PCIe rescal\n"); return ret;