Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Nov 2021 18:59:36 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Mike Leach <mike.leach@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        James Clark <james.clark@arm.com>, coresight@lists.linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] coresight: etm4x: Add lock for reading virtual
 context ID comparator
Message-ID: <20211101105936.GA352474@leoy-ThinkPad-X240s>
References: <20211031144214.237879-1-leo.yan@linaro.org>
 <20211031144214.237879-2-leo.yan@linaro.org>
 <df07c7b0-0145-8290-b4cd-a1831f19330d@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <df07c7b0-0145-8290-b4cd-a1831f19330d@arm.com>
Precedence: bulk

Hi Suzuki,

On Mon, Nov 01, 2021 at 09:49:06AM +0000, Suzuki Kuruppassery Poulose wrote:
> Hi Leo
> 
> On 31/10/2021 14:42, Leo Yan wrote:
> > When read the virtual context ID comparator value via sysfs node, the
> > driver firstly reads out the index, then reads the comparator value
> > based on index. >
> > This patch adds the spinlock to protect the atomicity for up two steps.
> 
> minor nit: This could be :
> 
> "Updates to the values and the index are protected via the
> spinlock. Ensure we use the same lock to read the value
> safely"

Yeah, this is more simple and clear.  Will use it.

> With that:
> 
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Thanks for review.

Leo