Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3092785pxb; Mon, 1 Nov 2021 07:44:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoHbszzHCL8kCk5zr0NSGxOXfIB8/vBwpK2WgfuqXmnhRiagd/F9CmjSyeUpsynzeZH5zk X-Received: by 2002:aa7:cd6a:: with SMTP id ca10mr37898503edb.79.1635777876149; Mon, 01 Nov 2021 07:44:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635777876; cv=none; d=google.com; s=arc-20160816; b=JU+GoWJGCWxSPRh3c4IoSGugY6y0rbbMthVIerWzmd5wwYZsU6Q8A8ClOng/hPTiEt P+LOv+UYVv0PpRa0AD3aFLUvFWmDyv5RV/by0vIK3vKL7yZn0/SOJG71KRjbCccByQA+ VrMo/ZrtMPsw0W6O9xctZ+9bucb11GDf5p6O5a2zPQsf0yrG5iaNCpbcQJLAy41ezT6Y HBCHpIAeC3PNACwaukce8nXT3vfu/CKWqIhVFJiHQ3kpr0m9Mahys1PkbyhhInPa3sZe rq+wCuRgrF9S9/tEgBjC6mwnULaMBfLyQrgIFLnMe8A3aVpeQSQkXgpWqEr/wQB0U6yd c/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=QkLiXBYPS+6udSUJAfl/L/pIj1UeQQKS8a3o68QwalA=; b=yttxoMhu6gaNBnA8E8cTgrkQxZd2K2MhEozYBnBGih4ElcURmS5vFo4Nhfb9xyHr2Z cr9fdaSuRQy5XinroFaWkMIBlx9jFJ5pVaTTkea/OjBQcUl1KQgrN2fJrmzNEcHzJJ2s YzgfyJonmPNHUTfur7csRrr7mu/th/ESTtL67XwfiqcZ70MNwjSOToAn0w6Mg2QvxJuf sCbHGdDEyr31m7y5V4LrxDxmA2gfgzO9nNFtZNFD68DiLqj5Ng8/xkWn2s7EdGNXpwLv c28vnVzf4kZJUd8JnEaXH6JFFek9Ol4aPgG359DkM26q9zSQ7bP98RoUNJsWt/cQVtzs qpXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=XH0Q5LZF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n1si24409149edb.104.2021.11.01.07.44.11; Mon, 01 Nov 2021 07:44:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=XH0Q5LZF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbhKAOok (ORCPT + 99 others); Mon, 1 Nov 2021 10:44:40 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:35208 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbhKAOoj (ORCPT ); Mon, 1 Nov 2021 10:44:39 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1A1EfkgL109511; Mon, 1 Nov 2021 09:41:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1635777706; bh=QkLiXBYPS+6udSUJAfl/L/pIj1UeQQKS8a3o68QwalA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=XH0Q5LZFDq2zIz6TWNWUVTSYYr9zpBxnRenbCcrTqb4/NMu25B2WS8rSm+XMrgXPd vNDq7c7gdJ857eLDM024Ht0cxIDGJ7NKwF4WiJfFn3xQcVhWcE4u5HfgXay2PYw/Mq BjdNHLCdVeKcojX/Ts51f59XEVNWzdabCsnubaHg= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1A1EfkZp054851 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 1 Nov 2021 09:41:46 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 1 Nov 2021 09:41:46 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 1 Nov 2021 09:41:46 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1A1EfhNA059398; Mon, 1 Nov 2021 09:41:44 -0500 Subject: Re: [PATCH] PM: runtime: Allow rpm_resume() to succeed when runtime PM is disabled To: Ulf Hansson , "Rafael J. Wysocki" CC: Alan Stern , "Rafael J . Wysocki" , Linux PM , Kevin Hilman , Maulik Shah , Linux ARM , Linux Kernel Mailing List References: <20211026222626.39222-1-ulf.hansson@linaro.org> <20211027020235.GA1306582@rowland.harvard.edu> <20211027143343.GC1319606@rowland.harvard.edu> From: Grygorii Strashko Message-ID: <641a41bc-68ea-c0e9-9430-faf3803e12d5@ti.com> Date: Mon, 1 Nov 2021 16:41:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2021 11:27, Ulf Hansson wrote: > On Fri, 29 Oct 2021 at 20:27, Rafael J. Wysocki wrote: >> >> On Fri, Oct 29, 2021 at 12:20 AM Ulf Hansson wrote: >>> >>> On Wed, 27 Oct 2021 at 16:33, Alan Stern wrote: >>>> >>>> On Wed, Oct 27, 2021 at 12:55:43PM +0200, Ulf Hansson wrote: >>>>> On Wed, 27 Oct 2021 at 04:02, Alan Stern wrote: >>>>>> >>>>>> On Wed, Oct 27, 2021 at 12:26:26AM +0200, Ulf Hansson wrote: >>>>>>> During system suspend, the PM core sets dev->power.is_suspended for the >>>>>>> device that is being suspended. This flag is also being used in >>>>>>> rpm_resume(), to allow it to succeed by returning 1, assuming that runtime >>>>>>> PM has been disabled and the runtime PM status is RPM_ACTIVE, for the >>>>>>> device. >>>>>>> >>>>>>> To make this behaviour a bit more useful, let's drop the check for the >>>>>>> dev->power.is_suspended flag in rpm_resume(), as it doesn't really need to >>>>>>> be limited to this anyway. >>>>>>> >>>>>>> Signed-off-by: Ulf Hansson >>>>>>> --- >>>>>>> drivers/base/power/runtime.c | 4 ++-- >>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c >>>>>>> index ec94049442b9..fadc278e3a66 100644 >>>>>>> --- a/drivers/base/power/runtime.c >>>>>>> +++ b/drivers/base/power/runtime.c >>>>>>> @@ -742,8 +742,8 @@ static int rpm_resume(struct device *dev, int rpmflags) >>>>>>> repeat: >>>>>>> if (dev->power.runtime_error) >>>>>>> retval = -EINVAL; >>>>>>> - else if (dev->power.disable_depth == 1 && dev->power.is_suspended >>>>>>> - && dev->power.runtime_status == RPM_ACTIVE) >>>>>>> + else if (dev->power.disable_depth > 0 && >>>>>>> + dev->power.runtime_status == RPM_ACTIVE) >>>>>> >>>>>> IIRC there was a good reason why the original code checked for >>>>>> disable_depth == 1 rather than > 0. But I don't remember exactly what >>>>>> the reason was. Maybe it had something to do with the fact that during >>>>>> a system sleep __device_suspend_late calls __pm_runtime_disable, and the >>>>>> code was checking that there were no other disables in effect. >>>>> >>>>> The check was introduced in the below commit: >>>>> >>>>> Commit 6f3c77b040fc >>>>> Author: Kevin Hilman >>>>> Date: Fri Sep 21 22:47:34 2012 +0000 >>>>> PM / Runtime: let rpm_resume() succeed if RPM_ACTIVE, even when disabled, v2 >>>>> >>>>> By reading the commit message it's pretty clear to me that the check >>>>> was added to cover only one specific use case, during system suspend. >>>>> >>>>> That is, that a driver may want to call pm_runtime_get_sync() from a >>>>> late/noirq callback (when the PM core has disabled runtime PM), to >>>>> understand whether the device is still powered on and accessible. >>>>> >>>>>> This is >>>>>> related to the documented behavior of rpm_resume (it's supposed to fail >>>>>> with -EACCES if the device is disabled for runtime PM, no matter what >>>>>> power state the device is in). >>>>>> >>>>>> That probably is also the explanation for why dev->power.is_suspended >>>>>> gets checked: It's how the code tells whether a system sleep is in >>>>>> progress. >>>>> >>>>> Yes, you are certainly correct about the current behaviour. It's there >>>>> for a reason. >>>>> >>>>> On the other hand I would be greatly surprised if this change would >>>>> cause any issues. Of course, I can't make guarantees, but I am, of >>>>> course, willing to help to fix problems if those happen. >>>>> >>>>> As a matter of fact, I think the current behaviour looks quite >>>>> inconsistent, as it depends on whether the device is being system >>>>> suspended. >>>>> >>>>> Moreover, for syscore devices (dev->power.syscore is set for them), >>>>> the PM core doesn't set the "is_suspended" flag. Those can benefit >>>>> from a common behaviour. >>>>> >>>>> Finally, I think the "is_suspended" flag actually needs to be >>>>> protected by a lock when set by the PM core, as it's being used in two >>>>> separate execution paths. Although, rather than adding a lock for >>>>> protection, we can just rely on the "disable_depth" in rpm_resume(). >>>>> It would be easier and makes the behaviour consistent too. >>>> >>>> As long as is_suspended isn't _written_ in two separate execution paths, >>>> we're probably okay without a lock -- provided the code doesn't mind >>>> getting an indefinite result when a read races with a write. >>> >>> Well, indefinite doesn't sound very good to me for these cases, even >>> if it most likely never will happen. >>> >>>> >>>>>> So overall, I suspect this change should not be made. But some other >>>>>> improvement (like a nice comment) might be in order. >>>>>> >>>>>> Alan Stern >>>>> >>>>> Thanks for reviewing! >>>> >>>> You're welcome. Whatever you eventually decide to do should be okay >>>> with me. I just wanted to make sure that you understood the deeper >>>> issue here and had given it some thought. For example, it may turn out >>>> that you can resolve matters simply by updating the documentation. >>> >>> I observed the issue on cpuidle-psci. The devices it operates upon are >>> assigned as syscore devices and these are hooked up to a genpd. >>> >>> A call to pm_runtime_get_sync() can happen even after the PM core has >>> disabled runtime PM in the "late" phase. So the error code is received >>> for these real use-cases. >>> >>> Now, as we currently don't check the return value of >>> pm_runtime_get_sync() in cpuidle-psci, it's not a big deal. But it >>> certainly seems worth fixing in my opinion. >>> >>> Let's see if Rafael has some thoughts around this. >> >> Am I thinking correctly that this is mostly about working around the >> limitations of pm_runtime_force_suspend()? > > No, this isn't related at all. > > The cpuidle-psci driver doesn't have PM callbacks, thus using > pm_runtime_force_suspend() would not work here. > i think reason for (dev->power.disable_depth == 1 && dev->power.is_suspended) can be found in [1], as other related comments: Rafael J. Wysocki: >>> I've discussed that with Kevin. The problem is that the runtime PM status may be changed at will when runtime PM is disabled by using __pm_runtime_set_status(), so the status generally cannod be trusted if power.disable_depth > 0. During system suspend, however, runtime PM is disabled by the core and if neither the driver nor the subsystem has disabled it in the meantime, the status should be actually valid. <<< Hence, this is about using PM runtime for CPU PM and, CPU PM is pretty specific case, wouldn't manual check for CPU PM status work for you, like !pm_runtime_status_suspended()? (if i'm not mistaken - CPU PM done in atomic context). [1] http://lkml.iu.edu/hypermail/linux/kernel/1209.2/03256.html -- Best regards, grygorii