Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Nov 2021 15:36:34 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Richard Zhu <hongxing.zhu@nxp.com>
Cc:     l.stach@pengutronix.de, bhelgaas@google.com,
        lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
        linux-pci@vger.kernel.org, linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v4 5/6] PCI: imx6: Fix the regulator dump when link never
 came up
Message-ID: <YYAJglJlR6bVbQ/L@sirena.org.uk>
References: <1635747478-25562-1-git-send-email-hongxing.zhu@nxp.com>
 <1635747478-25562-6-git-send-email-hongxing.zhu@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="UhufA6iKSde21dpx"
Content-Disposition: inline
In-Reply-To: <1635747478-25562-6-git-send-email-hongxing.zhu@nxp.com>
Precedence: bulk


--UhufA6iKSde21dpx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 01, 2021 at 02:17:57PM +0800, Richard Zhu wrote:

> When PCIe PHY link never came up and vpcie regulator is present, there
> would be following dump when try to put the regulator.
> Add a new host_exit() callback for i.MX PCIe driver to disable this
> regulator and fix this dump when link never came up.

This looks like a good improvement, though it still looks like there are
issues given the checks for the regulator being NULL.  This might be
better fixed as a separate patch though.

--UhufA6iKSde21dpx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGACYEACgkQJNaLcl1U
h9B7NAf9GgzzucQ+0irq/DERGpVAY0vuLGY5/KSlf63hKoxBO6EtbGqhcDRlV4z5
HIDjTO6iiPfo0dUbRBjpwbmTN2Y9i2k/VnW8Lm1tfgub5/139tYPQv6Aw0FKS+Ql
KPOGD+OOOvrdQ9ZLhJ0dd7sIqvEJGef9CP9B6RHdh+K3LZWNBN8JlUWlQHAgQQAz
nk8RLGTHHpsEY4C8tqFGB+ugf6aQJCQltHJD6PO+eX4JByiDo9g9qUlDtvTn+Y5t
bFzFVisrPBxbZMS75nxQNDNNW4LkDulyiIC5AauzL69d/c1HawWddlVtDGrlVNEU
qyDWkDcEgPv5TcXnQ6smRfpARv7R7w==
=lWlW
-----END PGP SIGNATURE-----

--UhufA6iKSde21dpx--