Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3173115pxb; Mon, 1 Nov 2021 09:07:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyk41AlYMCOg6rZPYLuU2rtrNSQOE0a9vV5EEW+YpFZIG+ZnMi2xaQY88LVK2pWYYUUqbOu X-Received: by 2002:a05:6638:14ce:: with SMTP id l14mr12316023jak.142.1635782878972; Mon, 01 Nov 2021 09:07:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635782878; cv=none; d=google.com; s=arc-20160816; b=VdkgxCZ9DGeB65pdq4v5tONFYmy+wHE9wBkohLDGGb0d28HoHxQlz9R7VIS4f588ym 3983FjZdn92qOajfGEVrxfwagJpRf8g5w25meCtrXUicTRJ2riMd/9c1HYKYTLC7Xfr7 Mims7xbLSSSTyiRYKSNFMVaKJ+WSiUxo1bJBmWCS7BkHxXbxiBzQuSB4BsPci6uUl928 nT2nPtj9lnU5GIyFevI1Yt5jx/MPKc/mQdkqonvfViHHms44s4RpDvyU2CEphsVXmh/o swL7tZmvfQQR0WM4z7C3YqACpN8ypobIf0ESF9a+jviSH3xNXgXwz25OtBi+MHEDtvlP adnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=I4C0bwKjovjZmKwxAHZOFqegiOnPReMzLPhs6K4fqVs=; b=Wt2tiuZsK4f5H6yHr6vLsTqz3teJJhUf6yZHA/FvPkxOMeblLLU9lQBskYCliSydar N/PsHQR4bGSVXdCaHIGGW84eVL/qv4btR2NVIAfMxMR0QLgro1MCQ3+gj7pyvtLJKQAu xVrYzcYJKRsOKQWwBU74GGrKHppqzc0YeO+AOhOMn0iILNoiUgZ9I8Cb6yFRNFBgFOx7 /17B3W9gKev3Vkp+XBju4NZFvlDl53vxiAYVCZQ6k4dvTN0eZmM9NkDI0/Qegx7qFjgW S9HFpBrbGuyG+lx8xoaX5vRIABrJrIx8zlTVmeZzOE0lRnRIpqPzMjDA8o1+RCrTIEKO ADZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si12071245ilu.154.2021.11.01.09.07.46; Mon, 01 Nov 2021 09:07:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232627AbhKAQJT (ORCPT + 99 others); Mon, 1 Nov 2021 12:09:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:37154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230517AbhKAQJS (ORCPT ); Mon, 1 Nov 2021 12:09:18 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D66A610FC; Mon, 1 Nov 2021 16:06:39 +0000 (UTC) Date: Mon, 1 Nov 2021 12:06:36 -0400 From: Steven Rostedt To: Petr Mladek Cc: Yafang Shao , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Peter Zijlstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , christian , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , David Miller , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot Subject: Re: [PATCH v7 00/11] extend task comm from 16 to 24 Message-ID: <20211101120636.3cfc5afa@gandalf.local.home> In-Reply-To: References: <20211101060419.4682-1-laoar.shao@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Nov 2021 17:02:12 +0100 Petr Mladek wrote: > > I thought Steven[1] and Kees[2] have already clearly explained why we > > do it like that, so I didn't give any more words on it. > > > > [1]. https://lore.kernel.org/all/20211025170503.59830a43@gandalf.local.home/ > > Steven was against switching task->comm[16] into a dynamically > allocated pointer. But he was not against storing longer names > separately. Just to be clear. I was recommending that the comm[16] would still behave like it does today. Where it is truncated. But if the name is longer, it could be stored in a separate location if the caller wanted to know the full name. -- Steve