Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <dc4c54b79fb350c9c682ec9bca27562dc32c63e5.camel@perches.com>
Subject: Re: [PATCH v2] staging: r8188eu: Use kzalloc() with GFP_ATOMIC in
 atomic context
From:   Joe Perches <joe@perches.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Larry Finger <Larry.Finger@lwfinger.net>
Date:   Mon, 01 Nov 2021 09:42:46 -0700
In-Reply-To: <11283844.I1tDBM3C2B@localhost.localdomain>
References: <20211101142732.5638-1-fmdefrancesco@gmail.com>
         <d1a8eb91-adb9-2163-dc3d-9f86ebdc45e3@lwfinger.net>
         <11283844.I1tDBM3C2B@localhost.localdomain>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-11-01 at 17:30 +0100, Fabio M. De Francesco wrote:
> On Monday, November 1, 2021 4:11:26 PM CET Larry Finger wrote:
> > Incidentally, I disagree with checkpatch in that I think that 
> > sizeof(struct foo) is more descriptive than sizeof(*bar). 
> I agree with you in full

It's not checkpatch in particular, it's from coding-style

The preferred form for passing a size of a struct is the following:

.. code-block:: c

	p = kmalloc(sizeof(*p), ...);